* 2.6.0-test5 - stuck keys on iBook
@ 2003-09-30 21:31 cliff white
2003-09-30 23:09 ` Tom Rini
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: cliff white @ 2003-09-30 21:31 UTC (permalink / raw)
To: linuxppc-dev, linux-kernel
Kernel version: latest from ppc.bkbits.net/linuxppc-2.5
Symptom: keyboard diarrhea - single keypress == 3-7 characters.
I've tried reverting drivers/input/keyboards/atkbd.c back to v1.31, doesn't
change anything.
Haven't done much other debug, since i can't successfully login to the system
from console.
Further information if needed.
Please cc me if you reply from linuxppc-dev, i am not on that group.
cliffw
cliffw@osdl.org
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: 2.6.0-test5 - stuck keys on iBook
2003-09-30 21:31 2.6.0-test5 - stuck keys on iBook cliff white
@ 2003-09-30 23:09 ` Tom Rini
2003-10-01 13:48 ` Brice Figureau
2003-10-03 7:40 ` [PATCH] macintosh/adbhid.c REP_DELAY fix (was Re: 2.6.0-test5 - stuck keys on iBook) Brice Figureau
2 siblings, 0 replies; 5+ messages in thread
From: Tom Rini @ 2003-09-30 23:09 UTC (permalink / raw)
To: cliff white; +Cc: linuxppc-dev, linux-kernel
On Tue, Sep 30, 2003 at 02:31:49PM -0700, cliff white wrote:
>
> Kernel version: latest from ppc.bkbits.net/linuxppc-2.5
>
> Symptom: keyboard diarrhea - single keypress == 3-7 characters.
>
> I've tried reverting drivers/input/keyboards/atkbd.c back to v1.31, doesn't
> change anything.
Just FYI, atkbd isn't used on pmacs.
--
Tom Rini
http://gate.crashing.org/~trini/
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: 2.6.0-test5 - stuck keys on iBook
2003-09-30 21:31 2.6.0-test5 - stuck keys on iBook cliff white
2003-09-30 23:09 ` Tom Rini
@ 2003-10-01 13:48 ` Brice Figureau
2003-10-03 7:40 ` [PATCH] macintosh/adbhid.c REP_DELAY fix (was Re: 2.6.0-test5 - stuck keys on iBook) Brice Figureau
2 siblings, 0 replies; 5+ messages in thread
From: Brice Figureau @ 2003-10-01 13:48 UTC (permalink / raw)
To: linuxppc-dev; +Cc: cliff white, linux-kernel
On Tue, 2003-09-30 at 23:31, cliff white wrote:
> Kernel version: latest from ppc.bkbits.net/linuxppc-2.5
>
> Symptom: keyboard diarrhea - single keypress == 3-7 characters.
I can confirm this problem on my ibook r2.2 with vanilla kernel.org 2.6.0-test6.
No problem with the latest test5 I tried.
Brice
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] macintosh/adbhid.c REP_DELAY fix (was Re: 2.6.0-test5 - stuck keys on iBook)
2003-09-30 21:31 2.6.0-test5 - stuck keys on iBook cliff white
2003-09-30 23:09 ` Tom Rini
2003-10-01 13:48 ` Brice Figureau
@ 2003-10-03 7:40 ` Brice Figureau
2003-10-03 15:19 ` Benjamin Herrenschmidt
2 siblings, 1 reply; 5+ messages in thread
From: Brice Figureau @ 2003-10-03 7:40 UTC (permalink / raw)
To: cliff white; +Cc: linuxppc-dev, linux-kernel
Hi Cliff,
On Tue, 2003-09-30 at 23:31, cliff white wrote:
> Kernel version: latest from ppc.bkbits.net/linuxppc-2.5
>
> Symptom: keyboard diarrhea - single keypress == 3-7 characters.
Here is a patch that fixes the keyboard problem. The input layer
REP_DELAY (and REP_PERIOD) were changed from jiffies to ms but the adb
was not updated accordingly.
I hope this will help you.
Brice
--- drivers/macintosh/adbhid.c.orig 2003-10-02 22:39:31.112571794 +0200
+++ drivers/macintosh/adbhid.c 2003-10-02 22:40:22.888120863 +0200
@@ -611,8 +611,8 @@
/* HACK WARNING!! This should go away as soon there is an utility
* to control that for event devices.
*/
- adbhid[id]->input.rep[REP_DELAY] = HZ/2; /* input layer default: HZ/4 */
- adbhid[id]->input.rep[REP_PERIOD] = HZ/15; /* input layer default: HZ/33 */
+ adbhid[id]->input.rep[REP_DELAY] = 500; /* input layer default: 250 */
+ adbhid[id]->input.rep[REP_PERIOD] = 66; /* input layer default: 33 */
}
}
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] macintosh/adbhid.c REP_DELAY fix (was Re: 2.6.0-test5 - stuck keys on iBook)
2003-10-03 7:40 ` [PATCH] macintosh/adbhid.c REP_DELAY fix (was Re: 2.6.0-test5 - stuck keys on iBook) Brice Figureau
@ 2003-10-03 15:19 ` Benjamin Herrenschmidt
0 siblings, 0 replies; 5+ messages in thread
From: Benjamin Herrenschmidt @ 2003-10-03 15:19 UTC (permalink / raw)
To: Brice Figureau; +Cc: cliff white, linuxppc-dev list, Linux Kernel list
On Fri, 2003-10-03 at 09:40, Brice Figureau wrote:
> Hi Cliff,
>
> On Tue, 2003-09-30 at 23:31, cliff white wrote:
> > Kernel version: latest from ppc.bkbits.net/linuxppc-2.5
> >
> > Symptom: keyboard diarrhea - single keypress == 3-7 characters.
>
> Here is a patch that fixes the keyboard problem. The input layer
> REP_DELAY (and REP_PERIOD) were changed from jiffies to ms but the adb
> was not updated accordingly.
>
> I hope this will help you.
Thanks, I'll test & commit.
Ben.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2003-10-03 15:20 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-09-30 21:31 2.6.0-test5 - stuck keys on iBook cliff white
2003-09-30 23:09 ` Tom Rini
2003-10-01 13:48 ` Brice Figureau
2003-10-03 7:40 ` [PATCH] macintosh/adbhid.c REP_DELAY fix (was Re: 2.6.0-test5 - stuck keys on iBook) Brice Figureau
2003-10-03 15:19 ` Benjamin Herrenschmidt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).