From: Geoffrey Lee <glee@gnupilgrims.org>
To: Dave Jones <davej@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [patch] reproducible athlon mce fix
Date: Mon, 3 Nov 2003 17:20:48 +0800 [thread overview]
Message-ID: <20031103092048.GB14080@anakin.wychk.org> (raw)
In-Reply-To: <20031102125202.GA7992@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 702 bytes --]
On Sun, Nov 02, 2003 at 12:52:03PM +0000, Dave Jones wrote:
> On Sun, Nov 02, 2003 at 01:57:48PM +0800, Geoffrey Lee wrote:
>
> > preempt_disable();
> > +#if CONFIG_MK7
> > + for (i=1; i<nr_mce_banks; i++) {
> > +#else
> > for (i=0; i<nr_mce_banks; i++) {
> > +#endif
> > rdmsr (MSR_IA32_MC0_STATUS+i*4, low, high);
>
> This needs to be a runtime check. In 2.6, a K7 can boot
> a P4 kernel, and vice versa.
>
(Resending as it seems to have eaten my mail due to dns problems ... apologies
if you get this twice.)
Would checking boot_cpu_data.x86_vendor == X86_VENDOR_AMD and
boot_cpu_data.x86 == 6 be sufficient? It seems to do the right thing ..
Updated patch attached.
- g.
[-- Attachment #2: mce-fix.patch --]
[-- Type: text/plain, Size: 1061 bytes --]
--- linux-2.6.0-test9/arch/i386/kernel/cpu/mcheck/non-fatal.c.orig 2003-11-02 13:31:43.000000000 +0800
+++ linux-2.6.0-test9/arch/i386/kernel/cpu/mcheck/non-fatal.c 2003-11-02 21:50:36.000000000 +0800
@@ -21,6 +21,7 @@
static struct timer_list mce_timer;
static int timerset;
+static int startbank;
#define MCE_RATE 15*HZ /* timer rate is 15s */
@@ -30,7 +31,7 @@
int i;
preempt_disable();
- for (i=0; i<nr_mce_banks; i++) {
+ for (i=startbank; i<nr_mce_banks; i++) {
rdmsr (MSR_IA32_MC0_STATUS+i*4, low, high);
if (high & (1<<31)) {
@@ -68,6 +69,19 @@
static int __init init_nonfatal_mce_checker(void)
{
+ /*
+ Certain Athlons would cause spurious MCE non-fatal
+ exception check to be reported, if we poke at bank 0.
+ Avoid this if the running machine is an Athlon.
+
+ -- geoff.
+ */
+ if (boot_cpu_data.x86_vendor == X86_VENDOR_AMD &&
+ boot_cpu_data.x86 == 6)
+ startbank = 1;
+ else
+ startbank = 0;
+
if (timerset == 0) {
/* Set the timer to check for non-fatal
errors every MCE_RATE seconds */
next prev parent reply other threads:[~2003-11-09 6:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-02 5:57 [patch] reproducible athlon mce fix Geoffrey Lee
2003-11-02 7:25 ` Willy Tarreau
2003-11-02 7:28 ` Geoffrey Lee
2003-11-02 8:59 ` Zwane Mwaikambo
2003-11-10 23:55 ` bill davidsen
2003-11-02 12:52 ` Dave Jones
2003-11-02 13:52 ` Geoffrey Lee
2003-11-03 9:20 ` Geoffrey Lee [this message]
2003-11-03 13:24 ` Dave Jones
2003-11-02 18:25 ` Kronos
2003-11-02 23:44 ` Geoffrey Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031103092048.GB14080@anakin.wychk.org \
--to=glee@gnupilgrims.org \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).