2.6.0-test9: Kernel OOPS in /sbin/nameif

2.6.0-test9: Kernel OOPS in /sbin/nameif

[Valdis.Kletnieks]

[-- Attachment #1: Type: text/plain, Size: 1784 bytes --]

(am on lkml but not linux-net - linux-net replies please cc: me)

This broke sometime between 2.6.0-test8-mm1 (which works) and -test9.

Userspace is Red Hat Rawhide/Fedora Core, kernel compiled with RH gcc-3.3.2-1

Basic summary - when /sbin/nameif goes to rename an interface, things
go totally pear-shaped.  nameif itself croaks, and apparently leaves
data structures corrupted - on a subsequent 'ifup lo' or 'shutdown -r'
the system locks up solid.

Unable to handle kernel NULL pointer dereference at virtual address 000000d8
 printing eip:
c033eb32
*pde = 0f670067
*pte = 00000000
Oops: 0000 [#1]
CPU:    0
EIP:    0060:[<c033eb32>]    Not tainted
EFLAGS: 00010246
EIP is at addrconf_sysctl_unregister+0x7/0x3a
eax: 0000009c   ebx: 0000009c   ecx: 00000000   edx: 00000000
esi: 00000000   edi: cfd4a800   ebp: cedabea8   esp: cedabea4
ds: 007b   es: 007b   ss: 0068
Process nameif (pid: 280, threadinfo=cedaa000 task=ceaeecc0)
Stack: 0000009c cedabec0 c033cdda 0000009c c042e318 cfd4a800 0000000a cedabee0 
       c012673d c042e318 0000000a cfd4a800 cfd4a800 00000000 cedabf34 cedabf10 
       c02ec593 c04c5848 0000000a cfd4a800 cfd4a800 cedabf34 00000010 cedabf24 
Call Trace:
 [<c033cdda>] addrconf_notify+0xc4/0xfb
 [<c012673d>] notifier_call_chain+0x1c/0x37
 [<c02ec593>] dev_ifsioc+0x2f3/0x391
 [<c02ec867>] dev_ioctl+0x236/0x33b
 [<c0322188>] inet_ioctl+0xbf/0xcd
 [<c02e4ee7>] sock_ioctl+0x27d/0x2a3
 [<c0156922>] sys_ioctl+0x200/0x246
 [<c010a96b>] syscall_call+0x7/0xb

Code: 8b 58 3c 85 db 74 27 c7 40 3c 00 00 00 00 ff 33 e8 dc 13 de 

Reproducible on both -test9 and -test9-mm1.  Sorry I didn't catch it sooner,
I hadn't booted the laptop in the docking station under -test9 till
yesterday, so the call to nameif didn't actually have to rename
anything until then.

[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]

Re: 2.6.0-test9: Kernel OOPS in /sbin/nameif

[YOSHIFUJI Hideaki / 吉藤英明]

In article <200311051703.hA5H38nQ007123@turing-police.cc.vt.edu> (at Wed, 05 Nov 2003 12:03:08 -0500), Valdis.Kletnieks@vt.edu says:

> Basic summary - when /sbin/nameif goes to rename an interface, things
> go totally pear-shaped.  nameif itself croaks, and apparently leaves
> data structures corrupted - on a subsequent 'ifup lo' or 'shutdown -r'
> the system locks up solid.
> 
> Unable to handle kernel NULL pointer dereference at virtual address 000000d8
>  printing eip:
> c033eb32
:
> EIP is at addrconf_sysctl_unregister+0x7/0x3a
:
> Call Trace:
>  [<c033cdda>] addrconf_notify+0xc4/0xfb
>  [<c012673d>] notifier_call_chain+0x1c/0x37
:

Please try this.

===== net/ipv6/addrconf.c 1.74 vs edited =====
--- 1.74/net/ipv6/addrconf.c	Tue Oct 28 20:10:47 2003
+++ edited/net/ipv6/addrconf.c	Thu Nov  6 02:30:03 2003
@@ -1877,10 +1877,12 @@
 		break;
 	case NETDEV_CHANGENAME:
 #ifdef CONFIG_SYSCTL
-		addrconf_sysctl_unregister(&idev->cnf);
-		neigh_sysctl_unregister(idev->nd_parms);
-		neigh_sysctl_register(dev, idev->nd_parms, NET_IPV6, NET_IPV6_NEIGH, "ipv6");
-		addrconf_sysctl_register(idev, &idev->cnf);
+		if (idev) {
+			addrconf_sysctl_unregister(&idev->cnf);
+			neigh_sysctl_unregister(idev->nd_parms);
+			neigh_sysctl_register(dev, idev->nd_parms, NET_IPV6, NET_IPV6_NEIGH, "ipv6");
+			addrconf_sysctl_register(idev, &idev->cnf);
+		}
 #endif
 		break;
 	};

-- 
Hideaki YOSHIFUJI @ USAGI Project <yoshfuji@linux-ipv6.org>
GPG FP: 9022 65EB 1ECF 3AD1 0BDF  80D8 4807 F894 E062 0EEA

Re: 2.6.0-test9: Kernel OOPS in /sbin/nameif

[Valdis.Kletnieks]

[-- Attachment #1: Type: text/plain, Size: 429 bytes --]

On Thu, 06 Nov 2003 02:32:37 +0900, YOSHIFUJI Hideaki / =?iso-2022-jp?B?GyRCNUhGIzFRTEAbKEI=?= said:

> Please try this.
> 
> ===== net/ipv6/addrconf.c 1.74 vs edited =====
> --- 1.74/net/ipv6/addrconf.c	Tue Oct 28 20:10:47 2003
> +++ edited/net/ipv6/addrconf.c	Thu Nov  6 02:30:03 2003

Wow. 2 hours from report to patch to test to confirmed fix. :)

System boots cleanly on test9+patch, /sbin/nameif works right again. Thanks.

[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]

Re: 2.6.0-test9: Kernel OOPS in /sbin/nameif

[David S. Miller]

On Thu, 06 Nov 2003 02:32:37 +0900 (JST)
YOSHIFUJI Hideaki / _$B5HF#1QL@ <yoshfuji@linux-ipv6.org> wrote:

> Please try this.
> 
> ===== net/ipv6/addrconf.c 1.74 vs edited =====
> --- 1.74/net/ipv6/addrconf.c	Tue Oct 28 20:10:47 2003
> +++ edited/net/ipv6/addrconf.c	Thu Nov  6 02:30:03 2003

Applied, thank you Yoshfuji.