From: Jens Axboe <axboe@suse.de>
To: Nicolas Mailhot <Nicolas.Mailhot@laPoste.net>
Cc: Alan Stern <stern@rowland.harvard.edu>,
USB development list <linux-usb-devel@lists.sourceforge.net>,
linux-kernel@vger.kernel.org
Subject: Re: [Bug 1412] Copy from USB1 CF/SM reader stalls, no actual content is read (only directory structure)
Date: Fri, 7 Nov 2003 10:09:24 +0100 [thread overview]
Message-ID: <20031107090924.GB616@suse.de> (raw)
In-Reply-To: <1068195038.21576.1.camel@ulysse.olympe.o2t>
On Fri, Nov 07 2003, Nicolas Mailhot wrote:
> Le ven 07/11/2003 à 09:24, Jens Axboe a écrit :
> > On Wed, Nov 05 2003, Alan Stern wrote:
>
> > > In any case, it quite likely _does_ point to a driver bug. But since
> > > sddr09_read_data() was handed this sg entry and didn't change it, if there
> > > is such a bug it must lie in a higher-level driver. Maybe the scsi layer,
> > > maybe the block layer, maybe the memory-management system, maybe the file
> > > system. That was my original point.
> >
> > Well, the sg entry looks perfectly valid. And that was my original
> > point :-). And that is why I said it looks like a driver bug, not in
> > upper layers. How much memory did the system that crashed have? If the
> > system has highmem, try testing with scsi_calculate_bounce_limit()
> > unconditionally returning BLK_BOUNCE_HIGH.
>
> The system has 1 GiB of memory, ie just enough to make stuff like
> radeonfb fail
Try with this debug patch then, does it work now?
===== drivers/scsi/scsi_lib.c 1.77 vs edited =====
--- 1.77/drivers/scsi/scsi_lib.c Tue Oct 14 09:28:06 2003
+++ edited/drivers/scsi/scsi_lib.c Fri Nov 7 10:08:52 2003
@@ -1215,6 +1215,7 @@
u64 scsi_calculate_bounce_limit(struct Scsi_Host *shost)
{
+#if 0
struct device *host_dev;
if (shost->unchecked_isa_dma)
@@ -1229,6 +1230,9 @@
* hardware have no practical limit.
*/
return BLK_BOUNCE_ANY;
+#else
+ return BLK_BOUNCE_HIGH;
+#endif
}
struct request_queue *scsi_alloc_queue(struct scsi_device *sdev)
--
Jens Axboe
next prev parent reply other threads:[~2003-11-07 23:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1067633171.3886.1.camel@m70.net81-64-235.noos.fr>
2003-11-01 15:47 ` [Bug 1412] Copy from USB1 CF/SM reader stalls, no actual content is read (only directory structure) Alan Stern
2003-11-04 7:49 ` Jens Axboe
2003-11-04 17:33 ` Alan Stern
2003-11-05 8:40 ` Jens Axboe
2003-11-05 15:47 ` Alan Stern
2003-11-07 8:24 ` Jens Axboe
2003-11-07 8:50 ` Nicolas Mailhot
2003-11-07 9:09 ` Jens Axboe [this message]
2003-11-07 9:25 ` Nicolas Mailhot
2003-11-07 21:02 ` Nicolas Mailhot
2003-11-07 21:03 ` Nicolas Mailhot
2003-11-07 21:22 ` Jens Axboe
2003-11-07 15:48 ` Alan Stern
2003-11-07 21:22 ` Jens Axboe
2003-11-07 18:56 ` [linux-usb-devel] " David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031107090924.GB616@suse.de \
--to=axboe@suse.de \
--cc=Nicolas.Mailhot@laPoste.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).