Badness in atomic_dec_and_test in 2.6.0-test9-mm2

Badness in atomic_dec_and_test in 2.6.0-test9-mm2

[Bradley Chapman]

(I sent a previous version of this e-mail to the linux-scsi and usb-storage
mailinglists mentioned in MAINTAINERS, but received no response)

When I unplug my USB Mass Storage device after unmounting it, I get the following
badness message:

usb 1-1.2: USB disconnect, address 4
Badness in atomic_dec_and_test at include/asm/atomic.h:150
Call Trace:
 [<c02184f0>] kobject_put+0x7e/0x80
 [<e4cc7adb>] scsi_remove_host+0x104/0x1a0 [scsi_mod]
 [<e4cbbe5f>] dissociate_dev+0x55/0xd2 [usb_storage]
 [<e4cbc269>] storage_disconnect+0x38/0x48 [usb_storage]
 [<c02c311d>] usb_unbind_interface+0xa4/0xa6
 [<c02845ee>] device_release_driver+0x64/0x66
 [<c028474e>] bus_remove_device+0x73/0xb8
 [<c02836dd>] device_del+0x6c/0xa0
 [<c02cba42>] usb_disable_device+0x71/0xac
 [<c02c3ee7>] usb_disconnect+0xc3/0x10e
 [<c02c6ee9>] hub_port_connect_change+0x339/0x33e
 [<c02c67e9>] hub_port_status+0x3c/0xa7
 [<c02c72d5>] hub_events+0x3e7/0x565
 [<c02c7480>] hub_thread+0x2d/0xe3
 [<c03b8c0e>] ret_from_fork+0x6/0x14
 [<c0120d8c>] default_wake_function+0x0/0x2e
 [<c02c7453>] hub_thread+0x0/0xe3
 [<c01092a9>] kernel_thread_helper+0x5/0xb

The device is a 256MB flash disk with an OTi controller chip. When I insert it
it is detected like this, and works perfectly fine:

hub 1-1:1.0: new USB device on port 2, assigned address 4
SCSI subsystem initialized
Initializing USB Mass Storage driver...
scsi0 : SCSI emulation for USB Mass Storage devices
  Vendor: STF       Model: Flash Drive       Rev: 1.89
  Type:   Direct-Access                      ANSI SCSI revision: 02
WARNING: USB Mass Storage data integrity not assured
USB Mass Storage device found at 4
drivers/usb/core/usb.c: registered new driver usb-storage
USB Mass Storage support registered.
sda: Unit Not Ready, sense:
Current : sense = 70  6
ASC=28 ASCQ= 0
Raw sense data:0x70 0x00 0x06 0x00 0x00 0x00 0x00 0x0a 0x00 0x00 0x00 0x00 0x28 0x00
0x00 0x00 0x00 0x00
SCSI device sda: 512000 512-byte hdwr sectors (262 MB)
sda: Write Protect is off
sda: Mode Sense: 00 06 94 00
sda: assuming drive cache: write through
 sda: sda1
Attached scsi removable disk sda at scsi0, channel 0, id 0, lun 0

I have the SCSI core, the SCSI disk core and USB storage compiled as modules.
The badness message is 100% repeatable; it occurs every time this particular
device is unplugged.

TIA

Brad

__________________________________
Do you Yahoo!?
Protect your identity with Yahoo! Mail AddressGuard
http://antispam.yahoo.com/whatsnewfree

Re: Badness in atomic_dec_and_test in 2.6.0-test9-mm2

[Mike Anderson]

Bradley Chapman [kakadu_croc@yahoo.com] wrote:
> (I sent a previous version of this e-mail to the linux-scsi and usb-storage
> mailinglists mentioned in MAINTAINERS, but received no response)
> 
> When I unplug my USB Mass Storage device after unmounting it, I get the following
> badness message:

Greg posted a response the other day to a query from Alan Stern. Here is
the link 
http://marc.theaimsgroup.com/?l=linux-kernel&m=106835250124362&w=2

This should be the same problem that you are hitting.

A patch was checked into Linus's tree on 2003-11-07 by Greg that made a
couple line change to class.c.

Here is the patch in case you need to stay on mm2.

-andmike
--
Michael Anderson
andmike@us.ibm.com

--- 1.41/drivers/base/class.c	Fri Aug 29 14:18:26 2003
+++ 1.42/drivers/base/class.c	Fri Nov  7 06:48:28 2003
@@ -255,6 +255,7 @@
 
 void class_device_initialize(struct class_device *class_dev)
 {
+	kobj_set_kset_s(class_dev, class_obj_subsys);
 	kobject_init(&class_dev->kobj);
 	INIT_LIST_HEAD(&class_dev->node);
 }
@@ -277,7 +278,6 @@
 
 	/* first, register with generic layer. */
 	kobject_set_name(&class_dev->kobj, class_dev->class_id);
-	kobj_set_kset_s(class_dev, class_obj_subsys);
 	if (parent)
 		class_dev->kobj.parent = &parent->subsys.kset.kobj;
 

Badness in atomic_dec_and_test in 2.6.0-test9-mm2

[Bradley Chapman]

After unplugging and replugging my Logitech MX700 mouse and then shutting
down my Linksys WPC11, I get the following badness message:

input: USB HID v1.10 Mouse [Logitech USB Receiver] on usb-0000:00:1d.0-1.4
orinoco_lock() called with hw_unavailable (dev=df2e8184)
Badness in atomic_dec_and_test at include/asm/atomic.h:150
Call Trace:
 [<c02184f0>] kobject_put+0x7e/0x80
 [<e4cac191>] orinoco_cs_detach+0x0/0xa1 [orinoco_cs]
 [<c02bfd0b>] unbind_request+0xd1/0xdb
 [<c02c0433>] ds_ioctl+0x3dd/0x67a
 [<c01203ae>] scheduler_tick+0x64f/0x65b
 [<c0150c8d>] __alloc_pages+0xb9/0x357
 [<c0132bf5>] update_process_times+0x46/0x52
 [<c013f832>] rcu_check_quiescent_state+0x179/0x1cf
 [<c0132a6f>] update_wall_time+0xd/0x36
 [<c0133155>] do_timer+0xdf/0xe4
 [<c013fa26>] rcu_process_callbacks+0x19e/0x24d
 [<c0114385>] timer_interrupt+0x2cc/0x3bc
 [<c012d64a>] tasklet_action+0x40/0x61
 [<c010e11e>] do_IRQ+0x24c/0x39b
 [<c026102e>] do_con_write+0x31a/0x72f
 [<c015fe6a>] zap_pte_range+0x141/0x187
 [<c015fef8>] zap_pmd_range+0x48/0x64
 [<c015ff57>] unmap_page_range+0x43/0x69
 [<c016005c>] unmap_vmas+0xdf/0x358
 [<c012bc52>] wait_task_zombie+0x164/0x20e
 [<c016591f>] unmap_vma_list+0x1c/0x28
 [<c016591f>] unmap_vma_list+0x1c/0x28
 [<c0165f1f>] do_munmap+0x1d6/0x290
 [<c0192d72>] sys_ioctl+0x204/0x3ee
 [<c0166031>] sys_munmap+0x58/0x78
 [<c03b8cd6>] sysenter_past_esp+0x43/0x65

I am using the 0.14alpha2 orinoco drivers on top of 2.6.0-test9-mm2. Previous
unloads of this driver did not produce this badness message until after I
replugged my mouse.

TIA

Brad

=====
Brad Chapman

Permanent e-mail: kakadu_croc@yahoo.com

__________________________________
Do you Yahoo!?
Protect your identity with Yahoo! Mail AddressGuard
http://antispam.yahoo.com/whatsnewfree