From: Russell King <rmk+lkml@arm.linux.org.uk>
To: bert hubert <ahu@ds9a.nl>, linux-kernel@vger.kernel.org
Subject: Re: 2.6.0-test11 -- Failed to open /dev/ttyS0: No such device
Date: Sun, 30 Nov 2003 16:00:42 +0000 [thread overview]
Message-ID: <20031130160042.A30125@flint.arm.linux.org.uk> (raw)
In-Reply-To: <microsoft-free.87ekvpc0ms.fsf@eicq.dnsalias.org>; from sryoungs@bigpond.net.au on Mon, Dec 01, 2003 at 01:54:51AM +1000
On Mon, Dec 01, 2003 at 01:54:51AM +1000, Steve Youngs wrote:
> |--==> "JK" == Jacek Kawa <jfk@zeus.polsl.gliwice.pl> writes:
>
> JK> bert hubert wrote:
> >>> Does anyone have modem working in 2.6.0-test11?
> >>> I have external modem connected to /dev/ttyS0 (COM1). Kernel
> >>> 2.6.0-test11 give me
>
> JK> It reminds me, that I had to add serial to the list of modules
> JK> loading at start to get back access to /dev/ttyS*
> JK> (while upgrading from -test9 to -test10).
>
> Jacek,
>
> I _think_ this patch will bring back auto-loading of the serial module
> for you. Please let me know how it goes. (Bert, this won't fix your
> problem if you have the serial driver compiled directly into the
> kernel, but it might if you have it as a module.)
>
> --- linux-2.6.0-test11/drivers/serial/serial_core.c 2003-11-27 12:12:22.000000000 +1000
> +++ linux-2.6.0-test11-sy/drivers/serial/serial_core.c 2003-12-01 01:38:40.000000000 +1000
> @@ -2420,3 +2420,4 @@
>
> MODULE_DESCRIPTION("Serial driver core");
> MODULE_LICENSE("GPL");
> +MODULE_ALIAS_CHARDEV(drv->major, drv->minor);
>
This is wrong. serial_core should /never/ depend on a major/minor number
because it doesn't know what (group of) major/minor(s) it is going to be.
The only modules which know are the hardware drivers themselves, like
8250.c.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/
2.6 Serial core
next prev parent reply other threads:[~2003-11-30 16:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-30 7:17 2.6.0-test11 -- Failed to open /dev/ttyS0: No such device William Park
2003-11-30 10:23 ` bert hubert
2003-11-30 11:36 ` Jacek Kawa
2003-11-30 15:54 ` Steve Youngs
2003-11-30 16:00 ` Russell King [this message]
2003-11-30 22:22 ` Jacek Kawa
2003-12-01 2:17 ` Steve Youngs
2003-12-01 7:28 ` Jacek Kawa
2003-11-30 19:05 ` William Park
2003-11-30 18:40 ` William Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031130160042.A30125@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=ahu@ds9a.nl \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).