From: Srivatsa Vaddagiri <vatsa@in.ibm.com>
To: Raj <raju@mailandnews.com>
Cc: linux-kernel@vger.kernel.org, lhcs-devel@lists.sourceforge.net,
manfred@colorfullife.com
Subject: Re: kernel BUG at kernel/exit.c:792!
Date: Wed, 3 Dec 2003 18:23:20 +0530 [thread overview]
Message-ID: <20031203182319.D14999@in.ibm.com> (raw)
In-Reply-To: <3FCDCEA3.1020209@mailandnews.com>; from raju@mailandnews.com on Wed, Dec 03, 2003 at 05:23:07PM +0530
On Wed, Dec 03, 2003 at 05:23:07PM +0530, Raj wrote:
>
> >Does it make sense to check for leader_task being alive
> >after the tasklist lock is grabbed and return immediately
> >if it is not alive (as the patch below does)?
> >
> >
> >
> maybe i am wrong, but wouldnt a 'break' in the do-while suffice rather
> than a goto ?
>
I was not sure if the pid_alive check inside the do-while loop
is for leader_task only or for non-leader tasks also.
If that check is for non-leader tasks also, then we would
like to retain it still ..
> /Raj
> --- base.c 2003-10-26 00:13:57.000000000 +0530
> +++ base.c.fix 2003-12-03 17:20:18.877679360 +0530
> @@ -1669,7 +1669,7 @@
> do {
> int tid = task->pid;
> if (!pid_alive(task))
> - continue;
> + break;
> if (--index >= 0)
> continue;
> tids[nr_tids] = tid;
--
Thanks and Regards,
Srivatsa Vaddagiri,
Linux Technology Center,
IBM Software Labs,
Bangalore, INDIA - 560033
next prev parent reply other threads:[~2003-12-03 12:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-03 10:08 kernel BUG at kernel/exit.c:792! Srivatsa Vaddagiri
[not found] ` <3FCDCEA3.1020209@mailandnews.com>
2003-12-03 12:53 ` Srivatsa Vaddagiri [this message]
2003-12-03 17:46 ` Manfred Spraul
2003-12-03 17:52 ` Manfred Spraul
2003-12-03 18:19 ` Linus Torvalds
2003-12-03 19:58 ` Ingo Molnar
2003-12-03 19:59 ` Ingo Molnar
2003-12-03 20:08 ` Linus Torvalds
2003-12-03 20:18 ` Ingo Molnar
2003-12-03 20:19 ` Manfred Spraul
2003-12-03 20:26 ` Ingo Molnar
2003-12-03 20:31 ` Ingo Molnar
2003-12-03 20:55 ` Linus Torvalds
2003-12-03 20:35 ` Ingo Molnar
2003-12-03 15:51 ` Linus Torvalds
2003-12-03 20:03 ` Ingo Molnar
2003-12-03 20:09 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031203182319.D14999@in.ibm.com \
--to=vatsa@in.ibm.com \
--cc=lhcs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred@colorfullife.com \
--cc=raju@mailandnews.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).