linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Manfred Spraul <manfred@colorfullife.com>
To: vatsa@in.ibm.com
Cc: Raj <raju@mailandnews.com>,
	linux-kernel@vger.kernel.org, lhcs-devel@lists.sourceforge.net
Subject: Re: kernel BUG at kernel/exit.c:792!
Date: Wed, 03 Dec 2003 18:46:38 +0100	[thread overview]
Message-ID: <3FCE217E.1080007@colorfullife.com> (raw)
In-Reply-To: <20031203182319.D14999@in.ibm.com>

Srivatsa Vaddagiri wrote:

> --- base.c 2003-10-26 00:13:57.000000000 +0530
>
>>+++ base.c.fix	2003-12-03 17:20:18.877679360 +0530
>>@@ -1669,7 +1669,7 @@
>> 	do {
>> 		int tid = task->pid;
>> 		if (!pid_alive(task))
>>-			continue;
>>+			break;
>>
No, a break would be wrong: The test detects already dead tasks that are 
still listed in the task list. If such a task is found, then it 
shouldn't be listed in /proc/, but the readdir call should continue to 
scan the task list.

But I don't understand the oops:
__exit_sighand clears current->sighand, and then in the next line 
__unhash_process removes the thread from the task list. But that's under 
write_lock_irq(&tasklist_lock), and get_tid_list runs under 
read_lock(&tasklist_lock). It should be impossible that ->sighand is 
NULL and the task is still listed in the task list.

--
    Manfred


  reply	other threads:[~2003-12-03 17:47 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-12-03 10:08 kernel BUG at kernel/exit.c:792! Srivatsa Vaddagiri
     [not found] ` <3FCDCEA3.1020209@mailandnews.com>
2003-12-03 12:53   ` Srivatsa Vaddagiri
2003-12-03 17:46     ` Manfred Spraul [this message]
2003-12-03 17:52       ` Manfred Spraul
2003-12-03 18:19       ` Linus Torvalds
2003-12-03 19:58         ` Ingo Molnar
2003-12-03 19:59     ` Ingo Molnar
2003-12-03 20:08       ` Linus Torvalds
2003-12-03 20:18         ` Ingo Molnar
2003-12-03 20:19         ` Manfred Spraul
2003-12-03 20:26           ` Ingo Molnar
2003-12-03 20:31             ` Ingo Molnar
2003-12-03 20:55             ` Linus Torvalds
2003-12-03 20:35         ` Ingo Molnar
2003-12-03 15:51 ` Linus Torvalds
2003-12-03 20:03   ` Ingo Molnar
2003-12-03 20:09     ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3FCE217E.1080007@colorfullife.com \
    --to=manfred@colorfullife.com \
    --cc=lhcs-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=raju@mailandnews.com \
    --cc=vatsa@in.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).