linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] fix for fbcon margin colour in 2.6.0-test*
@ 2003-12-06  1:34 Jakub Bogusz
  0 siblings, 0 replies; only message in thread
From: Jakub Bogusz @ 2003-12-06  1:34 UTC (permalink / raw)
  To: linux-kernel; +Cc: linux-fbdev-devel

[-- Attachment #1: Type: text/plain, Size: 413 bytes --]

Hello,

I posted this patch to fbdev-devel some time ago, but haven't got any
opinions there.
It sets fbcon margin colour to sane, black value, instead of changing
from time to time depending on background of last erase character
(more details inside).
It was tested by me on tdfxfb and one other person on matroxfb.


-- 
Jakub Bogusz    http://cyber.cs.net.pl/~qboosh/
PLD Linux       http://www.pld-linux.org/

[-- Attachment #2: linux-fbcon-margins.patch --]
[-- Type: text/plain, Size: 840 bytes --]

This fixes "margin colour" (colour used to clear margins - e.g. a half of line
at the bottom of 100x37 console on 800x600 framebuffer).

I don't know what was the intention behind using attr_bgcol_ec() here, but it
caused using of background colour of last erase character to clear margins -
which definitely isn't what we want...
This patch changes margin colour to black (or colour 0 in palette modes).

	-- Jakub Bogusz <qboosh@pld-linux.org>

--- linux-2.6.0-test2/drivers/video/console/fbcon.c.orig	2003-07-14 05:36:32.000000000 +0200
+++ linux-2.6.0-test2/drivers/video/console/fbcon.c	2003-07-31 00:53:26.000000000 +0200
@@ -502,7 +502,7 @@
 	unsigned int bs = info->var.yres - bh;
 	struct fb_fillrect region;
 
-	region.color = attr_bgcol_ec(bgshift, vc);
+	region.color = 0;
 	region.rop = ROP_COPY;
 
 	if (rw && !bottom_only) {

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2003-12-06  1:29 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-12-06  1:34 [PATCH] fix for fbcon margin colour in 2.6.0-test* Jakub Bogusz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).