From: Nathan Scott <nathans@sgi.com>
To: Joe Thornber <thornber@sistina.com>
Cc: Linux Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [Patch 1/4] fs.h: b_journal_head
Date: Wed, 10 Dec 2003 10:46:55 +1100 [thread overview]
Message-ID: <20031209234655.GF783@frodo> (raw)
In-Reply-To: <20031209122418.GC472@reti>
Hi Joe,
On Tue, Dec 09, 2003 at 12:24:18PM +0000, Joe Thornber wrote:
> Add a new member to struct buffer_head called b_journal_head. This is
> for jbd to use, rather than have it peeking at b_private for in flight
> ios.
> ...
> --- diff/include/linux/fs.h 2003-12-09 10:25:27.000000000 +0000
> +++ source/include/linux/fs.h 2003-12-09 10:32:41.000000000 +0000
> @@ -265,7 +265,7 @@
> struct page *b_page; /* the page this bh is mapped to */
> void (*b_end_io)(struct buffer_head *bh, int uptodate); /* I/O completion */
> void *b_private; /* reserved for b_end_io */
> -
> + void *b_journal_head; /* ext3 journal_heads */
> unsigned long b_rsector; /* Real buffer location on disk */
> wait_queue_head_t b_wait;
>
Could you explain a bit more about when b_private should and
shouldn't be used with this change? We make use of b_private
within XFS, I'm just wondering if we will be stepping on each
others toes here? And if XFS does need to use b_journal_head
instead of b_private with DM, maybe a more generic name like
"b_fsprivate" or something would be clearer?
thanks.
--
Nathan
next prev parent reply other threads:[~2003-12-09 23:47 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-09 11:58 Device-mapper submission for 2.4 Joe Thornber
2003-12-09 12:24 ` [Patch 1/4] fs.h: b_journal_head Joe Thornber
2003-12-09 23:46 ` Nathan Scott [this message]
2003-12-10 8:46 ` Joe Thornber
2003-12-10 12:06 ` Nathan Scott
2003-12-09 12:25 ` [Patch 2/4] dm: mempool backport Joe Thornber
2003-12-09 12:26 ` [Patch 3/4] dm: core files Joe Thornber
2003-12-09 12:26 ` [Patch 4/4] dm: ioctl interface Joe Thornber
2003-12-09 13:15 ` Device-mapper submission for 2.4 Marcelo Tosatti
2003-12-09 13:45 ` Joe Thornber
2003-12-09 14:00 ` Måns Rullgård
2003-12-09 14:10 ` Muli Ben-Yehuda
2003-12-09 14:21 ` Måns Rullgård
2003-12-09 14:16 ` Joe Thornber
2003-12-09 14:24 ` Stefan Smietanowski
2003-12-09 14:10 ` Marcelo Tosatti
2003-12-09 14:34 ` Joe Thornber
2003-12-09 21:07 ` Paul Jakma
2003-12-09 22:26 ` Joe Thornber
2003-12-09 22:48 ` Marcelo Tosatti
2003-12-09 23:46 ` Paul Jakma
2003-12-09 23:58 ` William Lee Irwin III
2003-12-10 0:15 ` Paul Jakma
2003-12-10 11:49 ` Stephan von Krawczynski
2003-12-10 23:15 ` Dave Jones
2003-12-10 0:27 ` Jose Luis Domingo Lopez
2003-12-10 0:59 ` Tupshin Harper
2003-12-10 9:40 ` Wichert Akkerman
2003-12-10 2:44 ` Martin J. Bligh
2003-12-10 15:55 ` Paul Jakma
2003-12-10 16:54 ` venom
2003-12-10 17:00 ` Paul Jakma
2003-12-10 17:14 ` venom
2003-12-10 23:40 ` Mike Fedyk
2003-12-11 19:48 ` Alasdair G Kergon
2003-12-16 19:15 ` bill davidsen
2003-12-16 19:01 ` bill davidsen
2003-12-10 8:45 ` Jens Axboe
2003-12-10 17:30 ` Paul Jakma
2003-12-10 17:44 ` Joe Thornber
2003-12-10 17:48 ` venom
2003-12-10 18:07 ` Paul Jakma
2003-12-10 19:30 ` Jens Axboe
2003-12-09 17:02 ` Bill Rugolsky Jr.
2003-12-09 22:53 ` Ciaran McCreesh
2003-12-10 3:38 ` Lincoln Dale
2003-12-10 6:12 ` Willy Tarreau
2003-12-10 6:35 ` viro
2003-12-09 17:45 ` Kevin Corry
2003-12-09 19:47 ` Paul P Komkoff Jr
2003-12-09 14:23 ` Stefan Smietanowski
2003-12-09 14:36 ` Joe Thornber
2003-12-09 19:50 ` William Lee Irwin III
2003-12-09 21:13 ` Paul Jakma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031209234655.GF783@frodo \
--to=nathans@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=thornber@sistina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).