* do not leak memory in powernow-k8
@ 2004-01-03 12:42 Pavel Machek
0 siblings, 0 replies; only message in thread
From: Pavel Machek @ 2004-01-03 12:42 UTC (permalink / raw)
To: Andrew Morton, kernel list, Rusty trivial patch monkey Russell, cpufreq
Hi!
This prevents memory leak if something goes wrong. Please apply,
Pavel
Index: linux.new/arch/i386/kernel/cpu/cpufreq/powernow-k8.c
===================================================================
--- linux.new.orig/arch/i386/kernel/cpu/cpufreq/powernow-k8.c 2003-12-25 13:28:48.000000000 +0100
+++ linux.new/arch/i386/kernel/cpu/cpufreq/powernow-k8.c 2003-12-25 13:29:08.000000000 +0100
@@ -687,11 +687,13 @@
if (ppst[j].vid < rvo) { /* vid+rvo >= 0 */
printk(KERN_ERR BFX
"0 vid exceeded with pstate %d\n", j);
+ kfree(ppst);
return -ENODEV;
}
if (ppst[j].vid < maxvid+rvo) { /* vid+rvo >= maxvid */
printk(KERN_ERR BFX
"maxvid exceeded with pstate %d\n", j);
+ kfree(ppst);
return -ENODEV;
}
}
@@ -706,7 +708,7 @@
for (j = 0; j < numps; j++)
if ((ppst[j].fid==currfid) && (ppst[j].vid==currvid))
- return (0);
+ return 0;
printk(KERN_ERR BFX "currfid/vid do not match PST, ignoring\n");
return 0;
--
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2004-01-03 12:41 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-01-03 12:42 do not leak memory in powernow-k8 Pavel Machek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).