* [2.4 patch] fix CONFIG_QFMT_V2 description
@ 2004-01-07 15:59 Adrian Bunk
2004-01-07 16:11 ` Christoph Hellwig
0 siblings, 1 reply; 4+ messages in thread
From: Adrian Bunk @ 2004-01-07 15:59 UTC (permalink / raw)
To: Christoph Hellwig, Marcelo Tosatti; +Cc: linux-kernel
In 2,4, the CONFIG_QFMT_V2 short description talks about a
"VFS v0 quota format". Is this really correct, or is the patch below
that uses the "Quota format v2 support" text from 2.6 instead correct?
cu
Adrian
--- linux-2.4.25-pre4-full/fs/Config.in.old 2004-01-07 16:46:06.000000000 +0100
+++ linux-2.4.25-pre4-full/fs/Config.in 2004-01-07 16:49:29.000000000 +0100
@@ -5,7 +5,7 @@
comment 'File systems'
bool 'Quota support' CONFIG_QUOTA
-dep_tristate ' VFS v0 quota format support' CONFIG_QFMT_V2 $CONFIG_QUOTA
+dep_tristate ' Quota format v2 support' CONFIG_QFMT_V2 $CONFIG_QUOTA
tristate 'Kernel automounter support' CONFIG_AUTOFS_FS
tristate 'Kernel automounter version 4 support (also supports v3)' CONFIG_AUTOFS4_FS
--- linux-2.4.25-pre4-full/Documentation/Configure.help.old 2004-01-07 16:50:05.000000000 +0100
+++ linux-2.4.25-pre4-full/Documentation/Configure.help 2004-01-07 16:50:37.000000000 +0100
@@ -13628,7 +13628,7 @@
<http://www.tldp.org/docs.html#howto>. Probably the quota
support is only useful for multi user systems. If unsure, say N.
-VFS v0 quota format support
+Quota format v2 support
CONFIG_QFMT_V2
This quota format allows using quotas with 32-bit UIDs/GIDs. If you
need this functionality say Y here. Note that you will need latest
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [2.4 patch] fix CONFIG_QFMT_V2 description
2004-01-07 15:59 [2.4 patch] fix CONFIG_QFMT_V2 description Adrian Bunk
@ 2004-01-07 16:11 ` Christoph Hellwig
2004-01-09 2:27 ` Adrian Bunk
0 siblings, 1 reply; 4+ messages in thread
From: Christoph Hellwig @ 2004-01-07 16:11 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Marcelo Tosatti, linux-kernel
On Wed, Jan 07, 2004 at 04:59:40PM +0100, Adrian Bunk wrote:
> In 2,4, the CONFIG_QFMT_V2 short description talks about a
> "VFS v0 quota format". Is this really correct, or is the patch below
> that uses the "Quota format v2 support" text from 2.6 instead correct?
I think you should ask Jan Kara instead what he prefers. This VFS v0
stuff is his invention. Personally I'm a little confused about the proper
naming, too.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [2.4 patch] fix CONFIG_QFMT_V2 description
2004-01-07 16:11 ` Christoph Hellwig
@ 2004-01-09 2:27 ` Adrian Bunk
2004-01-09 13:27 ` Jan Kara
0 siblings, 1 reply; 4+ messages in thread
From: Adrian Bunk @ 2004-01-09 2:27 UTC (permalink / raw)
To: Christoph Hellwig, Marcelo Tosatti, linux-kernel, Jan Kara
On Wed, Jan 07, 2004 at 04:11:10PM +0000, Christoph Hellwig wrote:
> On Wed, Jan 07, 2004 at 04:59:40PM +0100, Adrian Bunk wrote:
> > In 2,4, the CONFIG_QFMT_V2 short description talks about a
> > "VFS v0 quota format". Is this really correct, or is the patch below
> > that uses the "Quota format v2 support" text from 2.6 instead correct?
>
> I think you should ask Jan Kara instead what he prefers. This VFS v0
> stuff is his invention. Personally I'm a little confused about the proper
> naming, too.
Jan, could you check whether the patch below is correct?
TIA
Adrian
--- linux-2.4.25-pre4-full/fs/Config.in.old 2004-01-07 16:46:06.000000000 +0100
+++ linux-2.4.25-pre4-full/fs/Config.in 2004-01-07 16:49:29.000000000 +0100
@@ -5,7 +5,7 @@
comment 'File systems'
bool 'Quota support' CONFIG_QUOTA
-dep_tristate ' VFS v0 quota format support' CONFIG_QFMT_V2 $CONFIG_QUOTA
+dep_tristate ' Quota format v2 support' CONFIG_QFMT_V2 $CONFIG_QUOTA
tristate 'Kernel automounter support' CONFIG_AUTOFS_FS
tristate 'Kernel automounter version 4 support (also supports v3)' CONFIG_AUTOFS4_FS
--- linux-2.4.25-pre4-full/Documentation/Configure.help.old 2004-01-07 16:50:05.000000000 +0100
+++ linux-2.4.25-pre4-full/Documentation/Configure.help 2004-01-07 16:50:37.000000000 +0100
@@ -13628,7 +13628,7 @@
<http://www.tldp.org/docs.html#howto>. Probably the quota
support is only useful for multi user systems. If unsure, say N.
-VFS v0 quota format support
+Quota format v2 support
CONFIG_QFMT_V2
This quota format allows using quotas with 32-bit UIDs/GIDs. If you
need this functionality say Y here. Note that you will need latest
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [2.4 patch] fix CONFIG_QFMT_V2 description
2004-01-09 2:27 ` Adrian Bunk
@ 2004-01-09 13:27 ` Jan Kara
0 siblings, 0 replies; 4+ messages in thread
From: Jan Kara @ 2004-01-09 13:27 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Christoph Hellwig, Marcelo Tosatti, linux-kernel, Jan Kara
> On Wed, Jan 07, 2004 at 04:11:10PM +0000, Christoph Hellwig wrote:
> > On Wed, Jan 07, 2004 at 04:59:40PM +0100, Adrian Bunk wrote:
> > > In 2,4, the CONFIG_QFMT_V2 short description talks about a
> > > "VFS v0 quota format". Is this really correct, or is the patch below
> > > that uses the "Quota format v2 support" text from 2.6 instead correct?
> >
> > I think you should ask Jan Kara instead what he prefers. This VFS v0
> > stuff is his invention. Personally I'm a little confused about the proper
> > naming, too.
>
> Jan, could you check whether the patch below is correct?
I don't have a strong opinion on this but I like the current state
slightly more. I know there's a mess that VFSv0 = quota_v2. But
currently it's at least in the state that what users (admins) see is
VFSv0 and v2 appears only in the name of kernel config options and in
the identifiers in the code. Changing VFSv0 to "v2" in kernel is no
problem but quota-tools use VFSv0 too and it's also used as an
identifier of a quota format in the options of quota tools (hence
renaming is higly unpleasant for admins). So I'm not sure that renaming
config options in kernel doesn't make things even more messy.
Honza
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2004-01-09 13:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-01-07 15:59 [2.4 patch] fix CONFIG_QFMT_V2 description Adrian Bunk
2004-01-07 16:11 ` Christoph Hellwig
2004-01-09 2:27 ` Adrian Bunk
2004-01-09 13:27 ` Jan Kara
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).