Howto use diff compatibly

Howto use diff compatibly

[Gene Heskett]

Greetings;

Whats the general option syntax used with diff to generate the 
patchfiles I see posted here?

I have a small patch to drivers/block/floppy.c that seems to allow it 
to function with older 256 byte per sector formats that I'd like to 
submit.

-- 
Cheers, Gene
AMD K6-III@500mhz 320M
Athlon1600XP@1400mhz  512M
99.22% setiathome rank, not too shabby for a WV hillbilly
Yahoo.com attornies please note, additions to this message
by Gene Heskett are:
Copyright 2003 by Maurice Eugene Heskett, all rights reserved.

Re: Howto use diff compatibly

[Randy.Dunlap]

On Thu, 8 Jan 2004 14:36:15 -0500 Gene Heskett <gene.heskett@verizon.net> wrote:

| Greetings;
| 
| Whats the general option syntax used with diff to generate the 
| patchfiles I see posted here?
| 
| I have a small patch to drivers/block/floppy.c that seems to allow it 
| to function with older 256 byte per sector formats that I'd like to 
| submit.

Please read Documentation/SubmittingPatches .

--
~Randy
MOTD:  Always include version info.

Re: Howto use diff compatibly

[Måns Rullgård]

Gene Heskett <gene.heskett@verizon.net> writes:

> Greetings;
>
> Whats the general option syntax used with diff to generate the 
> patchfiles I see posted here?

Read Documentation/SubmittingPatches.

-- 
Måns Rullgård
mru@kth.se

Re: Howto use diff compatibly

[Gene Heskett]

On Thursday 08 January 2004 14:36, Gene Heskett wrote:
>Greetings;
>
>Whats the general option syntax used with diff to generate the
>patchfiles I see posted here?
>
>I have a small patch to drivers/block/floppy.c that seems to allow
> it to function with older 256 byte per sector formats that I'd like
> to submit.

I have a better idea.  Who is the current maintainer for 
drivers/block/floppy.c?

-- 
Cheers, Gene
AMD K6-III@500mhz 320M
Athlon1600XP@1400mhz  512M
99.22% setiathome rank, not too shabby for a WV hillbilly
Yahoo.com attornies please note, additions to this message
by Gene Heskett are:
Copyright 2003 by Maurice Eugene Heskett, all rights reserved.

Re: Howto use diff compatibly

[Maciej Zenczykowski]

> I have a better idea.  Who is the current maintainer for 
> drivers/block/floppy.c?

Check MAINTAINERS for floppy

linux 2.4.23:

IDE/ATAPI FLOPPY DRIVERS
P:      Paul Bristow
M:      Paul Bristow <paul@paulbristow.net>
W:      http://paulbristow.net/linux/idefloppy.html
L:      linux-kernel@vger.kernel.org
S:      Maintained

Cheers,
MaZe.

Re: Howto use diff compatibly

[Samuel Flory]

Maciej Zenczykowski wrote:
>>I have a better idea.  Who is the current maintainer for 
>>drivers/block/floppy.c?
> 
> 
> Check MAINTAINERS for floppy
> 
> linux 2.4.23:
> 
> IDE/ATAPI FLOPPY DRIVERS
> P:      Paul Bristow
> M:      Paul Bristow <paul@paulbristow.net>
> W:      http://paulbristow.net/linux/idefloppy.html
> L:      linux-kernel@vger.kernel.org
> S:      Maintained
> 

   That would be the maintainer for drivers/ide/ide-floppy.c.  I don't 
think there is a maintainer for drivers/block/floppy.c.

-- 
Unless you can't avoid it never put a
serial number on any of your systems!!
(The Numberless Rule of Hardware Acquisition)
Sam Flory  <sflory@rackable.com>

Re: Howto use diff compatibly

[Dave Jones]

On Thu, Jan 08, 2004 at 02:51:56PM -0800, Samuel Flory wrote:
 >   That would be the maintainer for drivers/ide/ide-floppy.c.  I don't 
 > think there is a maintainer for drivers/block/floppy.c.

floppy.c is one of those 'last person who touched it' hot-potatoes 8-)

		Dave

Re: Howto use diff compatibly

[Gene Heskett]

On Thursday 08 January 2004 17:02, Maciej Zenczykowski wrote:
>> I have a better idea.  Who is the current maintainer for
>> drivers/block/floppy.c?
>
>Check MAINTAINERS for floppy
>
>linux 2.4.23:
>
>IDE/ATAPI FLOPPY DRIVERS
>P:      Paul Bristow
>M:      Paul Bristow <paul@paulbristow.net>
>W:      http://paulbristow.net/linux/idefloppy.html
>L:      linux-kernel@vger.kernel.org ^^^^^^^^^
>S:      Maintained
>
>Cheers,
>MaZe.

Unforch, this appears to apply only to the ide-floppies, such as the 
ill-treated LS-120/240 stuffs.

I'm refering to the regular, get 'em for a 20 dollar bill at 
circuit-city 3.5 floppys, or the older 5.25" versions, definitely not 
the high-priced spread.

-- 
Cheers, Gene
AMD K6-III@500mhz 320M
Athlon1600XP@1400mhz  512M
99.22% setiathome rank, not too shabby for a WV hillbilly
Yahoo.com attornies please note, additions to this message
by Gene Heskett are:
Copyright 2003 by Maurice Eugene Heskett, all rights reserved.

Re: Howto use diff compatibly

[Gene Heskett]

On Thursday 08 January 2004 18:17, Dave Jones wrote:
>On Thu, Jan 08, 2004 at 02:51:56PM -0800, Samuel Flory wrote:
> >   That would be the maintainer for drivers/ide/ide-floppy.c.  I
> > don't think there is a maintainer for drivers/block/floppy.c.
>
>floppy.c is one of those 'last person who touched it' hot-potatoes
> 8-)
>
>		Dave

Humm, precisely what I was afraid of...  And I don't want to 'adopt' 
that puppy, not knowing near enough about it to be able to address 
every potential problem.

-- 
Cheers, Gene
AMD K6-III@500mhz 320M
Athlon1600XP@1400mhz  512M
99.22% setiathome rank, not too shabby for a WV hillbilly
Yahoo.com attornies please note, additions to this message
by Gene Heskett are:
Copyright 2003 by Maurice Eugene Heskett, all rights reserved.

Re: Howto use diff compatibly

[Jesper Juhl]

On Thu, 8 Jan 2004, Gene Heskett wrote:

> On Thursday 08 January 2004 18:17, Dave Jones wrote:
> >On Thu, Jan 08, 2004 at 02:51:56PM -0800, Samuel Flory wrote:
> > >   That would be the maintainer for drivers/ide/ide-floppy.c.  I
> > > don't think there is a maintainer for drivers/block/floppy.c.
> >
> >floppy.c is one of those 'last person who touched it' hot-potatoes
> > 8-)
> >
> >		Dave
>
> Humm, precisely what I was afraid of...  And I don't want to 'adopt'
> that puppy, not knowing near enough about it to be able to address
> every potential problem.
>

Why don't you post the patch and see what reactions it generates? If
you've got some good code it would be a shame not to see it used.
On the other hand, if it turns out not to be good, then the easiest
way to find that out is for people to get a chance to look at it and
pull it apart...
Discussions of puppy 'adoptions' could come later ;)


-- Jesper Juhl

Re: Howto use diff compatibly

[Jan-Benedict Glaw]

[-- Attachment #1: Type: text/plain, Size: 620 bytes --]

On Thu, 2004-01-08 14:36:15 -0500, Gene Heskett <gene.heskett@verizon.net>
wrote in message <200401081436.15006.gene.heskett@verizon.net>:
> Whats the general option syntax used with diff to generate the 
> patchfiles I see posted here?

$ diff -Nur linux-2.6.x-clean linux-2.6.x-floppy-fixed

MfG, JBG

-- 
   Jan-Benedict Glaw       jbglaw@lug-owl.de    . +49-172-7608481
   "Eine Freie Meinung in  einem Freien Kopf    | Gegen Zensur | Gegen Krieg
    fuer einen Freien Staat voll Freier Bürger" | im Internet! |   im Irak!
   ret = do_actions((curr | FREE_SPEECH) & ~(NEW_COPYRIGHT_LAW | DRM | TCPA));

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]