* A little ctc cleanup
@ 2004-01-16 20:23 Pete Zaitcev
0 siblings, 0 replies; only message in thread
From: Pete Zaitcev @ 2004-01-16 20:23 UTC (permalink / raw)
To: schwidefsky; +Cc: linux-kernel
Hi, Martin:
With the current state machine, doing fsm_event(DEV_EVENT_STOP) is an
exact equivalent of dev_action_stop, only it adds a (superfluous) debugging
tracepoint, which is useless anyway, because dev_action_restart is an action,
so its caller does the same.
My compliments to Fritz and please ask him to accept this.
-- Pete
--- linux-2.6.1-mm3/drivers/s390/net/ctcmain.c 2004-01-14 16:17:02.000000000 -0500
+++ linux-2.6.1-mm3-s390/drivers/s390/net/ctcmain.c 2004-01-16 11:12:29.000000000 -0500
@@ -2075,10 +2075,9 @@
{
struct net_device *dev = (struct net_device *)arg;
struct ctc_priv *privptr = dev->priv;
-
+
printk(KERN_DEBUG "%s: Restarting\n", dev->name);
dev_action_stop(fi, event, arg);
- fsm_event(privptr->fsm, DEV_EVENT_STOP, dev);
fsm_addtimer(&privptr->restart_timer, CTC_TIMEOUT_5SEC,
DEV_EVENT_START, dev);
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2004-01-16 20:23 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-01-16 20:23 A little ctc cleanup Pete Zaitcev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).