2.4.24 extra CPU cycles in scsi.c

2.4.24 extra CPU cycles in scsi.c

[Richard B. Johnson]

When looking through various modules that I use, trying to
find out where some memory seems to be leaking, I found a
couple of unrelated things in scsi.c.

The code sets a structure-member to NULL, then releases the
pointer to that structure. A few CPU cycles being thrown away.
Since I was reviewing the whole file, I also got rid of the
spurious casts when calling kfree().



--- linux-2.4.24/drivers/scsi/scsi.c.orig	Thu Feb 19 10:45:20 2004
+++ linux-2.4.24/drivers/scsi/scsi.c	Thu Feb 19 11:01:47 2004
@@ -314,11 +314,7 @@
 void scsi_release_request(Scsi_Request * req)
 {
 	if( req->sr_command != NULL )
-	{
 		scsi_release_command(req->sr_command);
-		req->sr_command = NULL;
-	}
-
 	kfree(req);
 }

@@ -1449,7 +1445,7 @@
  	spin_lock_irqsave(&device_request_lock, flags);
 	for (SCpnt = SDpnt->device_queue; SCpnt; SCpnt = SCnext) {
 		SDpnt->device_queue = SCnext = SCpnt->next;
-		kfree((char *) SCpnt);
+		kfree(SCpnt);
 	}
 	SDpnt->has_cmdblocks = 0;
 	SDpnt->queue_depth = 0;
@@ -1550,7 +1546,7 @@
 	    max_scsi_hosts = n+1;
 	}
 	else
-	    kfree((char *) shn);
+	    kfree(shn);
     }
 }

@@ -1845,7 +1841,7 @@
 				HBA_ptr->host_queue = scd->next;
 			}
 			blk_cleanup_queue(&scd->request_queue);
-			kfree((char *) scd);
+			kfree(scd);
 		} else {
 			goto out;
 		}
@@ -2164,7 +2160,7 @@
 			blk_cleanup_queue(&SDpnt->request_queue);
 			/* Next free up the Scsi_Device structures for this host */
 			shpnt->host_queue = SDpnt->next;
-			kfree((char *) SDpnt);
+			kfree(SDpnt);

 		}
 	}


Cheers,
Dick Johnson
Penguin : Linux version 2.4.24 on an i686 machine (797.90 BogoMips).
            Note 96.31% of all statistics are fiction.

Re: 2.6.5, ACPI, suspend and ThinkPad R40

[Biker]

> Hello,
> I have an IBM ThinkPad R40...

Me too,
(model number 2681-BDG) and since the release of 2.6.0 many things have been 
sligthly getting worse or never worked at all.

-It used to suspend/resume correctly until 2.6.3, but afterwards reboots 
during resume.
-Unplugging a usb bluetooth dongle oopses the machine since 2.6.4 (used to 
work ok before).
-The radeon fb drivers both have little problems (garbled screen, last screen 
line not updated correctly)...
-The pcmcia controller does not work correctly (it stays dead if a pccard is 
plugged in after bootup, I need to restart the pcmcia services to make it 
work again).
-I never succeded in making infrared work, however it works fine under 2.4.

I'm very willing to help all the kernel hackers out there to solve these 
problems, please contact me, I can run whatever test/patch/hack you might 
throw at me.

Regards, Biker.

2.6.5, ACPI, suspend and ThinkPad R40

[Olivier Bornet]

[-- Attachment #1: Type: text/plain, Size: 1040 bytes --]

Hello,

I have an IBM ThinkPad R40, with kernel 2.6.5 and ACPI enabled. The
system is a GNU/Debian testing up-to-date, with acpid debian package
1.0.3-2.

I can suspend with Fn-F4, thanks to a acpi config doing:

    echo 3 > /proc/acpi/sleep

The laptop goes to sleep as execpted: all the lights goes off, and the
light with the moon goes on. All is OK until this. :-)

The problem is that I can't resume it. I have found no way. Pressing Fn
don't work. The power button don't work. Closing and opening the display
don't work. The only way to re-start the computer is to remove the
battery. Of course, this cause a reboot.

Has anyone some suggestion for me ?

Thanks in advance.

		Olivier
-- 
Olivier Bornet                |    français : http://puck.ch/f
Swiss Ice Hockey Results      |    english  : http://puck.ch/e
http://puck.ch/               |    deutsch  : http://puck.ch/g
Olivier.Bornet@puck.ch        |    italiano : http://puck.ch/i
Get my PGP-key at http://puck.ch/pgp or at http://pgp.mit.edu/

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: 2.6.5, ACPI, suspend and ThinkPad R40

[Michal Schmidt]

Olivier Bornet wrote:
> Hello,
> 
> I have an IBM ThinkPad R40, with kernel 2.6.5 and ACPI enabled. The
> system is a GNU/Debian testing up-to-date, with acpid debian package
> 1.0.3-2.
> 

I have an R40 too (model 2681-HSG).

> I can suspend with Fn-F4, thanks to a acpi config doing:
> 
>     echo 3 > /proc/acpi/sleep
> 
> The laptop goes to sleep as execpted: all the lights goes off, and the
> light with the moon goes on. All is OK until this. :-)
> 
> The problem is that I can't resume it. I have found no way. Pressing Fn
> don't work. The power button don't work. Closing and opening the display
> don't work. The only way to re-start the computer is to remove the
> battery. Of course, this cause a reboot.
>

I had exactly the same problem.

> Has anyone some suggestion for me ?
> 

Yes, see:
   http://bugzilla.kernel.org/show_bug.cgi?id=1415
There is a patch which worked for me.

> Thanks in advance.
> 
> 		Olivier

Michal Schmidt

Re: 2.6.5, ACPI, suspend and ThinkPad R40

[Olivier Bornet]

[-- Attachment #1: Type: text/plain, Size: 962 bytes --]

Hi,

On Mon, Apr 05, 2004 at 12:00:09AM +0200, Michal Schmidt wrote:
> Yes, see:
>   http://bugzilla.kernel.org/show_bug.cgi?id=1415
> There is a patch which worked for me.

Thanks a lot. :-) This patch is working as expected for me. Now, after
doing a:

  echo LID > /proc/acpi/wakeup_devices
  echo SLPB > /proc/acpi/wakeup_devices

I can resume by opening the laptop, or by using the Fn button, or by
using the power button. :-)

This patch seems "very" old (first release 2003-10-28).

Anyone know why this patch is not in the kernel source tree at this
time ?

Good day, and thanks for your help.

		Olivier
-- 
Olivier Bornet                |    français : http://puck.ch/f
Swiss Ice Hockey Results      |    english  : http://puck.ch/e
http://puck.ch/               |    deutsch  : http://puck.ch/g
Olivier.Bornet@puck.ch        |    italiano : http://puck.ch/i
Get my PGP-key at http://puck.ch/pgp or at http://pgp.mit.edu/

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: 2.6.5, ACPI, suspend and ThinkPad R40

[Kevin Fenzi]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

>>>>> "Olivier" == Olivier Bornet <Olivier.Bornet@puck.ch> writes:

Olivier> Hi,
Olivier> On Mon, Apr 05, 2004 at 12:00:09AM +0200, Michal Schmidt wrote:
>> Yes, see: http://bugzilla.kernel.org/show_bug.cgi?id=1415 There is
>> a patch which worked for me.

Olivier> Thanks a lot. :-) This patch is working as expected for
Olivier> me. Now, after doing a:

Olivier>   echo LID > /proc/acpi/wakeup_devices echo SLPB >
Olivier> /proc/acpi/wakeup_devices

Olivier> I can resume by opening the laptop, or by using the Fn
Olivier> button, or by using the power button. :-)

Alas, I would like to report it doesn't work for me. 

My laptop suspends, but never comes back from suspend as well. 
It doesn't seem like the LID or power buttons are a possible setting
for me. Doing a 'cat /proc/acpi/wakeup_devices' gives:

Device  Speep state     Status
C04E       5            disabled
C0A0       3            disabled
C0A6       3            disabled
C0A9       3            disabled
C161       3            disabled
C162       3            disabled
C177       4            disabled
C11E       4            disabled

C11E is my suspend button, but it doesn't seem like it will allow S3? 
I have no idea what the other addresses are. I tried enabling them
all, and got a big pile of oopses (which I can duplicate if anyone
wants)

Any ideas?

Olivier> This patch seems "very" old (first release 2003-10-28).

Olivier> Anyone know why this patch is not in the kernel source tree
Olivier> at this time ?

Yeah, if it helps some people then it should go in I would think. 

It would be nice if we could just set the list of wakeup devices to a
sane list for everyone tho. Power/lid/suspend button. 

Back to using nigels swsusp2... at least it's quite fast and the
latest one seems pretty stable with 2.6 for me at least. ;) 

kevin
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)
Comment: Processed by Mailcrypt 3.5.8 <http://mailcrypt.sourceforge.net/>

iD8DBQFAciPl3imCezTjY0ERApkWAJ4xZFmTDgXsq7cvrXOQ/HR70Fs5PQCeJshD
uc1kiMwhqGUhn0fDD7FDHko=
=E51X
-----END PGP SIGNATURE-----

Re: 2.6.5, ACPI, suspend and ThinkPad R40

[Olivier Bornet]

[-- Attachment #1: Type: text/plain, Size: 1335 bytes --]

Hello,

On Tue, Apr 06, 2004 at 12:19:40AM +0200, Olivier Bornet wrote:
> On Mon, Apr 05, 2004 at 12:00:09AM +0200, Michal Schmidt wrote:
> > Yes, see:
> >   http://bugzilla.kernel.org/show_bug.cgi?id=1415
> > There is a patch which worked for me.
> 
> Thanks a lot. :-) This patch is working as expected for me.

A correction: I can now suspend to ram and resume. But it seems that the
laptop is not in a good state after suspend to ram. I have let it in
this mode the whole day, and when I was back at home, the battery was
empty. :-(

I don't have use this laptop (or even another one) with another
configuration for suspending to ram, so I don't realy know how much time
we can have it in the suspend to ram state before the battery is empty.
But talking with one friend, he say that with 2.4 kernel and APM, this
will be many weeks.

I'm ready to help with the ACPI stuff if this may be usefull. Just let
me know what I can test.

Good day, and thanks for your help.

		Olivier
-- 
Olivier Bornet                |    français : http://puck.ch/f
Swiss Ice Hockey Results      |    english  : http://puck.ch/e
http://puck.ch/               |    deutsch  : http://puck.ch/g
Olivier.Bornet@puck.ch        |    italiano : http://puck.ch/i
Get my PGP-key at http://puck.ch/pgp or at http://pgp.mit.edu/

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: 2.6.5, ACPI, suspend and ThinkPad R40

[Vincent C Jones]

In article <1HPBr-5yC-5@gated-at.bofh.it> you write:
>-----BEGIN PGP SIGNED MESSAGE-----
>Hash: SHA1
>
>>>>>> "Olivier" == Olivier Bornet <Olivier.Bornet@puck.ch> writes:
>
>Olivier> Hi,
>Olivier> On Mon, Apr 05, 2004 at 12:00:09AM +0200, Michal Schmidt wrote:
>>> Yes, see: http://bugzilla.kernel.org/show_bug.cgi?id=1415 There is
>>> a patch which worked for me.
>
>Olivier> Thanks a lot. :-) This patch is working as expected for
>Olivier> me. Now, after doing a:
>
>Olivier>   echo LID > /proc/acpi/wakeup_devices echo SLPB >
>Olivier> /proc/acpi/wakeup_devices
>
>Olivier> I can resume by opening the laptop, or by using the Fn
>Olivier> button, or by using the power button. :-)
>
>Alas, I would like to report it doesn't work for me. 
>
>My laptop suspends, but never comes back from suspend as well. 
>It doesn't seem like the LID or power buttons are a possible setting
>for me. Doing a 'cat /proc/acpi/wakeup_devices' gives:
>
>Device  Speep state     Status
>C04E       5            disabled
>C0A0       3            disabled
>C0A6       3            disabled
>C0A9       3            disabled
>C161       3            disabled
>C162       3            disabled
>C177       4            disabled
>C11E       4            disabled
>
>C11E is my suspend button, but it doesn't seem like it will allow S3? 
>I have no idea what the other addresses are. I tried enabling them
>all, and got a big pile of oopses (which I can duplicate if anyone
>wants)
>
>Any ideas?
>
>Olivier> This patch seems "very" old (first release 2003-10-28).
>
>Olivier> Anyone know why this patch is not in the kernel source tree
>Olivier> at this time ?
>
>Yeah, if it helps some people then it should go in I would think. 
>
>It would be nice if we could just set the list of wakeup devices to a
>sane list for everyone tho. Power/lid/suspend button. 
>
>Back to using nigels swsusp2... at least it's quite fast and the
>latest one seems pretty stable with 2.6 for me at least. ;) 
>
>kevin

Is it my imagination or is there an acute lack of interest in supporting 
notebook features in 2.6.X? Since the early days of 2.5.X, there have
been questions raised regarding suspend/resume and related questions of
critical importance to mobile users. All (at least those associated with
IBM ThinkPads) have been ignored by developers, with the only responses
coming from other notebook users expressing similar concerns.

Is the answer to upgrade to a faster notebook so I can get adequate
performance using the 2.4 kernel in order to retain the ability to
quickly and safely suspend / resume while on the road?

Side note: X23, kernel 2.6.5, SuSE 9.0 with Kraxel fixes. Suspend only
works while on battery, forgetting to unplug the AC first fails every
time and intermittently locks up the box.

-- 
Dr. Vincent C. Jones, PE              Expert advice and a helping hand
Computer Network Consultant           for those who want to manage and
Networking Unlimited, Inc.            control their networking destiny
14 Dogwood Lane, Tenafly, NJ 07670
http://www.networkingunlimited.com
VCJones@NetworkingUnlimited.com  +1 201 568-7810  Fax: +1 201 568-7269 

Re: 2.6.5, ACPI, suspend and ThinkPad R40

[Theodore Ts'o]

On Tue, Apr 06, 2004 at 09:16:02AM -0400, Vincent C Jones wrote:
> Is it my imagination or is there an acute lack of interest in supporting 
> notebook features in 2.6.X? Since the early days of 2.5.X, there have
> been questions raised regarding suspend/resume and related questions of
> critical importance to mobile users. All (at least those associated with
> IBM ThinkPads) have been ignored by developers, with the only responses
> coming from other notebook users expressing similar concerns.
> 
> Is the answer to upgrade to a faster notebook so I can get adequate
> performance using the 2.4 kernel in order to retain the ability to
> quickly and safely suspend / resume while on the road?
> 
> Side note: X23, kernel 2.6.5, SuSE 9.0 with Kraxel fixes. Suspend only
> works while on battery, forgetting to unplug the AC first fails every
> time and intermittently locks up the box.

Well, I've taken the easy way out and simply used ditched ACPI, and
used APM support, which works just fine on IBM Thinkpads.  It would be
nice if ACPI worked, and every so often I put in a day or two worth of
futile frustration trying to improve ACPI support on my T40 laptop,
but with so many things being broken, and my only having limited
number of hours in the day, so it was much easier to simply fall back
ten yards and punt.

This is not a particularly satisfing solution for people who are stuck
with Dell or Sony laptops that don't have APM support, and who only
have ACPI, but this might have something to do with why I know a lot
of kernel developers who use IBM Thinkpads.  :-P

						- Ted

P.S.  Of course, in the interests of fair disclosure, a lot of them
work for IBM, including myself....

Re: 2.6.5, ACPI, suspend and ThinkPad R40

[Charles Bueche]

On Tue,  6 Apr 2004 09:16:02 -0400 (EDT)
vcjones@NetworkingUnlimited.com (Vincent C Jones) wrote:
> Is it my imagination or is there an acute lack of interest in
> supporting notebook features in 2.6.X? Since the early days of 2.5.X,
> there have been questions raised regarding suspend/resume and related
> questions of critical importance to mobile users. All (at least those
> associated with IBM ThinkPads) have been ignored by developers, with
> the only responses coming from other notebook users expressing similar
> concerns.

I can add my "me-too" here. I own a Dell I8600 which perform excellently
in gentoo with 2.6.x, with the only remaining issue being
suspend+resume.

I have tried several times to understand this ACPI thing, only to find
that the KISS principle has been forgotten when it has been designed.
Maybe it's simply not possible to design something"acceptably simple" in
this business, but the fact that Alan Cox has called it "terminally
broken" tend to support my point of view.

My intend is not to start a flamewar here, but with laptop HW coming
down in price, we have to provide a better support for casual users. 

I can't contribute code here, but I can test things you throw at me for
Dell I8600, so feel free.

Charles

-- 
Charles Bueche <charles@bueche.ch>
sand, snow, wave, wind and net -surfer

RE: 2.6.5, ACPI, suspend and ThinkPad R40

[Brown, Len]

>> lack of interest in supporting notebook features

I'm glad that you're complaining about suspend/resume not working.
This means that you were able to boot and configure your system
using ACPI -- a year ago you wouldn't have got so far;-)

Yes, in the past year we've concentrated more on the configuration
issues at the expense of advanced features such as suspend/resume.
While we still have configuration issues, their frequency and
severity is lower than it once was, and so I'm hopeful that
we're over the hump there and will be able to
spend more time on features such as supsend/resume.

When I looked at a suspend/resume failure a couple of weeks ago
I discovered that there is no code in linux to save/restore
PCI configuration space for PCI bridges.  This is sort of a deal
killer -- as bits such as bus-master-enable could come up
enabled or disabled depending on the roll of the dice.
I hoped somebody on linux-pci would send a patch, but I haven't
seen one yet.

Cheers,
-Len