Re: Oops with cpufreq on 2.6.5-mm1

Re: Oops with cpufreq on 2.6.5-mm1

[Jan Killius]

The patch have fixed the problem. thx
-- 
        Jan

Re: Oops with cpufreq on 2.6.5-mm1

[Dave Jones]

On Tue, Apr 06, 2004 at 12:16:09PM +0200, Jan Killius wrote:
 > The patch have fixed the problem. thx
 
Can you try out the fully merged patch at
http://www.codemonkey.org.uk/projects/bitkeeper/cpufreq
too please ?

		Dave

Re: Oops with cpufreq on 2.6.5-mm1

[Jan Killius]

Hi,
the patch don't apply clean to 2.6.5-mm1.
On Tuesday 06 April 2004 15:54, Dave Jones wrote:
> On Tue, Apr 06, 2004 at 12:16:09PM +0200, Jan Killius wrote:
>  > The patch have fixed the problem. thx
>
> Can you try out the fully merged patch at
> http://www.codemonkey.org.uk/projects/bitkeeper/cpufreq
> too please ?
>
> 		Dave

Re: Oops with cpufreq on 2.6.5-mm1

[Dave Jones]

On Tue, Apr 06, 2004 at 04:53:14PM +0200, Jan Killius wrote:

 > >  > The patch have fixed the problem. thx
 > >
 > > Can you try out the fully merged patch at
 > > http://www.codemonkey.org.uk/projects/bitkeeper/cpufreq
 > > too please ?
 >
 > the patch don't apply clean to 2.6.5-mm1.

No, it's against 2.6.5 vanilla. You'll get it to apply to -mm
if you backout (patch -R) the bk-cpufreq.patch  first from
http://www.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.5/2.6.5-mm1/broken-out/

		Dave

Re: Oops with cpufreq on 2.6.5-mm1

[Jan Killius]

The patch applies cleanly and seems to be working.
-- 
        Jan

Re: Oops with cpufreq on 2.6.5-mm1

[Dave Jones]

On Tue, Apr 06, 2004 at 11:51:49AM +0200, Angelo Dell'Aera wrote:
 > On Tue, 6 Apr 2004 02:05:00 +0200
 > Jan Killius <jkillius@arcor.de> wrote:
 > 
 > >Hi,
 > >cpufreq make an Oops on loading. I have attached the oops.
 > 
 > The problem seems to be located in find_psb_table(). In fact, 
 > while powernow_table is correctly initialized, it's never assigned
 > to data->powernow_table thus leading to a NULL pointer dereferencing
 > in cpufreq_frequency_table_cpuinfo(). Try this patch please.

-mm has an incomplete merge of the large set of changes in this
driver. I'm working on it, and should get the merge complete today.

		Dave

Re: Oops with cpufreq on 2.6.5-mm1

[Angelo Dell'Aera]

On Tue, 6 Apr 2004 02:05:00 +0200
Jan Killius <jkillius@arcor.de> wrote:

>Hi,
>cpufreq make an Oops on loading. I have attached the oops.

The problem seems to be located in find_psb_table(). In fact, 
while powernow_table is correctly initialized, it's never assigned
to data->powernow_table thus leading to a NULL pointer dereferencing
in cpufreq_frequency_table_cpuinfo(). Try this patch please.

Regards.

--

Angelo Dell'Aera 'buffer' 
Antifork Research, Inc.	  	http://buffer.antifork.org


--- linux-2.6.5-mm1/arch/i386/kernel/cpu/cpufreq/powernow-k8.c.old	2004-04-06 11:46:41.000000000 +0200
+++ linux-2.6.5-mm1/arch/i386/kernel/cpu/cpufreq/powernow-k8.c	2004-04-06 11:48:29.000000000 +0200
@@ -634,6 +634,8 @@
 			return -EIO;
 		}
 
+		data->powernow_table = powernow_table;
+
 		printk(KERN_INFO PFX "currfid 0x%x (%d MHz), currvid 0x%x\n",
 		       data->currfid, find_freq_from_fid(data->currfid), data->currvid);
 

Re: Oops with cpufreq on 2.6.5-mm1

[Jan Killius]

[-- Attachment #1: Type: text/plain, Size: 40 bytes --]

Here is the right Oops.
-- 
        Jan

[-- Attachment #2: oops.txt --]
[-- Type: text/plain, Size: 3682 bytes --]

ksymoops 2.4.9 on x86_64 2.6.5-mm1.  Options used
     -V (default)
     -k /proc/ksyms (default)
     -l /proc/modules (default)
     -o /lib/modules/2.6.5-mm1/ (default)
     -m /usr/src/linux/System.map (default)

Warning: You did not tell me where to find symbol information.  I will
assume that the log matches the kernel and modules that are running
right now and I'll use the default options above for symbol resolution.
If the current kernel and/or modules do not match the log, you can get
more accurate output by telling me the kernel version and where to find
map, modules, ksyms etc.  ksymoops -h explains the options.

Error (regular_file): read_ksyms stat /proc/ksyms failed
No modules in ksyms, skipping objects
No ksyms, skipping lsmod
Unable to handle kernel NULL pointer dereference at 0000000000000004 RIP:
<ffffffff80269922>{cpufreq_frequency_table_cpuinfo+2}PML4 3e8f6067 PGD 3e963067 PMD 0
Oops: 0000 [1] PREEMPT
CPU 0
Pid: 5201, comm: modprobe Not tainted 2.6.5-mm1
RIP: 0010:[<ffffffff80269922>] <ffffffff80269922>{cpufreq_frequency_table_cpuinfo+2}
Using defaults from ksymoops -t elf64-x86-64 -a i386:x86-64
RSP: 0018:000001003ecb7d90  EFLAGS: 00010246
RAX: 00000000001e8480 RBX: 000000000000000c RCX: 0000000000000000
RDX: 00000000fffffffb RSI: 0000000000000000 RDI: 000001003fb739c0
RBP: 000001003f40f600 R08: 0000000000000033 R09: 0000000000000003
R10: 00000000ffffffff R11: 0000000000000000 R12: 000000000000020c
R13: 000000000000000c R14: 00000100000f0e88 R15: 000001003fb739c0
FS:  0000003872f0f060(0000) GS:ffffffff803ef580(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 000000008005003b
        CR2: 0000000000000004 CR3: 0000000000101000 CR4: 00000000000006e0
Process modprobe (pid: 5201, stackpage=1003e8b5000)
        Stack: ffffffffa0003523 0000000000000002 ffffffff00000002 000001003fbc3c60
        0000000000000001 000001003fb739c0 ffffffff803ba688 000001003fb739e8
        0000000000000000 0000000000517c70
        Call Trace:<ffffffffa0003523>{:powernow_k8:powernowk8_cpu_init+1315}
        <ffffffff802691e1>{cpufreq_add_dev+257} <ffffffff8013333e>{printk+494}
        <ffffffff80213a09>{sysdev_driver_register+121} <ffffffff802696fb>{cpufreq_register_driver+219}
        <ffffffffa0003698>{:powernow_k8:powernowk8_init+216}
        <ffffffff80149c8e>{sys_init_module+318} <ffffffff8010f172>{system_call+126}
Code: 83 7e 04 fe 41 b8 ff ff ff ff 89 ca 74 22 31 c0 8b 44 c6 04


>>RIP; ffffffff80269922 <cpufreq_frequency_table_cpuinfo+2/60>   <=====

Trace; ffffffffa0003523 <_end+1fbe7523/7f1e4000>
Trace; ffffffff802691e1 <cpufreq_add_dev+101/350>
Trace; ffffffff80213a09 <sysdev_driver_register+79/d0>
Trace; ffffffffa0003698 <_end+1fbe7698/7f1e4000>
Trace; ffffffff80149c8e <sys_init_module+13e/2b0>

Code;  ffffffff80269922 <cpufreq_frequency_table_cpuinfo+2/60>
0000000000000000 <_RIP>:
Code;  ffffffff80269922 <cpufreq_frequency_table_cpuinfo+2/60>   <=====
   0:   83 7e 04 fe               cmpl   $0xfffffffffffffffe,0x4(%rsi)   <=====
Code;  ffffffff80269926 <cpufreq_frequency_table_cpuinfo+6/60>
   4:   41 b8 ff ff ff ff         mov    $0xffffffff,%r8d
Code;  ffffffff8026992c <cpufreq_frequency_table_cpuinfo+c/60>
   a:   89 ca                     mov    %ecx,%edx
Code;  ffffffff8026992e <cpufreq_frequency_table_cpuinfo+e/60>
   c:   74 22                     je     30 <_RIP+0x30>
Code;  ffffffff80269930 <cpufreq_frequency_table_cpuinfo+10/60>
   e:   31 c0                     xor    %eax,%eax
Code;  ffffffff80269932 <cpufreq_frequency_table_cpuinfo+12/60>
  10:   8b 44 c6 04               mov    0x4(%rsi,%rax,8),%eax

CR2: 0000000000000004

1 warning and 1 error issued.  Results may not be reliable.

Oops with cpufreq on 2.6.5-mm1

[Jan Killius]

[-- Attachment #1: Type: text/plain, Size: 2391 bytes --]

Hi,
cpufreq make an Oops on loading. I have attached the oops.

/proc/cpuinfo:
processor       : 0
vendor_id       : AuthenticAMD
cpu family      : 15
model           : 4
model name      : AMD Athlon(tm) 64 Processor 3200+
stepping        : 8
cpu MHz         : 2002.580
cache size      : 1024 KB
fpu             : yes
fpu_exception   : yes
cpuid level     : 1
wp              : yes
flags           : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge
mca cmov pat pse36 clflush mmx fxsr sse sse2 syscall nx mmxext lm
3dnowext 3dnow
bogomips        : 3923.96
TLB size        : 1088 4K pages
clflush size    : 64
cache_alignment : 64
address sizes   : 40 bits physical, 48 bits virtual
power management: ts fid vid ttp

/proc/modules:
nvidia 2564468 0 - Live 0xffffffffa017d000
ipv6 242688 8 - Live 0xffffffffa0140000
nfs 102496 1 - Live 0xffffffffa0125000
lockd 60880 2 nfs, Live 0xffffffffa0115000
sunrpc 136032 5 nfs,lockd, Live 0xffffffffa00f2000
ehci_hcd 27528 0 - Live 0xffffffffa00ea000
uhci_hcd 28456 0 - Live 0xffffffffa00e2000
sata_via 5892 0 - Live 0xffffffffa00df000
libata 35456 1 sata_via,[permanent], Live 0xffffffffa00d5000
snd_seq 52928 0 - Live 0xffffffffa00c7000
snd_via82xx 21568 0 - Live 0xffffffffa00c0000
snd_pcm 89996 1 snd_via82xx, Live 0xffffffffa00a9000
snd_timer 22152 2 snd_seq,snd_pcm, Live 0xffffffffa00a2000
snd_ac97_codec 65156 1 snd_via82xx, Live 0xffffffffa0091000
snd_page_alloc 9864 2 snd_via82xx,snd_pcm, Live 0xffffffffa008d000
snd_mpu401_uart 6912 1 snd_via82xx, Live 0xffffffffa008a000
snd_rawmidi 20608 1 snd_mpu401_uart, Live 0xffffffffa0083000
snd_seq_device 7308 2 snd_seq,snd_rawmidi, Live 0xffffffffa0080000
snd 41648 8
snd_seq,snd_via82xx,snd_pcm,snd_timer,snd_ac97_codec,snd_mpu401_uart,snd_rawmidi,snd_seq_device,
Live 0xffffffffa0074000
usbcore 99056 4 ehci_hcd,uhci_hcd, Live 0xffffffffa005a000
vfat 13824 5 - Live 0xffffffffa0055000
fat 43200 1 vfat, Live 0xffffffffa0049000
sk98lin 149068 1 - Live 0xffffffffa0023000
w83781d 34432 0 - Live 0xffffffffa0019000
i2c_sensor 2816 1 w83781d, Live 0xffffffffa0017000
i2c_isa 2560 0 - Live 0xffffffffa0015000
i2c_dev 10496 0 - Live 0xffffffffa0011000
i2c_core 21124 4 w83781d,i2c_sensor,i2c_isa,i2c_dev, Live
0xffffffffa000a000
cpufreq_powersave 1920 0 - Live 0xffffffffa0008000
cpufreq_userspace 5344 0 - Live 0xffffffffa0005000
powernow_k8 9643 2 - Loading 0xffffffffa0000000

-- 
        Jan

[-- Attachment #2: oops.txt --]
[-- Type: text/plain, Size: 1727 bytes --]

Unable to handle kernel NULL pointer dereference at 0000000000000004 RIP:
<ffffffff80269922>{cpufreq_frequency_table_cpuinfo+2}PML4 3e8f6067 PGD 3e963067 PMD 0
Oops: 0000 [1] PREEMPT
CPU 0
Pid: 5201, comm: modprobe Not tainted 2.6.5-mm1
RIP: 0010:[<ffffffff80269922>] <ffffffff80269922>{cpufreq_frequency_table_cpuinfo+2}
RSP: 0018:000001003ecb7d90  EFLAGS: 00010246
RAX: 00000000001e8480 RBX: 000000000000000c RCX: 0000000000000000
RDX: 00000000fffffffb RSI: 0000000000000000 RDI: 000001003fb739c0
RBP: 000001003f40f600 R08: 0000000000000033 R09: 0000000000000003
R10: 00000000ffffffff R11: 0000000000000000 R12: 000000000000020c
R13: 000000000000000c R14: 00000100000f0e88 R15: 000001003fb739c0
FS:  0000003872f0f060(0000) GS:ffffffff803ef580(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 000000008005003b
        CR2: 0000000000000004 CR3: 0000000000101000 CR4: 00000000000006e0
Process modprobe (pid: 5201, stackpage=1003e8b5000)
        Stack: ffffffffa0003523 0000000000000002 ffffffff00000002 000001003fbc3c60
        0000000000000001 000001003fb739c0 ffffffff803ba688 000001003fb739e8
        0000000000000000 0000000000517c70
        Call Trace:<ffffffffa0003523>{:powernow_k8:powernowk8_cpu_init+1315}
        <ffffffff802691e1>{cpufreq_add_dev+257} <ffffffff8013333e>{printk+494}
        <ffffffff80213a09>{sysdev_driver_register+121} <ffffffff802696fb>{cpufreq_register_driver+219}
        <ffffffffa0003698>{:powernow_k8:powernowk8_init+216}
        <ffffffff80149c8e>{sys_init_module+318} <ffffffff8010f172>{system_call+126}


Code: 83 7e 04 fe 41 b8 ff ff ff ff 89 ca 74 22 31 c0 8b 44 c6 04
RIP <ffffffff80269922>{cpufreq_frequency_table_cpuinfo+2} RSP <000001003ecb7d90>
CR2: 0000000000000004