* [PATCH] mark amiflop non-unloadable
@ 2004-09-12 16:37 Christoph Hellwig
0 siblings, 0 replies; only message in thread
From: Christoph Hellwig @ 2004-09-12 16:37 UTC (permalink / raw)
To: akpm, geert; +Cc: linux-m68k, linux-kernel
as it's using the obsolete MOD_{INC,DEC}_USE_COUNT it's implicitly
locked already, but let's remove them and make it explicit so these
macros can go away completely without breaking m68k compile.
--- 1.46/drivers/block/amiflop.c 2003-09-03 12:32:10 +02:00
+++ edited/drivers/block/amiflop.c 2004-09-12 18:37:32 +02:00
@@ -386,16 +386,6 @@
fd_select(drive);
udelay (1);
fd_deselect(drive);
-
-#ifdef MODULE
-/*
- this is the last interrupt for any drive access, happens after
- release (from floppy_off). So we have to wait until now to decrease
- the use count.
-*/
- if (decusecount)
- MOD_DEC_USE_COUNT;
-#endif
}
static void floppy_off (unsigned int nr)
@@ -1590,10 +1580,6 @@
local_irq_save(flags);
fd_ref[drive]++;
fd_device[drive] = system;
-#ifdef MODULE
- if (unit[drive].motor == 0)
- MOD_INC_USE_COUNT;
-#endif
local_irq_restore(flags);
unit[drive].dtype=&data_types[system];
@@ -1839,6 +1825,7 @@
return amiga_floppy_init();
}
+#if 0 /* not safe to unload */
void cleanup_module(void)
{
int i;
@@ -1859,4 +1846,5 @@
release_mem_region(CUSTOM_PHYSADDR+0x20, 8);
unregister_blkdev(FLOPPY_MAJOR, "fd");
}
+#endif
#endif
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2004-09-12 16:38 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-09-12 16:37 [PATCH] mark amiflop non-unloadable Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).