From: "Jörn Engel" <joern@wohnheim.fh-wedel.de>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Being more anal about iospace accesses..
Date: Wed, 15 Sep 2004 19:32:36 +0200 [thread overview]
Message-ID: <20040915173236.GE6158@wohnheim.fh-wedel.de> (raw)
In-Reply-To: <Pine.LNX.4.58.0409151004370.2333@ppc970.osdl.org>
On Wed, 15 September 2004 10:07:29 -0700, Linus Torvalds wrote:
> On Wed, 15 Sep 2004, Jörn Engel wrote:
> >
> > C now supports pointer arithmetic with void*?
>
> C doesn't. gcc does. It's a documented extension, and it acts like if it
> was done on a byte.
>
> See gcc's user guide "Extension to the C Language Family".
>
> It's a singularly good feature.
Nice.
But it still leaves me confused. Before I had this code:
struct regs {
uint32_t status;
...
}
...
struct regs *regs = ioremap(...);
uint32_t status = regs->status;
...
So now I should do it like this:
#define REG_STATUS 0
...
void __iomem *regs = ioremap(...);
uint32_t status = readl(regs + REG_STATUS);
...
But wait, that only works when long is 32bit wide. Plus I could be
stupid enough and "#define REG_STATUS 64" while the register space is
just 64 bytes long. It solves the confusion about address spaces,
agreed, but overall I'm more confused now. Hope it's just temporary.
Jörn
--
There is no worse hell than that provided by the regrets
for wasted opportunities.
-- Andre-Louis Moreau in Scarabouche
next prev parent reply other threads:[~2004-09-15 17:36 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Pine.LNX.4.58.0409081543320.5912@ppc970.osdl.org>
[not found] ` <Pine.LNX.4.58.0409150737260.2333@ppc970.osdl.org>
2004-09-15 16:30 ` Being more anal about iospace accesses Linus Torvalds
2004-09-15 16:54 ` Jörn Engel
2004-09-15 17:07 ` Linus Torvalds
2004-09-15 17:32 ` Jörn Engel [this message]
2004-09-15 17:57 ` Linus Torvalds
2004-09-15 18:06 ` Linus Torvalds
2004-09-15 19:34 ` Greg KH
2004-09-15 19:53 ` Linus Torvalds
2004-09-15 20:06 ` Greg KH
2004-09-16 14:58 ` Horst von Brand
2004-09-15 17:45 ` Nikita Danilov
2004-09-15 18:09 ` Linus Torvalds
2004-09-15 18:40 ` Chris Wedgwood
2004-09-15 17:07 ` Jeff Garzik
2004-09-15 17:16 ` Roland Dreier
2004-09-15 17:39 ` Linus Torvalds
2004-09-15 20:07 ` Russell King
2004-09-15 17:36 ` Horst von Brand
2004-09-15 17:40 ` Brian Gerst
2004-09-15 16:56 ` Dave Jones
2004-09-15 17:19 ` Roger Luethi
2004-09-15 17:23 ` Richard B. Johnson
2004-09-15 22:21 ` Deepak Saxena
2004-09-15 22:46 ` Linus Torvalds
2004-09-15 23:09 ` Deepak Saxena
2004-09-16 12:51 ` Geert Uytterhoeven
2004-09-16 22:10 ` Deepak Saxena
2004-09-15 22:29 ` Roland Dreier
2004-09-15 23:26 ` Being more careful " Linus Torvalds
2004-09-16 0:10 ` viro
2004-09-16 11:40 ` David Woodhouse
2004-09-16 12:25 ` David Woodhouse
2004-09-16 14:01 ` Linus Torvalds
2004-09-18 9:46 ` Kai Henningsen
2004-09-15 18:25 Being more anal " linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040915173236.GE6158@wohnheim.fh-wedel.de \
--to=joern@wohnheim.fh-wedel.de \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).