From: Linus Torvalds <torvalds@osdl.org>
To: Greg KH <greg@kroah.com>
Cc: J?rn Engel <joern@wohnheim.fh-wedel.de>,
Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Being more anal about iospace accesses..
Date: Wed, 15 Sep 2004 12:53:51 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.58.0409151251060.2333@ppc970.osdl.org> (raw)
In-Reply-To: <20040915193414.GA24131@kroah.com>
On Wed, 15 Sep 2004, Greg KH wrote:
>
> Currently a few drivers do:
> status = readl(®s.status);
I assume that's "®s->status", since regs had better be a pointer..
> which causes sparse warnings.
>
> How should that code be changed to prevent this? Convert them all to
> ioread32()? Or figure out a way to supress the warning for readl()?
Just make sure that you annotate "regs" as a pointer to IO space.
Ie if you have
struct xxxx __iomem *regs;
then everything will be fine - sparse knows that "regs" is a IO pointer,
and that obviously makes "®s->member" _also_ an IO pointer.
You'll need that __iomem annotation anyway, since otherwise sparse would
complain when you do the assignment from the "ioremap()" call (and the
thing had better come from ioremap() some way, or it's not valid in the
first place to do "readl()" on it).
Linus
next prev parent reply other threads:[~2004-09-15 19:54 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Pine.LNX.4.58.0409081543320.5912@ppc970.osdl.org>
[not found] ` <Pine.LNX.4.58.0409150737260.2333@ppc970.osdl.org>
2004-09-15 16:30 ` Being more anal about iospace accesses Linus Torvalds
2004-09-15 16:54 ` Jörn Engel
2004-09-15 17:07 ` Linus Torvalds
2004-09-15 17:32 ` Jörn Engel
2004-09-15 17:57 ` Linus Torvalds
2004-09-15 18:06 ` Linus Torvalds
2004-09-15 19:34 ` Greg KH
2004-09-15 19:53 ` Linus Torvalds [this message]
2004-09-15 20:06 ` Greg KH
2004-09-16 14:58 ` Horst von Brand
2004-09-15 17:45 ` Nikita Danilov
2004-09-15 18:09 ` Linus Torvalds
2004-09-15 18:40 ` Chris Wedgwood
2004-09-15 17:07 ` Jeff Garzik
2004-09-15 17:16 ` Roland Dreier
2004-09-15 17:39 ` Linus Torvalds
2004-09-15 20:07 ` Russell King
2004-09-15 17:36 ` Horst von Brand
2004-09-15 17:40 ` Brian Gerst
2004-09-15 16:56 ` Dave Jones
2004-09-15 17:19 ` Roger Luethi
2004-09-15 17:23 ` Richard B. Johnson
2004-09-15 22:21 ` Deepak Saxena
2004-09-15 22:46 ` Linus Torvalds
2004-09-15 23:09 ` Deepak Saxena
2004-09-16 12:51 ` Geert Uytterhoeven
2004-09-16 22:10 ` Deepak Saxena
2004-09-15 22:29 ` Roland Dreier
2004-09-15 23:26 ` Being more careful " Linus Torvalds
2004-09-16 0:10 ` viro
2004-09-16 11:40 ` David Woodhouse
2004-09-16 12:25 ` David Woodhouse
2004-09-16 14:01 ` Linus Torvalds
2004-09-18 9:46 ` Kai Henningsen
2004-09-15 18:25 Being more anal " linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.58.0409151251060.2333@ppc970.osdl.org \
--to=torvalds@osdl.org \
--cc=greg@kroah.com \
--cc=joern@wohnheim.fh-wedel.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).