* Input: sunkbd concern
@ 2004-10-22 23:33 Dmitry Torokhov
2004-10-27 1:06 ` David S. Miller
0 siblings, 1 reply; 5+ messages in thread
From: Dmitry Torokhov @ 2004-10-22 23:33 UTC (permalink / raw)
To: David S. Miller, Vojtech Pavlik; +Cc: LKML
Hi,
I have been looking at sunkbd.c and it seems that it attaches not only to
ports that speak SUNKBD protocol but also to ports that do not specify any
protocol:
if ((serio->type & SERIO_PROTO) && (serio->type & SERIO_PROTO) != SERIO_SUNKBD)
return;
Was that an oversight or it was done intentionally?
Thanks!
--
Dmitry
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Input: sunkbd concern
2004-10-22 23:33 Input: sunkbd concern Dmitry Torokhov
@ 2004-10-27 1:06 ` David S. Miller
2004-10-27 1:32 ` Dmitry Torokhov
0 siblings, 1 reply; 5+ messages in thread
From: David S. Miller @ 2004-10-27 1:06 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: vojtech, linux-kernel
On Fri, 22 Oct 2004 18:33:04 -0500
Dmitry Torokhov <dtor_core@ameritech.net> wrote:
> I have been looking at sunkbd.c and it seems that it attaches not only to
> ports that speak SUNKBD protocol but also to ports that do not specify any
> protocol:
>
> if ((serio->type & SERIO_PROTO) && (serio->type & SERIO_PROTO) != SERIO_SUNKBD)
> return;
>
> Was that an oversight or it was done intentionally?
I believe it is intentional.
If SERIO_PROTO bits are all clear, this is supposed to have
a special meaning in that any keyboard driver can claim
the serio line.
So if it's the "wildcard" zero value, or specifically SERIO_SUNKBD,
we'll attach to it.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Input: sunkbd concern
2004-10-27 1:06 ` David S. Miller
@ 2004-10-27 1:32 ` Dmitry Torokhov
2004-10-27 5:47 ` Vojtech Pavlik
0 siblings, 1 reply; 5+ messages in thread
From: Dmitry Torokhov @ 2004-10-27 1:32 UTC (permalink / raw)
To: David S. Miller; +Cc: vojtech, linux-kernel
On Tuesday 26 October 2004 08:06 pm, David S. Miller wrote:
> On Fri, 22 Oct 2004 18:33:04 -0500
> Dmitry Torokhov <dtor_core@ameritech.net> wrote:
>
> > I have been looking at sunkbd.c and it seems that it attaches not only to
> > ports that speak SUNKBD protocol but also to ports that do not specify any
> > protocol:
> >
> > if ((serio->type & SERIO_PROTO) && (serio->type & SERIO_PROTO) != SERIO_SUNKBD)
> > return;
> >
> > Was that an oversight or it was done intentionally?
>
> I believe it is intentional.
>
> If SERIO_PROTO bits are all clear, this is supposed to have
> a special meaning in that any keyboard driver can claim
> the serio line.
>
> So if it's the "wildcard" zero value, or specifically SERIO_SUNKBD,
> we'll attach to it.
>
I would buy if I see another keyboard doing this, but so far only sunkbd
does this. The rest of keyboards connecting to a RS232-type ports require
exact protocol match...
The background is that I am trying to create a bus "match" function for
serio and trying to understand the requirements...
--
Dmitry
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Input: sunkbd concern
2004-10-27 1:32 ` Dmitry Torokhov
@ 2004-10-27 5:47 ` Vojtech Pavlik
2004-10-27 6:08 ` Dmitry Torokhov
0 siblings, 1 reply; 5+ messages in thread
From: Vojtech Pavlik @ 2004-10-27 5:47 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: David S. Miller, linux-kernel
On Tue, Oct 26, 2004 at 08:32:27PM -0500, Dmitry Torokhov wrote:
> On Tuesday 26 October 2004 08:06 pm, David S. Miller wrote:
> > On Fri, 22 Oct 2004 18:33:04 -0500
> > Dmitry Torokhov <dtor_core@ameritech.net> wrote:
> >
> > > I have been looking at sunkbd.c and it seems that it attaches not only to
> > > ports that speak SUNKBD protocol but also to ports that do not specify any
> > > protocol:
> > >
> > > if ((serio->type & SERIO_PROTO) && (serio->type & SERIO_PROTO) != SERIO_SUNKBD)
> > > return;
> > >
> > > Was that an oversight or it was done intentionally?
> >
> > I believe it is intentional.
> >
> > If SERIO_PROTO bits are all clear, this is supposed to have
> > a special meaning in that any keyboard driver can claim
> > the serio line.
> >
> > So if it's the "wildcard" zero value, or specifically SERIO_SUNKBD,
> > we'll attach to it.
> >
>
> I would buy if I see another keyboard doing this, but so far only sunkbd
> does this. The rest of keyboards connecting to a RS232-type ports require
> exact protocol match...
>
> The background is that I am trying to create a bus "match" function for
> serio and trying to understand the requirements...
IIRC my intention was that if the driver can autoprobe for the device,
it shouldn't require 'inputattach' to specify the protocol, which is the
case of sunkbd, but not other serial port keyboards.
--
Vojtech Pavlik
SuSE Labs, SuSE CR
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Input: sunkbd concern
2004-10-27 5:47 ` Vojtech Pavlik
@ 2004-10-27 6:08 ` Dmitry Torokhov
0 siblings, 0 replies; 5+ messages in thread
From: Dmitry Torokhov @ 2004-10-27 6:08 UTC (permalink / raw)
To: Vojtech Pavlik; +Cc: David S. Miller, linux-kernel
On Wednesday 27 October 2004 12:47 am, Vojtech Pavlik wrote:
> On Tue, Oct 26, 2004 at 08:32:27PM -0500, Dmitry Torokhov wrote:
> > On Tuesday 26 October 2004 08:06 pm, David S. Miller wrote:
> > > On Fri, 22 Oct 2004 18:33:04 -0500
> > > Dmitry Torokhov <dtor_core@ameritech.net> wrote:
> > >
> > > > I have been looking at sunkbd.c and it seems that it attaches not only to
> > > > ports that speak SUNKBD protocol but also to ports that do not specify any
> > > > protocol:
> > > >
> > > > if ((serio->type & SERIO_PROTO) && (serio->type & SERIO_PROTO) != SERIO_SUNKBD)
> > > > return;
> > > >
> > > > Was that an oversight or it was done intentionally?
> > >
> > > I believe it is intentional.
> > >
> > > If SERIO_PROTO bits are all clear, this is supposed to have
> > > a special meaning in that any keyboard driver can claim
> > > the serio line.
> > >
> > > So if it's the "wildcard" zero value, or specifically SERIO_SUNKBD,
> > > we'll attach to it.
> > >
> >
> > I would buy if I see another keyboard doing this, but so far only sunkbd
> > does this. The rest of keyboards connecting to a RS232-type ports require
> > exact protocol match...
> >
> > The background is that I am trying to create a bus "match" function for
> > serio and trying to understand the requirements...
>
> IIRC my intention was that if the driver can autoprobe for the device,
> it shouldn't require 'inputattach' to specify the protocol, which is the
> case of sunkbd, but not other serial port keyboards.
>
Ok, I see now. Thanks!
--
Dmitry
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2004-10-27 6:12 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-10-22 23:33 Input: sunkbd concern Dmitry Torokhov
2004-10-27 1:06 ` David S. Miller
2004-10-27 1:32 ` Dmitry Torokhov
2004-10-27 5:47 ` Vojtech Pavlik
2004-10-27 6:08 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).