* [2.6 patch] sched.c: remove an unused function
@ 2004-10-28 23:14 Adrian Bunk
2004-10-29 0:25 ` Adrian Bunk
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Adrian Bunk @ 2004-10-28 23:14 UTC (permalink / raw)
To: Nick Piggin; +Cc: linux-kernel
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
The patch below removes an unused function from kernel/sched.c
diffstat output:
kernel/sched.c | 5 -----
1 files changed, 5 deletions(-)
Signed-off-by: Adrian Bunk <bunk@stusta.de>
- --- linux-2.6.10-rc1-mm1-full/kernel/sched.c.old 2004-10-28 22:33:14.000000000 +0200
+++ linux-2.6.10-rc1-mm1-full/kernel/sched.c 2004-10-28 22:34:47.000000000 +0200
@@ -438,11 +438,6 @@
return rq;
}
- -static inline void rq_unlock(runqueue_t *rq)
- -{
- - spin_unlock_irq(&rq->lock);
- -}
- -
#ifdef CONFIG_SCHEDSTATS
/*
* Called when a process is dequeued from the active array and given
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (GNU/Linux)
iD8DBQFBgX1lmfzqmE8StAARAva8AKCKU+UIq++mdjpHqK4YbvoXmGBAwwCfS7OY
p7bxTJ7cdG5gZCkWhPWCyVc=
=UigC
-----END PGP SIGNATURE-----
^ permalink raw reply [flat|nested] 6+ messages in thread
* [2.6 patch] sched.c: remove an unused function
2004-10-28 23:14 [2.6 patch] sched.c: remove an unused function Adrian Bunk
@ 2004-10-29 0:25 ` Adrian Bunk
2004-10-29 7:23 ` Ingo Molnar
[not found] ` <41819D48.7000005@bigpond.net.au>
2 siblings, 0 replies; 6+ messages in thread
From: Adrian Bunk @ 2004-10-29 0:25 UTC (permalink / raw)
To: Nick Piggin; +Cc: linux-kernel
[ this time without the problems due to a digital signature... ]
The patch below removes an unused function from kernel/sched.c
diffstat output:
kernel/sched.c | 5 -----
1 files changed, 5 deletions(-)
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.10-rc1-mm1-full/kernel/sched.c.old 2004-10-28 22:33:14.000000000 +0200
+++ linux-2.6.10-rc1-mm1-full/kernel/sched.c 2004-10-28 22:34:47.000000000 +0200
@@ -438,11 +438,6 @@
return rq;
}
-static inline void rq_unlock(runqueue_t *rq)
-{
- spin_unlock_irq(&rq->lock);
-}
-
#ifdef CONFIG_SCHEDSTATS
/*
* Called when a process is dequeued from the active array and given
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [2.6 patch] sched.c: remove an unused function
2004-10-28 23:14 [2.6 patch] sched.c: remove an unused function Adrian Bunk
2004-10-29 0:25 ` Adrian Bunk
@ 2004-10-29 7:23 ` Ingo Molnar
[not found] ` <41819D48.7000005@bigpond.net.au>
2 siblings, 0 replies; 6+ messages in thread
From: Ingo Molnar @ 2004-10-29 7:23 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Nick Piggin, linux-kernel, Andrew Morton
* Adrian Bunk <bunk@stusta.de> wrote:
> The patch below removes an unused function from kernel/sched.c
Acked-by: Ingo Molnar <mingo@elte.hu>
Ingo
^ permalink raw reply [flat|nested] 6+ messages in thread
* [2.6 patch] sched.c: remove an unused macro
[not found] ` <41819D48.7000005@bigpond.net.au>
@ 2004-10-29 11:31 ` Adrian Bunk
2004-10-29 11:34 ` Ingo Molnar
0 siblings, 1 reply; 6+ messages in thread
From: Adrian Bunk @ 2004-10-29 11:31 UTC (permalink / raw)
To: Peter Williams; +Cc: Nick Piggin, Ingo Molnar, linux-kernel
On Fri, Oct 29, 2004 at 11:30:48AM +1000, Peter Williams wrote:
>
> You missed some :-). The cpu_to_node_mask() macros don't seem to be
> used either.
I only searched for unused static inline functions (since this was
relatively easy).
But your comment seems to be correct, and below is the patch that
removes the cpu_to_node_mask macros.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.10-rc1-mm2-full/kernel/sched.c.old 2004-10-29 13:28:14.000000000 +0200
+++ linux-2.6.10-rc1-mm2-full/kernel/sched.c 2004-10-29 13:28:24.000000000 +0200
@@ -51,12 +51,6 @@
#include <asm/unistd.h>
-#ifdef CONFIG_NUMA
-#define cpu_to_node_mask(cpu) node_to_cpumask(cpu_to_node(cpu))
-#else
-#define cpu_to_node_mask(cpu) (cpu_online_map)
-#endif
-
/*
* Convert user-nice values [ -20 ... 0 ... 19 ]
* to static priority [ MAX_RT_PRIO..MAX_PRIO-1 ],
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [2.6 patch] sched.c: remove an unused macro
2004-10-29 11:31 ` [2.6 patch] sched.c: remove an unused macro Adrian Bunk
@ 2004-10-29 11:34 ` Ingo Molnar
2004-10-29 11:36 ` Nick Piggin
0 siblings, 1 reply; 6+ messages in thread
From: Ingo Molnar @ 2004-10-29 11:34 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Peter Williams, Nick Piggin, linux-kernel, Andrew Morton
* Adrian Bunk <bunk@stusta.de> wrote:
> On Fri, Oct 29, 2004 at 11:30:48AM +1000, Peter Williams wrote:
> >
> > You missed some :-). The cpu_to_node_mask() macros don't seem to be
> > used either.
>
> I only searched for unused static inline functions (since this was
> relatively easy).
>
>
> But your comment seems to be correct, and below is the patch that
> removes the cpu_to_node_mask macros.
Acked-by: Ingo Molnar <mingo@elte.hu>
Ingo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [2.6 patch] sched.c: remove an unused macro
2004-10-29 11:34 ` Ingo Molnar
@ 2004-10-29 11:36 ` Nick Piggin
0 siblings, 0 replies; 6+ messages in thread
From: Nick Piggin @ 2004-10-29 11:36 UTC (permalink / raw)
To: Ingo Molnar; +Cc: Adrian Bunk, Peter Williams, linux-kernel, Andrew Morton
Ingo Molnar wrote:
> * Adrian Bunk <bunk@stusta.de> wrote:
>
>
>>On Fri, Oct 29, 2004 at 11:30:48AM +1000, Peter Williams wrote:
>>
>>>You missed some :-). The cpu_to_node_mask() macros don't seem to be
>>>used either.
>>
>>I only searched for unused static inline functions (since this was
>>relatively easy).
>>
>>
>>But your comment seems to be correct, and below is the patch that
>>removes the cpu_to_node_mask macros.
>
>
> Acked-by: Ingo Molnar <mingo@elte.hu>
>
Yep, this and the last both look fine to me too.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2004-10-29 11:42 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-10-28 23:14 [2.6 patch] sched.c: remove an unused function Adrian Bunk
2004-10-29 0:25 ` Adrian Bunk
2004-10-29 7:23 ` Ingo Molnar
[not found] ` <41819D48.7000005@bigpond.net.au>
2004-10-29 11:31 ` [2.6 patch] sched.c: remove an unused macro Adrian Bunk
2004-10-29 11:34 ` Ingo Molnar
2004-10-29 11:36 ` Nick Piggin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).