linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [2.6 patch] ia64 smpboot.c: remove an unused function
@ 2004-12-12 19:39 Adrian Bunk
  2004-12-12 20:46 ` Robert Picco
  0 siblings, 1 reply; 3+ messages in thread
From: Adrian Bunk @ 2004-12-12 19:39 UTC (permalink / raw)
  To: David Mosberger-Tang; +Cc: linux-ia64, linux-kernel

The patch below removes an unused global functions.


Signed-off-by: Adrian Bunk <bunk@stusta.de>

--- linux-2.6.10-rc2-mm4-full/arch/ia64/kernel/smpboot.c.old	2004-12-12 02:51:04.000000000 +0100
+++ linux-2.6.10-rc2-mm4-full/arch/ia64/kernel/smpboot.c	2004-12-12 02:51:18.000000000 +0100
@@ -356,11 +356,6 @@
 	return cpu_idle();
 }
 
-struct pt_regs * __devinit idle_regs(struct pt_regs *regs)
-{
-	return NULL;
-}
-
 struct create_idle {
 	struct task_struct *idle;
 	struct completion done;


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [2.6 patch] ia64 smpboot.c: remove an unused function
  2004-12-12 20:46 ` Robert Picco
@ 2004-12-12 20:41   ` Adrian Bunk
  0 siblings, 0 replies; 3+ messages in thread
From: Adrian Bunk @ 2004-12-12 20:41 UTC (permalink / raw)
  To: Robert Picco; +Cc: David Mosberger-Tang, linux-ia64, linux-kernel

On Sun, Dec 12, 2004 at 03:46:41PM -0500, Robert Picco wrote:
> Adrian Bunk wrote:
> 
> >The patch below removes an unused global functions.
> >
> >
> >Signed-off-by: Adrian Bunk <bunk@stusta.de>
> >
> >--- linux-2.6.10-rc2-mm4-full/arch/ia64/kernel/smpboot.c.old	2004-12-12 
> >02:51:04.000000000 +0100
> >+++ linux-2.6.10-rc2-mm4-full/arch/ia64/kernel/smpboot.c	2004-12-12 
> >02:51:18.000000000 +0100
> >@@ -356,11 +356,6 @@
> >	return cpu_idle();
> >}
> >
> >-struct pt_regs * __devinit idle_regs(struct pt_regs *regs)
> >-{
> >-	return NULL;
> >-}
> >-
> >struct create_idle {
> >	struct task_struct *idle;
> >	struct completion done;
> >
> > 
> >
> I don't believe this is unused.  At least not in 2.6.10-rc3.  fork_idle 
> requires this function.

Ups sorry, you are correct.

For some strange reason I missed.

> Bob

Thanks for the correction
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [2.6 patch] ia64 smpboot.c: remove an unused function
  2004-12-12 19:39 [2.6 patch] ia64 smpboot.c: remove an unused function Adrian Bunk
@ 2004-12-12 20:46 ` Robert Picco
  2004-12-12 20:41   ` Adrian Bunk
  0 siblings, 1 reply; 3+ messages in thread
From: Robert Picco @ 2004-12-12 20:46 UTC (permalink / raw)
  To: Adrian Bunk; +Cc: David Mosberger-Tang, linux-ia64, linux-kernel

Adrian Bunk wrote:

>The patch below removes an unused global functions.
>
>
>Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
>--- linux-2.6.10-rc2-mm4-full/arch/ia64/kernel/smpboot.c.old	2004-12-12 02:51:04.000000000 +0100
>+++ linux-2.6.10-rc2-mm4-full/arch/ia64/kernel/smpboot.c	2004-12-12 02:51:18.000000000 +0100
>@@ -356,11 +356,6 @@
> 	return cpu_idle();
> }
> 
>-struct pt_regs * __devinit idle_regs(struct pt_regs *regs)
>-{
>-	return NULL;
>-}
>-
> struct create_idle {
> 	struct task_struct *idle;
> 	struct completion done;
>
>  
>
I don't believe this is unused.  At least not in 2.6.10-rc3.  fork_idle 
requires this function.

Bob

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2004-12-12 20:41 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-12-12 19:39 [2.6 patch] ia64 smpboot.c: remove an unused function Adrian Bunk
2004-12-12 20:46 ` Robert Picco
2004-12-12 20:41   ` Adrian Bunk

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).