* the patch of restore-pci-config-space-on-resume break S1 on ASUS2400 NE
@ 2004-12-23 8:51 Yu, Luming
2004-12-23 9:05 ` Arjan van de Ven
2004-12-23 13:17 ` Pavel Machek
0 siblings, 2 replies; 6+ messages in thread
From: Yu, Luming @ 2004-12-23 8:51 UTC (permalink / raw)
To: arjanv; +Cc: Brown, Len, Li, Shaohua, Pallipadi, Venkatesh, linux-kernel
Hi,
Since 2.6.7, the Changes for drivers/pci/pci-driver.c@1.37 make my
ASUS 2400NE hang on S1 resume.
Should we by-pass pci_default_suspend(resume) for S1?
Because, ACPI spec defines : in S1, all system context is preserved
with the exception of CPU caches.
Thanks,
Luming
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: the patch of restore-pci-config-space-on-resume break S1 on ASUS2400 NE
2004-12-23 8:51 the patch of restore-pci-config-space-on-resume break S1 on ASUS2400 NE Yu, Luming
@ 2004-12-23 9:05 ` Arjan van de Ven
2004-12-23 13:17 ` Pavel Machek
1 sibling, 0 replies; 6+ messages in thread
From: Arjan van de Ven @ 2004-12-23 9:05 UTC (permalink / raw)
To: Yu, Luming; +Cc: Brown, Len, Li, Shaohua, Pallipadi, Venkatesh, linux-kernel
On Thu, Dec 23, 2004 at 04:51:09PM +0800, Yu, Luming wrote:
> Hi,
>
> Since 2.6.7, the Changes for drivers/pci/pci-driver.c@1.37 make my
> ASUS 2400NE hang on S1 resume.
we need to figure out which device can't take the pci config space
restore...
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: the patch of restore-pci-config-space-on-resume break S1 on ASUS2400 NE
2004-12-23 8:51 the patch of restore-pci-config-space-on-resume break S1 on ASUS2400 NE Yu, Luming
2004-12-23 9:05 ` Arjan van de Ven
@ 2004-12-23 13:17 ` Pavel Machek
1 sibling, 0 replies; 6+ messages in thread
From: Pavel Machek @ 2004-12-23 13:17 UTC (permalink / raw)
To: Yu, Luming
Cc: arjanv, Brown, Len, Li, Shaohua, Pallipadi, Venkatesh, linux-kernel
Hi!
> Since 2.6.7, the Changes for drivers/pci/pci-driver.c@1.37 make my
> ASUS 2400NE hang on S1 resume.
>
> Should we by-pass pci_default_suspend(resume) for S1?
> Because, ACPI spec defines : in S1, all system context is preserved
> with the exception of CPU caches.
I'd rather do the full driver resume, even in S1. Vendors
can't read so S1 does not really preserve *all* state on many
machines, and we need to get it right for S3, anyway.
Pavel
--
64 bytes from 195.113.31.123: icmp_seq=28 ttl=51 time=448769.1 ms
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: the patch of restore-pci-config-space-on-resume break S1 on ASUS2400 NE
2004-12-27 10:14 Yu, Luming
@ 2004-12-27 13:44 ` Alan Cox
0 siblings, 0 replies; 6+ messages in thread
From: Alan Cox @ 2004-12-27 13:44 UTC (permalink / raw)
To: Yu, Luming
Cc: Arjan van de Ven, Pavel Machek, Brown, Len, Li, Shaohua,
Pallipadi, Venkatesh, Linux Kernel Mailing List, acpi-devel, Fu,
Michael
On Llu, 2004-12-27 at 10:14, Yu, Luming wrote:
> Actually, the kernel (after removing restore-pci-config-space-on-resume patch) with option "ide=nodma"
> can work with S1 suspend/resume without any hang so far.
> So my suggestion for IDE driver is to disable DMA before entering S1, and enable
> DMA after resuming from S1 if DMA was enabled. I need help from IDE guys to confirm it.
The IDE layer has no problem doing this, although it raises interesting
questions about why it would be neccessary.
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: the patch of restore-pci-config-space-on-resume break S1 on ASUS2400 NE
@ 2004-12-27 10:14 Yu, Luming
2004-12-27 13:44 ` Alan Cox
0 siblings, 1 reply; 6+ messages in thread
From: Yu, Luming @ 2004-12-27 10:14 UTC (permalink / raw)
To: Arjan van de Ven, Pavel Machek
Cc: Brown, Len, Li, Shaohua, Pallipadi, Venkatesh, linux-kernel,
acpi-devel, Fu, Michael
Actually, the kernel (after removing restore-pci-config-space-on-resume patch) with option "ide=nodma"
can work with S1 suspend/resume without any hang so far.
So my suggestion for IDE driver is to disable DMA before entering S1, and enable
DMA after resuming from S1 if DMA was enabled. I need help from IDE guys to confirm it.
Thanks,
Luming
-----Original Message-----
From: Yu, Luming
Sent: 2004年12月23日 20:05
To: 'Arjan van de Ven'
Cc: Brown, Len; Li, Shaohua; Pallipadi, Venkatesh; linux-kernel@vger.kernel.org; 'acpi-devel@lists.sourceforge.net'
Subject: RE: the patch of restore-pci-config-space-on-resume break S1 on ASUS2400 NE
The following is S1 suspend and resume log for one working case.
With 2.6.7, after several times of S1 suspend and resume cycle, the box eventually hang on resume.
With 2.6.10-rc3, after One time of successful S1 suspend and resume cycle, the box hang on resume.
With your patch, I always saw S1 resume hang so far.
After applying patch filed at bugzilla
http://bugzilla.kernel.org/show_bug.cgi?id=1588
to 2.6.7 kernel, the second time of S1 resume by hitting power button cause power off . :-(
>From these experience, I'm thinking S1 is totally broken on this box. :-(
Thanks,
Luming
PM: Preparing system for suspend
Stopping tasks: =============================|
device name = Realtek Semiconductor Co., Ltd. RTL-8139/8139C/8139C+
---> ignored
device name = Ricoh Co Ltd R5C552 IEEE 1394 Controller
---> ignored
device name = Ricoh Co Ltd RL5c476 II (#2)
---> ignored
device name = Ricoh Co Ltd RL5c476 II
---> ignored
device name = Intel Corp. 82801DB/DBL/DBM (ICH4/ICH4-L/ICH4-M) AC'97 Modem Controller
---> ignored
device name = Intel Corp. 82801DB/DBL/DBM (ICH4/ICH4-L/ICH4-M) AC'97 Audio Controller
---> ignored
device name = Intel Corp. 82801DB/DBL/DBM (ICH4/ICH4-L/ICH4-M) SMBus Controller
---> ignored
device name = Intel Corp. 82801DBM (ICH4) Ultra ATA Storage Controller
---> ignored
device name = Intel Corp. 82801DBM LPC Interface Controller
device name = Intel Corp. 82801 PCI Bridge
device name = Intel Corp. 82801DB/DBM (ICH4/ICH4-M) USB 2.0 EHCI Controller
---> ignored
device name = Intel Corp. 82801DB/DBL/DBM (ICH4/ICH4-L/ICH4-M) USB UHCI Controller #3
---> ignored
device name = Intel Corp. 82801DB/DBL/DBM (ICH4/ICH4-L/ICH4-M) USB UHCI Controller #2
---> ignored
device name = Intel Corp. 82801DB/DBL/DBM (ICH4/ICH4-L/ICH4-M) USB UHCI Controller #1
---> ignored
device name = Intel Corp. 82852/855GM Integrated Graphics Device (#2)
device name = Intel Corp. 82852/855GM Integrated Graphics Device
device name = Intel Corp. 855GM/GME GMCH Configuration Process Registers
device name = Intel Corp. 855GM/GME GMCH Memory I/O Control Registers
device name = Intel Corp. 82852/855GM Host Bridge
---> ignored
PM: Entering state.
hwsleep-0315 [04] acpi_enter_sleep_state: Entering sleep state [S1]
Back to C!
PM: Finishing up.
device name = Intel Corp. 82852/855GM Host Bridge
---> ignored
device name = Intel Corp. 855GM/GME GMCH Memory I/O Control Registers
device name = Intel Corp. 855GM/GME GMCH Configuration Process Registers
device name = Intel Corp. 82852/855GM Integrated Graphics Device
device name = Intel Corp. 82852/855GM Integrated Graphics Device (#2)
device name = Intel Corp. 82801DB/DBL/DBM (ICH4/ICH4-L/ICH4-M) USB UHCI Controller #1
---> ignored
device name = Intel Corp. 82801DB/DBL/DBM (ICH4/ICH4-L/ICH4-M) USB UHCI Controller #2
---> ignored
device name = Intel Corp. 82801DB/DBL/DBM (ICH4/ICH4-L/ICH4-M) USB UHCI Controller #3
---> ignored
device name = Intel Corp. 82801DB/DBM (ICH4/ICH4-M) USB 2.0 EHCI Controller
---> ignored
device name = Intel Corp. 82801 PCI Bridge
device name = Intel Corp. 82801DBM LPC Interface Controller
device name = Intel Corp. 82801DBM (ICH4) Ultra ATA Storage Controller
---> ignored
device name = Intel Corp. 82801DB/DBL/DBM (ICH4/ICH4-L/ICH4-M) SMBus Controller
---> ignored
device name = Intel Corp. 82801DB/DBL/DBM (ICH4/ICH4-L/ICH4-M) AC'97 Audio Controller
---> ignored
device name = Intel Corp. 82801DB/DBL/DBM (ICH4/ICH4-L/ICH4-M) AC'97 Modem Controller
---> ignored
device name = Ricoh Co Ltd RL5c476 II
---> ignored
device name = Ricoh Co Ltd RL5c476 II (#2)
---> ignored
device name = Ricoh Co Ltd R5C552 IEEE 1394 Controller
---> ignored
device name = Realtek Semiconductor Co., Ltd. RTL-8139/8139C/8139C+
---> ignored
Restarting tasks... done
#lspci
0000:00:00.0 Host bridge: Intel Corp. 82852/855GM Host Bridge (rev 02)
0000:00:00.1 System peripheral: Intel Corp.: Unknown device 3584 (rev 02)
0000:00:00.3 System peripheral: Intel Corp.: Unknown device 3585 (rev 02)
0000:00:02.0 VGA compatible controller: Intel Corp. 82852/855GM Integrated Graphics Device (rev 02)
0000:00:02.1 Display controller: Intel Corp. 82852/855GM Integrated Graphics Device (rev 02)
0000:00:1d.0 USB Controller: Intel Corp. 82801DB USB (Hub #1) (rev 03)
0000:00:1d.1 USB Controller: Intel Corp. 82801DB USB (Hub #2) (rev 03)
0000:00:1d.2 USB Controller: Intel Corp. 82801DB USB (Hub #3) (rev 03)
0000:00:1d.7 USB Controller: Intel Corp. 82801DB USB2 (rev 03)
0000:00:1e.0 PCI bridge: Intel Corp. 82801BAM/CAM PCI Bridge (rev 83)
0000:00:1f.0 ISA bridge: Intel Corp. 82801DBM LPC Interface Controller (rev 03)
0000:00:1f.1 IDE interface: Intel Corp. 82801DBM Ultra ATA Storage Controller (rev 03)
0000:00:1f.3 SMBus: Intel Corp. 82801DB/DBM SMBus Controller (rev 03)
0000:00:1f.5 Multimedia audio controller: Intel Corp. 82801DB AC'97 Audio Controller (rev 03)
0000:00:1f.6 Modem: Intel Corp. 82801DB AC'97 Modem Controller (rev 03)
0000:01:03.0 CardBus bridge: Ricoh Co Ltd RL5c476 II (rev a9)
0000:01:03.1 CardBus bridge: Ricoh Co Ltd RL5c476 II (rev a9)
0000:01:03.2 FireWire (IEEE 1394): Ricoh Co Ltd R5C552 IEEE 1394 Controller (rev 01)
0000:01:04.0 Ethernet controller: Realtek Semiconductor Co., Ltd. RTL-8139/8139C/8139C+ (rev 10)
-----Original Message-----
From: Arjan van de Ven [mailto:arjanv@redhat.com]
Sent: 2004年12月23日 17:05
To: Yu, Luming
Cc: Brown, Len; Li, Shaohua; Pallipadi, Venkatesh; linux-kernel@vger.kernel.org
Subject: Re: the patch of restore-pci-config-space-on-resume break S1 on ASUS2400 NE
On Thu, Dec 23, 2004 at 04:51:09PM +0800, Yu, Luming wrote:
> Hi,
>
> Since 2.6.7, the Changes for drivers/pci/pci-driver.c@1.37 make my
> ASUS 2400NE hang on S1 resume.
we need to figure out which device can't take the pci config space
restore...
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: the patch of restore-pci-config-space-on-resume break S1 on ASUS2400 NE
@ 2004-12-23 12:04 Yu, Luming
0 siblings, 0 replies; 6+ messages in thread
From: Yu, Luming @ 2004-12-23 12:04 UTC (permalink / raw)
To: Arjan van de Ven
Cc: Brown, Len, Li, Shaohua, Pallipadi, Venkatesh, linux-kernel, acpi-devel
The following is S1 suspend and resume log for one working case.
With 2.6.7, after several times of S1 suspend and resume cycle, the box eventually hang on resume.
With 2.6.10-rc3, after One time of successful S1 suspend and resume cycle, the box hang on resume.
With your patch, I always saw S1 resume hang so far.
After applying patch filed at bugzilla
http://bugzilla.kernel.org/show_bug.cgi?id=1588
to 2.6.7 kernel, the second time of S1 resume by hitting power button cause power off . :-(
>From these experience, I'm thinking S1 is totally broken on this box. :-(
Thanks,
Luming
PM: Preparing system for suspend
Stopping tasks: =============================|
device name = Realtek Semiconductor Co., Ltd. RTL-8139/8139C/8139C+
---> ignored
device name = Ricoh Co Ltd R5C552 IEEE 1394 Controller
---> ignored
device name = Ricoh Co Ltd RL5c476 II (#2)
---> ignored
device name = Ricoh Co Ltd RL5c476 II
---> ignored
device name = Intel Corp. 82801DB/DBL/DBM (ICH4/ICH4-L/ICH4-M) AC'97 Modem Controller
---> ignored
device name = Intel Corp. 82801DB/DBL/DBM (ICH4/ICH4-L/ICH4-M) AC'97 Audio Controller
---> ignored
device name = Intel Corp. 82801DB/DBL/DBM (ICH4/ICH4-L/ICH4-M) SMBus Controller
---> ignored
device name = Intel Corp. 82801DBM (ICH4) Ultra ATA Storage Controller
---> ignored
device name = Intel Corp. 82801DBM LPC Interface Controller
device name = Intel Corp. 82801 PCI Bridge
device name = Intel Corp. 82801DB/DBM (ICH4/ICH4-M) USB 2.0 EHCI Controller
---> ignored
device name = Intel Corp. 82801DB/DBL/DBM (ICH4/ICH4-L/ICH4-M) USB UHCI Controller #3
---> ignored
device name = Intel Corp. 82801DB/DBL/DBM (ICH4/ICH4-L/ICH4-M) USB UHCI Controller #2
---> ignored
device name = Intel Corp. 82801DB/DBL/DBM (ICH4/ICH4-L/ICH4-M) USB UHCI Controller #1
---> ignored
device name = Intel Corp. 82852/855GM Integrated Graphics Device (#2)
device name = Intel Corp. 82852/855GM Integrated Graphics Device
device name = Intel Corp. 855GM/GME GMCH Configuration Process Registers
device name = Intel Corp. 855GM/GME GMCH Memory I/O Control Registers
device name = Intel Corp. 82852/855GM Host Bridge
---> ignored
PM: Entering state.
hwsleep-0315 [04] acpi_enter_sleep_state: Entering sleep state [S1]
Back to C!
PM: Finishing up.
device name = Intel Corp. 82852/855GM Host Bridge
---> ignored
device name = Intel Corp. 855GM/GME GMCH Memory I/O Control Registers
device name = Intel Corp. 855GM/GME GMCH Configuration Process Registers
device name = Intel Corp. 82852/855GM Integrated Graphics Device
device name = Intel Corp. 82852/855GM Integrated Graphics Device (#2)
device name = Intel Corp. 82801DB/DBL/DBM (ICH4/ICH4-L/ICH4-M) USB UHCI Controller #1
---> ignored
device name = Intel Corp. 82801DB/DBL/DBM (ICH4/ICH4-L/ICH4-M) USB UHCI Controller #2
---> ignored
device name = Intel Corp. 82801DB/DBL/DBM (ICH4/ICH4-L/ICH4-M) USB UHCI Controller #3
---> ignored
device name = Intel Corp. 82801DB/DBM (ICH4/ICH4-M) USB 2.0 EHCI Controller
---> ignored
device name = Intel Corp. 82801 PCI Bridge
device name = Intel Corp. 82801DBM LPC Interface Controller
device name = Intel Corp. 82801DBM (ICH4) Ultra ATA Storage Controller
---> ignored
device name = Intel Corp. 82801DB/DBL/DBM (ICH4/ICH4-L/ICH4-M) SMBus Controller
---> ignored
device name = Intel Corp. 82801DB/DBL/DBM (ICH4/ICH4-L/ICH4-M) AC'97 Audio Controller
---> ignored
device name = Intel Corp. 82801DB/DBL/DBM (ICH4/ICH4-L/ICH4-M) AC'97 Modem Controller
---> ignored
device name = Ricoh Co Ltd RL5c476 II
---> ignored
device name = Ricoh Co Ltd RL5c476 II (#2)
---> ignored
device name = Ricoh Co Ltd R5C552 IEEE 1394 Controller
---> ignored
device name = Realtek Semiconductor Co., Ltd. RTL-8139/8139C/8139C+
---> ignored
Restarting tasks... done
#lspci
0000:00:00.0 Host bridge: Intel Corp. 82852/855GM Host Bridge (rev 02)
0000:00:00.1 System peripheral: Intel Corp.: Unknown device 3584 (rev 02)
0000:00:00.3 System peripheral: Intel Corp.: Unknown device 3585 (rev 02)
0000:00:02.0 VGA compatible controller: Intel Corp. 82852/855GM Integrated Graphics Device (rev 02)
0000:00:02.1 Display controller: Intel Corp. 82852/855GM Integrated Graphics Device (rev 02)
0000:00:1d.0 USB Controller: Intel Corp. 82801DB USB (Hub #1) (rev 03)
0000:00:1d.1 USB Controller: Intel Corp. 82801DB USB (Hub #2) (rev 03)
0000:00:1d.2 USB Controller: Intel Corp. 82801DB USB (Hub #3) (rev 03)
0000:00:1d.7 USB Controller: Intel Corp. 82801DB USB2 (rev 03)
0000:00:1e.0 PCI bridge: Intel Corp. 82801BAM/CAM PCI Bridge (rev 83)
0000:00:1f.0 ISA bridge: Intel Corp. 82801DBM LPC Interface Controller (rev 03)
0000:00:1f.1 IDE interface: Intel Corp. 82801DBM Ultra ATA Storage Controller (rev 03)
0000:00:1f.3 SMBus: Intel Corp. 82801DB/DBM SMBus Controller (rev 03)
0000:00:1f.5 Multimedia audio controller: Intel Corp. 82801DB AC'97 Audio Controller (rev 03)
0000:00:1f.6 Modem: Intel Corp. 82801DB AC'97 Modem Controller (rev 03)
0000:01:03.0 CardBus bridge: Ricoh Co Ltd RL5c476 II (rev a9)
0000:01:03.1 CardBus bridge: Ricoh Co Ltd RL5c476 II (rev a9)
0000:01:03.2 FireWire (IEEE 1394): Ricoh Co Ltd R5C552 IEEE 1394 Controller (rev 01)
0000:01:04.0 Ethernet controller: Realtek Semiconductor Co., Ltd. RTL-8139/8139C/8139C+ (rev 10)
-----Original Message-----
From: Arjan van de Ven [mailto:arjanv@redhat.com]
Sent: 2004年12月23日 17:05
To: Yu, Luming
Cc: Brown, Len; Li, Shaohua; Pallipadi, Venkatesh; linux-kernel@vger.kernel.org
Subject: Re: the patch of restore-pci-config-space-on-resume break S1 on ASUS2400 NE
On Thu, Dec 23, 2004 at 04:51:09PM +0800, Yu, Luming wrote:
> Hi,
>
> Since 2.6.7, the Changes for drivers/pci/pci-driver.c@1.37 make my
> ASUS 2400NE hang on S1 resume.
we need to figure out which device can't take the pci config space
restore...
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2004-12-27 14:49 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-12-23 8:51 the patch of restore-pci-config-space-on-resume break S1 on ASUS2400 NE Yu, Luming
2004-12-23 9:05 ` Arjan van de Ven
2004-12-23 13:17 ` Pavel Machek
2004-12-23 12:04 Yu, Luming
2004-12-27 10:14 Yu, Luming
2004-12-27 13:44 ` Alan Cox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).