[bk patches] Long delayed input update

[bk patches] Long delayed input update

[Vojtech Pavlik]

Hi!

First, let me apologize for sitting on these patches for so long, I hope
I'll be quicker next time.

Linus, please pull the input patches from

	bk://kernel.bkbits.net/vojtech/input

The patches are also available split out at

	bk://kernel.bkbits.net/vojtech/input

The most important changes are an added ALPS touchpad driver, factored
out PS/2 routines from atkbd and psmouse, and a reworked HID->input
mapping for USB devices.

The diffstat:

 Documentation/input/joystick-parport.txt     |   13 
 Documentation/kernel-parameters.txt          |    6 
 MAINTAINERS                                  |   17 
 drivers/Makefile                             |    4 
 drivers/char/keyboard.c                      |   33 +
 drivers/input/gameport/emu10k1-gp.c          |    3 
 drivers/input/joydev.c                       |    6 
 drivers/input/joystick/Kconfig               |    2 
 drivers/input/joystick/gamecon.c             |  192 ++++-----
 drivers/input/joystick/iforce/iforce-main.c  |    4 
 drivers/input/joystick/iforce/iforce-serio.c |   18 
 drivers/input/joystick/iforce/iforce.h       |    2 
 drivers/input/joystick/magellan.c            |   24 -
 drivers/input/joystick/spaceball.c           |   24 -
 drivers/input/joystick/spaceorb.c            |   24 -
 drivers/input/joystick/stinger.c             |   24 -
 drivers/input/joystick/tmdc.c                |    2 
 drivers/input/joystick/twidjoy.c             |   20 
 drivers/input/joystick/warrior.c             |   24 -
 drivers/input/keyboard/atkbd.c               |  283 +++++++++----
 drivers/input/keyboard/lkkbd.c               |   24 -
 drivers/input/keyboard/newtonkbd.c           |   24 -
 drivers/input/keyboard/sunkbd.c              |   24 -
 drivers/input/keyboard/xtkbd.c               |   24 -
 drivers/input/misc/Kconfig                   |    2 
 drivers/input/misc/uinput.c                  |    3 
 drivers/input/mouse/Kconfig                  |    2 
 drivers/input/mouse/logips2pp.c              |    2 
 drivers/input/mouse/psmouse-base.c           |  310 +++++++++-----
 drivers/input/mouse/psmouse.h                |   40 +
 drivers/input/mouse/sermouse.c               |   24 -
 drivers/input/mouse/synaptics.c              |   54 +-
 drivers/input/mouse/vsxxxaa.c                |   24 -
 drivers/input/mousedev.c                     |  237 ++++++++---
 drivers/input/serio/Kconfig                  |   16 
 drivers/input/serio/Makefile                 |    1 
 drivers/input/serio/ambakmi.c                |   40 +
 drivers/input/serio/ct82c710.c               |  106 ++--
 drivers/input/serio/gscps2.c                 |   62 +-
 drivers/input/serio/i8042-io.h               |   31 +
 drivers/input/serio/i8042.c                  |  353 +++++++++-------
 drivers/input/serio/i8042.h                  |    7 
 drivers/input/serio/maceps2.c                |   86 ++--
 drivers/input/serio/parkbd.c                 |   47 +-
 drivers/input/serio/pcips2.c                 |   52 +-
 drivers/input/serio/q40kbd.c                 |  117 ++++-
 drivers/input/serio/rpckbd.c                 |   50 +-
 drivers/input/serio/sa1111ps2.c              |   39 +
 drivers/input/serio/serio.c                  |  576 +++++++++++++++++++++------
 drivers/input/serio/serio_raw.c              |  390 ++++++++++++++++++
 drivers/input/serio/serport.c                |   49 +-
 drivers/input/touchscreen/gunze.c            |   24 -
 drivers/input/touchscreen/h3600_ts_input.c   |   24 -
 drivers/input/tsdev.c                        |  301 ++++++++------
 drivers/serial/sunsu.c                       |   89 ++--
 drivers/serial/sunzilog.c                    |   80 ++-
 drivers/usb/input/hid-core.c                 |  104 ++--
 drivers/usb/input/hiddev.c                   |   17 
 fs/compat_ioctl.c                            |    2 
 include/asm-ppc/8253pit.h                    |   10 
 include/asm-ppc64/8253pit.h                  |   10 
 include/linux/compat_ioctl.h                 |   17 
 include/linux/input.h                        |    2 
 include/linux/serio.h                        |   66 ++-
 64 files changed, 3003 insertions(+), 1284 deletions(-)

The list of changesets:

ChangeSet@1.1957.1.26, 2004-10-27 01:11:44-05:00, dtor_core@ameritech.net
  Input: parkbd - switch to using module_param. Parameter names are
         parkbd.port and parkbd.mode
  
  Signed-off-by: Dmitry Torokhov <dtor@mail.ru>

ChangeSet@1.1957.1.25, 2004-10-21 23:57:49-05:00, dtor_core@ameritech.net
  Input: gscps2 - remove unused statically allocated gscps2_serio_port
         variable as the port is allocated dynamically.
  
  Signed-off-by: Dmitry Torokhov <dtor@mail.ru>

ChangeSet@1.1957.1.24, 2004-10-21 23:56:41-05:00, dtor_core@ameritech.net
  Input: get rid of pm_dev in input core as it is deprecated and
         nothing uses it anyway.
  
  Signed-off-by: Dmitry Torokhov <dtor@mail.ru>

ChangeSet@1.1957.1.23, 2004-10-21 23:55:41-05:00, dtor_core@ameritech.net
  Input: i8042 - get rid of reboot notifier as suspend method
         should do the job.
  
  Signed-off-by: Dmitry Torokhov <dtor@mail.ru>

ChangeSet@1.1957.1.22, 2004-10-21 23:53:52-05:00, dtor_core@ameritech.net
  Input: i8042 - get rid of old style power management handler since
         APM calls both pm_send and device_suspend.
  
  Signed-off-by: Dmitry Torokhov <dtor@mail.ru>

ChangeSet@1.1957.1.21, 2004-10-21 23:52:36-05:00, dtor_core@ameritech.net
  Input: i8042 - allow turning debugging on and off "on-fly"
         so people do not have to recompile their kernels to
         provide debug info.
  
         Adds new parameter i8042.debug also accessible through
         sysfs. 
  
  Signed-off-by: Dmitry Torokhov <dtor@mail.ru>

ChangeSet@1.1957.1.20, 2004-10-21 23:51:43-05:00, dtor_core@ameritech.net
  Input: when creating input devices for hardware attached to
         a serio port properly set input_device->dev pointer
         so when corresponding class device is created it will
         show proper links to parent device and driver in sysfs
         hierarchy.
  
  Signed-off-by: Dmitry Torokhov <dtor@mail.ru>

ChangeSet@1.1957.1.19, 2004-10-21 23:50:25-05:00, dtor_core@ameritech.net
  Input: evdev, joydev, mousedev, tsdev - remove class device and devfs
         entry when hardware driver disconnects instead of waiting for
         the last user to drop off. This way hardware drivers can be
         unloaded at any time.
  
  Signed-off-by: Dmitry Torokhov <dtor@mail.ru>

ChangeSet@1.1957.1.18, 2004-10-21 23:49:17-05:00, dtor_core@ameritech.net
  Input: couple of whitespace fixes.
  
  Signed-off-by: Dmitry Torokhov <dtor@mail.ru>

ChangeSet@1.1957.1.15, 2004-10-20 10:13:15+02:00, vojtech@suse.cz
  input: Increase ACK timeouts in libps2 in case the RESET_BAT command is used.
         This should fix most Synaptics "reset failed" cases. Thanks to Keith
         Packard for the report.
         Also add some more keyboard IDs, so that unusual keyboards are accepted
         by libps2 and atkbd.
  
  Signed-off-by: Vojtech Pavlik <vojtech@suse.cz>

ChangeSet@1.1957.1.14, 2004-10-19 12:58:36+02:00, vojtech@suse.cz
  Input: i8042 ACPI enumeration - add PNP IDs found in AMD64 laptops.
  
  Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
  Signed-off-by: Andrew Morton <akpm@osdl.org>
  Signed-off-by: Vojtech Pavlik <vojtech@suse.cz>

ChangeSet@1.1957.1.12, 2004-10-16 13:15:38+02:00, vojtech@suse.cz
  input: Fix ssize_t prototype mismatch in psmouse and atkbd.
  
  Signed-off-by: Vojtech Pavlik <vojtech@suse.cz>

ChangeSet@1.1957.1.9, 2004-09-30 01:31:12-05:00, dtor_core@ameritech.net
  Input: psmouse - explicitely specify packet size instead of relying
         on protocol numbering scheme. Make protocol detection routines
         return -1 on failure to keep them consistent with ther rest
         of the code. Set mouse parameters right in detection routines
         instead of doing it in psmouse_extensions.
  
  Signed-off-by: Dmitry Torokhov <dtor@mail.ru>

ChangeSet@1.1957.1.8, 2004-09-30 01:30:25-05:00, dtor_core@ameritech.net
  Input: psmouse - make logips2pp fully decode its protocol packets
         and not rely on generic handler to finish job.
  
  Signed-off-by: Dmitry Torokhov <dtor@mail.ru>

ChangeSet@1.1957.1.7, 2004-09-30 01:28:49-05:00, dtor_core@ameritech.net
  Input: psmouse - drop PS2TPP protocol (it is handled exactly like
         PS2PP) to free spot for THINKPS protocol and keep old protocol
         numbers for binary compatibility with Synaptics/ALPS touchpad
         driver for X.
  
  Signed-off-by: Dmitry Torokhov <dtor@mail.ru>

ChangeSet@1.1957.1.6, 2004-09-30 01:28:03-05:00, dtor_core@ameritech.net
  Input: psmouse - export rate, resolution, resetafter and smartscroll
         (Logitech only) as individual mouse attributes (sysfs) and allow
         them to be set/changed independently for each mouse:
  
           echo -n "100" > /sys/bus/serio/devices/serio0/rate
           echo -n "200" > /sys/bus/serio/devices/serio0/resolution
  
  Signed-off-by: Dmitry Torokhov <dtor@mail.ru>

ChangeSet@1.1957.1.5, 2004-09-30 01:27:24-05:00, dtor_core@ameritech.net
  Input: psmouse - reset mouse before doing intellimouse/explorer
         probes in case it got confused by earlier probes; switch
         to streaming mode before setting scale and resolution,
         otherwise some KVMs get confused.
  
  Patch-by: Marko Macek <Marko.Macek@gmx.net>
  Signed-off-by: Dmitry Torokhov <dtor@mail.ru>

ChangeSet@1.1957.1.4, 2004-09-30 01:26:43-05:00, dtor_core@ameritech.net
  Input: synaptics - not only switch to 4-byte client protocol
         but also revert to 3-byte mode if client selected lower
         protocol.
  
  Signed-off-by: Dmitry Torokhov <dtor@mail.ru> 

ChangeSet@1.1957.1.3, 2004-09-30 01:25:47-05:00, dtor_core@ameritech.net
  Input: psmouse - add set_rate and set_resolution handlers to make
         adding new protocols easier and remove special knowledge
         from psmouse-base.c
  
  Signed-off-by: Dmitry Torokhov <dtor@mail.ru>

ChangeSet@1.1957.1.2, 2004-09-30 01:24:59-05:00, dtor_core@ameritech.net
  Input: add a new signature for ALPS DualPoint found in
         Dell Inspiron 8500
  
  Signed-off-by: Dmitry Torokhov <dtor@mail.ru>

ChangeSet@1.1958, 2004-09-24 12:26:54+02:00, jbglaw@lug-owl.de
  input: More comment fixes in lkkbd.c
  
  Signed-off-by: Jan-Benedict Glaw <jbglaw@lug-owl.de>
  Signed-off-by: Vojtech Pavlik <vojtech@suse.cz>

ChangeSet@1.1957, 2004-09-24 11:40:14+02:00, bjorn.helgaas@hp.com
  Input: Add ACPI-based i8042 keyboard and aux controller enumeration; can be
  disabled by passing i8042.noacpi as a boot parameter.
  
  Original code by Bjorn Helgaas <bjorn.helgaas@hp.com>, reworked by
  Dmitry Torokhov <dtor@mail.ru>, FixedIO support from Hans-Frieder Vogt
  <hfvogt@gmx.net>
  
  Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
  Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
  Signed-off-by: Andrew Morton <akpm@osdl.org>
  Signed-off-by: Vojtech Pavlik <vojtech@suse.cz>

ChangeSet@1.1956, 2004-09-24 11:36:34+02:00, jbglaw@lug-owl.de
  Input: correct the the wrong use of "DB9" to the correct name, "DE9". 
         Also, some comments/debugging output is fixed up.
  
  Signed-off-by: Jan-Benedict Glaw <jbglaw@lug-owl.de>
  Signed-off-by: Andrew Morton <akpm@osdl.org>
  Signed-off-by: Vojtech Pavlik <vojtech@suse.cz>

ChangeSet@1.1955, 2004-09-24 10:30:25+02:00, lenz@cs.wisc.edu
  input: Add LED definitions for PDAs.
  
  Signed-off-by: Vojtech Pavlik <vojtech@suse.cz>
  Signed-off-by: John Lenz <lenz@cs.wisc.edu>

ChangeSet@1.1952, 2004-09-23 13:01:47+02:00, mochel@digitalimplant.org
  input: Remove calls to pm_access() and pm_dev_idle() from input.c, as
         they're empty functions anyway.
  
  Signed-off-by: Vojtech Pavlik <vojtech@suse.cz>
  Patch-by: Patrick Mochel <mochel@digitalimplant.org>

ChangeSet@1.1951, 2004-09-23 12:59:31+02:00, vojtech@suse.cz
  input: Tidy up & fix the hid-input.c driver. Dual-wheel A4 mice don't report the phantom
           button anymore, D-Pads are mapped to Hat-switches, debug can print HID->Input
           mappings, more mappings added, devices with reports larger than MaxPacketSize
           work again.
  
  Signed-off-by: Vojtech Pavlik <vojtech@suse.cz>

ChangeSet@1.1949.1.1, 2004-09-22 22:35:49-05:00, dtor_core@ameritech.net
  Input: clean up ALPS DualPoint logic
  
  Signed-off-by: Dmitry Torokhov <dtor@mail.ru>

ChangeSet@1.1949, 2004-09-22 10:46:32+02:00, vojtech@suse.cz
  input: More IOWarrior blacklist entries in hid.c, rearranging the
         blacklist back to alphabetic order.
  
  Signed-off-by: Vojtech Pavlik <vojtech@suse.cz>

ChangeSet@1.1948, 2004-09-22 01:50:38-05:00, dtor_core@ameritech.net
  Input: atkbd - export extra, scroll, set, softrepeat and softraw as individual
         keyboard attributes (sysfs) and allow them to be set/changed independently
         for each keyboard:
  
         echo -n "2" > /sys/bus/serio/devices/serio1/set
         echo -n "1" > /sys/bus/serio/devices/serio1/softrepeat
  
  Signed-off-by: Dmitry Torokhov <dtor@mail.ru> 

ChangeSet@1.1947, 2004-09-22 01:49:31-05:00, dtor_core@ameritech.net
  Input: add serio_[un]pin_driver() functions so attribute handlers
         can safely access driver bound to a serio port.
  
  Signed-off-by: Dmitry Torokhov <dtor@mail.ru>

ChangeSet@1.1946, 2004-09-22 01:48:40-05:00, dtor_core@ameritech.net
  Input: pull common code from psmouse and atkbd into libps2 module
  
  Signed-off-by: Dmitry Torokhov <dtor@mail.ru>

ChangeSet@1.1945, 2004-09-21 16:12:18+02:00, vojtech@suse.cz
  input: Add AT-compatible rawmode generation for ARM.
  
  Signed-off-by: Vojtech Pavlik <vojtech@suse.cz>
  Patch-by: Woody Suwalski <woodys@xandros.com>

ChangeSet@1.1944, 2004-09-21 15:48:50+02:00, petero2@telia.com
  input: Add ALPS touchpad driver, driver by Neil Brown, Peter Osterlund
         and Dmitry Torokhov, some fixes by Vojtech Pavlik.
  
  Signed-off-by: Vojtech Pavlik <vojtech@suse.cz>
  Patch-by: Peter Osterlund <petero2@telia.com>

ChangeSet@1.1943, 2004-09-21 15:27:54+02:00, pmaydell@chiark.greenend.org.uk
  input: Add support for Kensington ThinkingMouse PS/2 protocol.
  
  Signed-off-by: Vojtech Pavlik <vojtech@suse.cz>
  Patch-by: Peter Maydell <pmaydell@chiark.greenend.org.uk>

ChangeSet@1.1942, 2004-09-21 10:04:06+02:00, vojtech@suse.cz
  input: Some HID devices have problems returning the HID class descriptor.
         Try a few times before giving up.
  
  Signed-off-by: Vojtech Pavlik <vojtech@suse.cz>

ChangeSet@1.1940, 2004-09-21 09:24:21+02:00, pnelson@suse.cz
  input: Fix oops in gamecon
  
  Signed-off-by: Vojtech Pavlik <vojtech@suse.cz>
  Patch-by: Peter Nelson <pnelson@andrew.cmu.edu>

ChangeSet@1.1939, 2004-09-19 13:46:50+02:00, olh@suse.de
  input: Joydump depends on gameport
  
  Signed-off-by: Vojtech Pavlik <vojtech@suse.cz>
  Patch-by: Olaf Hering <olh@suse.de>


-- 
Vojtech Pavlik
SuSE Labs, SuSE CR

Re: [bk patches] Long delayed input update

[Dmitry Torokhov]

On Monday 27 December 2004 09:28 am, Vojtech Pavlik wrote:
> ChangeSet@1.1957.1.21, 2004-10-21 23:52:36-05:00, dtor_core@ameritech.net
> ? Input: i8042 - allow turning debugging on and off "on-fly"
> ? ? ? ? ?so people do not have to recompile their kernels to
> ? ? ? ? ?provide debug info.
> ? 
> ? ? ? ? ?Adds new parameter i8042.debug also accessible through
> ? ? ? ? ?sysfs. 
> ? 
> ? Signed-off-by: Dmitry Torokhov <dtor@mail.ru>

Hi,

This one needs the patch below to correct permissions braindamage.

-- 
Dmitry


===================================================================


ChangeSet@1.1968, 2004-11-25 00:33:20-05:00, dtor_core@ameritech.net
  Input: i8042 - fix "debug" parameter sysfs permissions.
  
  Signed-off-by: Dmitry Torokhov <dtor@mail.ru>


 i8042.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)


===================================================================



diff -Nru a/drivers/input/serio/i8042.c b/drivers/input/serio/i8042.c
--- a/drivers/input/serio/i8042.c	2004-11-25 01:27:15 -05:00
+++ b/drivers/input/serio/i8042.c	2004-11-25 01:27:15 -05:00
@@ -68,7 +68,7 @@
 #define DEBUG
 #ifdef DEBUG
 static int i8042_debug;
-module_param_named(debug, i8042_debug, bool, 600);
+module_param_named(debug, i8042_debug, bool, 0600);
 MODULE_PARM_DESC(debug, "Turn i8042 debugging mode on and off");
 #endif
 

Re: [bk patches] Long delayed input update

[Vojtech Pavlik]

On Mon, Dec 27, 2004 at 02:19:43PM -0500, Dmitry Torokhov wrote:
> On Monday 27 December 2004 09:28 am, Vojtech Pavlik wrote:
> > ChangeSet@1.1957.1.21, 2004-10-21 23:52:36-05:00, dtor_core@ameritech.net
> > ? Input: i8042 - allow turning debugging on and off "on-fly"
> > ? ? ? ? ?so people do not have to recompile their kernels to
> > ? ? ? ? ?provide debug info.
> > ? 
> > ? ? ? ? ?Adds new parameter i8042.debug also accessible through
> > ? ? ? ? ?sysfs. 
> > ? 
> > ? Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
> 
> Hi,
> 
> This one needs the patch below to correct permissions braindamage.

Applied. Linus, please pull now.

> ===================================================================
> 
> 
> ChangeSet@1.1968, 2004-11-25 00:33:20-05:00, dtor_core@ameritech.net
>   Input: i8042 - fix "debug" parameter sysfs permissions.
>   
>   Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
> 
> 
>  i8042.c |    2 +-
>  1 files changed, 1 insertion(+), 1 deletion(-)
> 
> 
> ===================================================================
> 
> 
> 
> diff -Nru a/drivers/input/serio/i8042.c b/drivers/input/serio/i8042.c
> --- a/drivers/input/serio/i8042.c	2004-11-25 01:27:15 -05:00
> +++ b/drivers/input/serio/i8042.c	2004-11-25 01:27:15 -05:00
> @@ -68,7 +68,7 @@
>  #define DEBUG
>  #ifdef DEBUG
>  static int i8042_debug;
> -module_param_named(debug, i8042_debug, bool, 600);
> +module_param_named(debug, i8042_debug, bool, 0600);
>  MODULE_PARM_DESC(debug, "Turn i8042 debugging mode on and off");
>  #endif

-- 
Vojtech Pavlik
SuSE Labs, SuSE CR

Re: [bk patches] Long delayed input update

[Linus Torvalds]

I pulled and immediately unpulled again.

Vojtech, stuff like this is unacceptable:

	PS/2 driver library (SERIO_LIBPS2) [N/m/y/?] (NEW) ?

	Say Y here if you are using a driver for device connected
	to a PS/2 port, such as PS/2 mouse or standard AT keyboard.

Stop messing with peoples minds. The default config should contain
keyboard and mouse support, and unless the user asks for "Embedded" or the
year 2010 comes along and you can't find computers with non-USB keyboards
anyway, that's how it's going to remain.

We had this _idiocy_ early in 2.5.x, and it caused untold silly problems. 
We fixed it. We're not going to re-do that mistake.

Please re-do your BK tree without this. Also, considering that every
_single_ time we've messed with the legacy keyboard/mouse controller there
have been compatibility problems, I want to know what the advantages are.  
Does the work actually _fix_ anything, and has it in any way been tested
on the millions of different versions of kbd controller clones out there?

		Linus

Re: [bk patches] Long delayed input update

[Dmitry Torokhov]

On Tuesday 04 January 2005 12:54 am, Linus Torvalds wrote:
> 
> I pulled and immediately unpulled again.
> 
> Vojtech, stuff like this is unacceptable:
> 
> 	PS/2 driver library (SERIO_LIBPS2) [N/m/y/?] (NEW) ?
> 
> 	Say Y here if you are using a driver for device connected
> 	to a PS/2 port, such as PS/2 mouse or standard AT keyboard.
> 
> Stop messing with peoples minds. The default config should contain
> keyboard and mouse support, and unless the user asks for "Embedded" or the
> year 2010 comes along and you can't find computers with non-USB keyboards
> anyway, that's how it's going to remain.
> 
> We had this _idiocy_ early in 2.5.x, and it caused untold silly problems. 
> We fixed it. We're not going to re-do that mistake.
> 

When I do "make oldconfig" it silently sets SERIO_LIBPS2 to Y if I have
either atkbd or psmouse built-in and if both of them are modules it gives
option [M/y]. Do you have atkbd or psmouse selected?

> Please re-do your BK tree without this. Also, considering that every
> _single_ time we've messed with the legacy keyboard/mouse controller there
> have been compatibility problems, I want to know what the advantages are.  

It folds sizeable chunks of the same code from atkbd and psmouse so for ease
of maintenance.

-- 
Dmitry

Re: [bk patches] Long delayed input update

[Vojtech Pavlik]

On Mon, Jan 03, 2005 at 09:54:33PM -0800, Linus Torvalds wrote:

> I pulled and immediately unpulled again.
> 
> Vojtech, stuff like this is unacceptable:
> 
> 	PS/2 driver library (SERIO_LIBPS2) [N/m/y/?] (NEW) ?
> 
> 	Say Y here if you are using a driver for device connected
> 	to a PS/2 port, such as PS/2 mouse or standard AT keyboard.
> 
> Stop messing with peoples minds. The default config should contain
> keyboard and mouse support, and unless the user asks for "Embedded" or the
> year 2010 comes along and you can't find computers with non-USB keyboards
> anyway, that's how it's going to remain.

What machine this was on? Kernel config won't allow you to unselect that
option if AT Keyboard is selected, and that's always selected when
CONFIG_PC is.

> We had this _idiocy_ early in 2.5.x, and it caused untold silly problems. 
> We fixed it. We're not going to re-do that mistake.
> Please re-do your BK tree without this

I tested it then, and now again. And I can't get the prompt you're
getting.

	$ bk clone linus test
	$ cd test
	$ bk -r get
	$ make defconfig
	$ bk pull ../input
	$ make oldconfig

doesn't ask ANY questions.

I can imagine that option being asked about on a Mac, but there it might
make sense, or at least cause no harm if you enable it, even if it's
not needed.

> Also, considering that every
> _single_ time we've messed with the legacy keyboard/mouse controller there
> have been compatibility problems, I want to know what the advantages are.  

The changes to the keyboard/mouse controller code (i8042.c) are added
powermanagement callbacks, which are very much needed, and added ACPI
probing, which, although not strictly needed, is a less intrusive way of
detecting whether a kbd/mouse controller is present.

Regarding libps2, that doesn't touch the controller code itself, only
the mouse and keyboard drivers. It's a refactoring of the code,
eliminating a bunch of duplicate code which had a tendency of diverging
and that was causing problems. It shouldn't change any functionality per
se.

> Does the work actually _fix_ anything,

The refactoring itself didn't fix any problems, and it wasn't intended
to, but it uncovered some bugs that when fixed, made real problems go
away, like the ACK timeouts in RESET_BAT code path.

> and has it in any way been tested on the millions of different
> versions of kbd controller clones out there?

Does a few months in Andrew's tree count?

-- 
Vojtech Pavlik
SuSE Labs, SuSE CR

Re: [bk patches] Long delayed input update

[Adrian Bunk]

On Tue, Jan 04, 2005 at 01:14:26AM -0500, Dmitry Torokhov wrote:
> On Tuesday 04 January 2005 12:54 am, Linus Torvalds wrote:
> > 
> > I pulled and immediately unpulled again.
> > 
> > Vojtech, stuff like this is unacceptable:
> > 
> > 	PS/2 driver library (SERIO_LIBPS2) [N/m/y/?] (NEW) ?
> > 
> > 	Say Y here if you are using a driver for device connected
> > 	to a PS/2 port, such as PS/2 mouse or standard AT keyboard.
> > 
> > Stop messing with peoples minds. The default config should contain
> > keyboard and mouse support, and unless the user asks for "Embedded" or the
> > year 2010 comes along and you can't find computers with non-USB keyboards
> > anyway, that's how it's going to remain.
> > 
> > We had this _idiocy_ early in 2.5.x, and it caused untold silly problems. 
> > We fixed it. We're not going to re-do that mistake.
> 
> When I do "make oldconfig" it silently sets SERIO_LIBPS2 to Y if I have
> either atkbd or psmouse built-in and if both of them are modules it gives
> option [M/y]. Do you have atkbd or psmouse selected?
>...

As far as I can see, you are correct, and unless you are on !X86 or have 
EMBEDDED enabled SERIO_LIBPS2 is always forced to yes.

But although it doesn't seem to be a problem, I'm wondering why 
SERIO_LIBPS2 is a user-visible option?

> Dmitry

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: [bk patches] Long delayed input update

[Dmitry Torokhov]

On Tue, 4 Jan 2005 15:50:11 +0100, Adrian Bunk <bunk@stusta.de> wrote:
> On Tue, Jan 04, 2005 at 01:14:26AM -0500, Dmitry Torokhov wrote:
> > When I do "make oldconfig" it silently sets SERIO_LIBPS2 to Y if I have
> > either atkbd or psmouse built-in and if both of them are modules it gives
> > option [M/y]. Do you have atkbd or psmouse selected?
> >...
> 
> As far as I can see, you are correct, and unless you are on !X86 or have
> EMBEDDED enabled SERIO_LIBPS2 is always forced to yes.
> 
> But although it doesn't seem to be a problem, I'm wondering why
> SERIO_LIBPS2 is a user-visible option?
> 

LIBPS2 is a mid-level library for accessing a device behing PS/2 port.
Like with CRC library there potentially could be some out-of-tree
moules using it so user has an option of building the library in the
kernel, or as a module, or omitting it.

For the vast majority of users it is selected automatically without any
questions.

-- 
Dmitry

Re: [bk patches] Long delayed input update

[Linus Torvalds]

On Tue, 4 Jan 2005, Vojtech Pavlik wrote:
> 
> What machine this was on? Kernel config won't allow you to unselect that
> option if AT Keyboard is selected, and that's always selected when
> CONFIG_PC is.

Ahh. It's a G5 mac, so I guess it isn't needed. Even so, that thing 
shouldn't show up. If I don't have AT keyboard _or_ mouse selected, it 
shouldn't be there - they should "select" it, and if nothing uses it, then 
there isn't anything to do. In no case should it show up as a question.

> > and has it in any way been tested on the millions of different
> > versions of kbd controller clones out there?
> 
> Does a few months in Andrew's tree count?

So it has been part of the -mm tree? Good.

		Linus

Re: [bk patches] Long delayed input update

[Vojtech Pavlik]

On Tue, Jan 04, 2005 at 07:58:50AM -0800, Linus Torvalds wrote:

> > What machine this was on? Kernel config won't allow you to unselect that
> > option if AT Keyboard is selected, and that's always selected when
> > CONFIG_PC is.

> Ahh. It's a G5 mac, so I guess it isn't needed. Even so, that thing 
> shouldn't show up. If I don't have AT keyboard _or_ mouse selected, it 
> shouldn't be there - they should "select" it, and if nothing uses it, then 
> there isn't anything to do. In no case should it show up as a question.

I can hide it, the reasoning was that it may be useful for out-of-kernel
modules, and because of that it's possible to enable it even when there
are no users, and only then it's an option.

atkbd and psmouse do "select" it.

> > > and has it in any way been tested on the millions of different
> > > versions of kbd controller clones out there?
> > 
> > Does a few months in Andrew's tree count?
> 
> So it has been part of the -mm tree? Good.

Yes.

-- 
Vojtech Pavlik
SuSE Labs, SuSE CR

Re: [bk patches] Long delayed input update

[Linus Torvalds]

On Tue, 4 Jan 2005, Vojtech Pavlik wrote:
> 
> I can hide it, the reasoning was that it may be useful for out-of-kernel
> modules, and because of that it's possible to enable it even when there
> are no users, and only then it's an option.
> 
> atkbd and psmouse do "select" it.

Ok, that seems fine. I'll hide it behind "EMBEDDED" at least until 
somebody actually has an out-of-tree user on any platform where it makes 
any sense (on a PC it will be enabled _anyway_ by the kbd/mouse thing, and 
on anything else I don't see it making any sense anyway, and it clearly 
only confuses people - since it confused me).

> > So it has been part of the -mm tree? Good.
> 
> Yes.

Ok. I'll re-pull and make it embedded to make that irritating question go 
away.

		Linus

Re: [bk patches] Long delayed input update

[Christoph Hellwig]

On Tue, Jan 04, 2005 at 07:58:50AM -0800, Linus Torvalds wrote:
> Ahh. It's a G5 mac, so I guess it isn't needed. Even so, that thing 
> shouldn't show up. If I don't have AT keyboard _or_ mouse selected, it 
> shouldn't be there - they should "select" it, and if nothing uses it, then 
> there isn't anything to do. In no case should it show up as a question.

Compiling in PC keyboard controller support will actually crash your
shiny G5 mac ;-)

Re: [bk patches] Long delayed input update

[Dmitry Torokhov]

On Tue, 4 Jan 2005 08:14:52 -0800 (PST), Linus Torvalds
<torvalds@osdl.org> wrote:
> 
> 
> On Tue, 4 Jan 2005, Vojtech Pavlik wrote:
> >
> > I can hide it, the reasoning was that it may be useful for out-of-kernel
> > modules, and because of that it's possible to enable it even when there
> > are no users, and only then it's an option.
> >
> > atkbd and psmouse do "select" it.
> 
> Ok, that seems fine. I'll hide it behind "EMBEDDED" at least until
> somebody actually has an out-of-tree user on any platform where it makes
> any sense (on a PC it will be enabled _anyway_ by the kbd/mouse thing, and
> on anything else I don't see it making any sense anyway, and it clearly
> only confuses people - since it confused me).
> 

i8042-style ports are not limited to PC - maceps2.c, q40kbd.c,
rpckbd.c and sa1111ps2.c also implement them that's why libps2 wasn't
limited to x86 arch.

-- 
Dmitry

Re: [bk patches] Long delayed input update

[Vojtech Pavlik]

On Tue, Jan 04, 2005 at 08:14:52AM -0800, Linus Torvalds wrote:

> On Tue, 4 Jan 2005, Vojtech Pavlik wrote:
> > 
> > I can hide it, the reasoning was that it may be useful for out-of-kernel
> > modules, and because of that it's possible to enable it even when there
> > are no users, and only then it's an option.
> > 
> > atkbd and psmouse do "select" it.
> 
> Ok, that seems fine. I'll hide it behind "EMBEDDED" at least until 
> somebody actually has an out-of-tree user on any platform where it makes 
> any sense (on a PC it will be enabled _anyway_ by the kbd/mouse thing, and 
> on anything else I don't see it making any sense anyway, and it clearly 
> only confuses people - since it confused me).

Ok.

> > > So it has been part of the -mm tree? Good.
> > 
> > Yes.
> 
> Ok. I'll re-pull and make it embedded to make that irritating question go 
> away.
 
Thanks.

-- 
Vojtech Pavlik
SuSE Labs, SuSE CR

Re: [bk patches] Long delayed input update

[Dmitry Torokhov]

On Tue, 4 Jan 2005 17:40:25 +0100, Vojtech Pavlik <vojtech@suse.cz> wrote:
> On Tue, Jan 04, 2005 at 08:14:52AM -0800, Linus Torvalds wrote:
> 
> > Ok. I'll re-pull and make it embedded to make that irritating question go
> > away.
> 
> Thanks.
> 

Ok, now only couple of things were left out:

http://marc.theaimsgroup.com/?l=linux-kernel&m=110430679525030&w=2
08-atkbd-keycode-size.patch
	Fix keycode table size initialization that got broken by my changes
	that exported 'set' and other settings via sysfs.
	setkeycodes should work again now.

http://marc.theaimsgroup.com/?l=linux-kernel&m=110430749420252&w=2
06-ps2pp-mouse-name.patch
	Set mouse name to "Mouse" instead of leaving it NULL when using
	PS2++ protocol and don't have any other information (Wheel, Touchpad)
	about the mouse.

06 is not too critical but without 08 setkeycodes will not work.

In any case I'd like the following patches (01-08, see
http://marc.theaimsgroup.com/?l=linux-kernel&m=110430597110513&w=2) to
be moved forward as they were also staged in -mm tree for over a month
and work fine on my 3 boxes.

-- 
Dmitry

Re: [bk patches] Long delayed input update

[Vojtech Pavlik]

On Tue, Jan 04, 2005 at 12:22:17PM -0500, Dmitry Torokhov wrote:
> On Tue, 4 Jan 2005 17:40:25 +0100, Vojtech Pavlik <vojtech@suse.cz> wrote:
> > On Tue, Jan 04, 2005 at 08:14:52AM -0800, Linus Torvalds wrote:
> > 
> > > Ok. I'll re-pull and make it embedded to make that irritating question go
> > > away.
> > 
> > Thanks.
> > 
> 
> Ok, now only couple of things were left out:
> 
> http://marc.theaimsgroup.com/?l=linux-kernel&m=110430679525030&w=2
> 08-atkbd-keycode-size.patch
> 	Fix keycode table size initialization that got broken by my changes
> 	that exported 'set' and other settings via sysfs.
> 	setkeycodes should work again now.
> 
> http://marc.theaimsgroup.com/?l=linux-kernel&m=110430749420252&w=2
> 06-ps2pp-mouse-name.patch
> 	Set mouse name to "Mouse" instead of leaving it NULL when using
> 	PS2++ protocol and don't have any other information (Wheel, Touchpad)
> 	about the mouse.
> 
> 06 is not too critical but without 08 setkeycodes will not work.
> 
> In any case I'd like the following patches (01-08, see
> http://marc.theaimsgroup.com/?l=linux-kernel&m=110430597110513&w=2) to
> be moved forward as they were also staged in -mm tree for over a month
> and work fine on my 3 boxes.
 
OK, I'll merge them, and prepare yet another pull for Linus.

-- 
Vojtech Pavlik
SuSE Labs, SuSE CR

Re: [bk patches] Long delayed input update

[Linus Torvalds]

On Tue, 4 Jan 2005, Dmitry Torokhov wrote:
> 
> i8042-style ports are not limited to PC - maceps2.c, q40kbd.c,
> rpckbd.c and sa1111ps2.c also implement them that's why libps2 wasn't
> limited to x86 arch.

So?

If you select ATKBD then LIBPS2 should be selected _automatically_.

My point is that there is _never_ a reason to ask about it. Ever.

I'll let crazy people select EMBEDDED if they want to see the question, 
but even that is in my opinion likely unnecessary.

		Linus

Re: [bk patches] Long delayed input update

[Dmitry Torokhov]

On Tue, 4 Jan 2005 10:03:19 -0800 (PST), Linus Torvalds
<torvalds@osdl.org> wrote:
> 
> 
> On Tue, 4 Jan 2005, Dmitry Torokhov wrote:
> >
> > i8042-style ports are not limited to PC - maceps2.c, q40kbd.c,
> > rpckbd.c and sa1111ps2.c also implement them that's why libps2 wasn't
> > limited to x86 arch.
> 
> So?
>

I was referring to your statement that on PCs it is selected
automatically as if only PC can use libps2.
 
> If you select ATKBD then LIBPS2 should be selected _automatically_.
> 
> My point is that there is _never_ a reason to ask about it. Ever.

I'll code some tiny PS/2 driver and will keep it out of the tree just
to prove you wrong ;)

-- 
Dmitry