* drivers/mmc/wbsd.c
@ 2005-01-06 3:47 Andrew Morton
2005-01-10 9:17 ` drivers/mmc/wbsd.c Pierre Ossman
0 siblings, 1 reply; 2+ messages in thread
From: Andrew Morton @ 2005-01-06 3:47 UTC (permalink / raw)
To: Russell King; +Cc: Pierre Ossman, linux-kernel
static inline void wbsd_kunmap_sg(struct wbsd_host* host)
{
kunmap_atomic(host->cur_sg->page, KM_BIO_SRC_IRQ);
}
Guys, kunmap_atomic() takes a kernel virtual address (the value which
kmap_atomic() returned).
Passing it the address of a pageframe will have unpleasant results.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: drivers/mmc/wbsd.c
2005-01-06 3:47 drivers/mmc/wbsd.c Andrew Morton
@ 2005-01-10 9:17 ` Pierre Ossman
0 siblings, 0 replies; 2+ messages in thread
From: Pierre Ossman @ 2005-01-10 9:17 UTC (permalink / raw)
To: Andrew Morton; +Cc: Russell King, linux-kernel
Andrew Morton wrote:
>static inline void wbsd_kunmap_sg(struct wbsd_host* host)
>{
> kunmap_atomic(host->cur_sg->page, KM_BIO_SRC_IRQ);
>}
>
>Guys, kunmap_atomic() takes a kernel virtual address (the value which
>kmap_atomic() returned).
>
>Passing it the address of a pageframe will have unpleasant results.
>
>
Thanks. kunmap_atomic() just messes with the preemption stuff (on x86 at
least) so it probably would have gone unnoticed for a while.
I've fixed it now and it will be included in the next patch set.
Rgds
Pierre
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-01-10 9:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-01-06 3:47 drivers/mmc/wbsd.c Andrew Morton
2005-01-10 9:17 ` drivers/mmc/wbsd.c Pierre Ossman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).