* [PATCH] fix double sync_page_range() in generic_file_aio_write()
@ 2005-01-04 14:39 Oleg Nesterov
2005-01-07 7:10 ` Suparna Bhattacharya
0 siblings, 1 reply; 2+ messages in thread
From: Oleg Nesterov @ 2005-01-04 14:39 UTC (permalink / raw)
To: linux-kernel; +Cc: Suparna Bhattacharya, Andrew Morton, Linus Torvalds
Hello.
generic_file_aio_write():
generic_file_aio_write_nolock():
if (SYNC) sync_page_range_nolock();
if (SYNC) sync_page_range();
I think that generic_file_aio_write() should use
__generic_file_aio_write_nolock() instead.
Oleg.
Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
--- 2.6.10/mm/filemap.c~ 2004-11-15 17:12:21.000000000 +0300
+++ 2.6.10/mm/filemap.c 2005-01-04 20:20:42.068803912 +0300
@@ -2149,7 +2149,7 @@ ssize_t generic_file_aio_write(struct ki
BUG_ON(iocb->ki_pos != pos);
down(&inode->i_sem);
- ret = generic_file_aio_write_nolock(iocb, &local_iov, 1,
+ ret = __generic_file_aio_write_nolock(iocb, &local_iov, 1,
&iocb->ki_pos);
up(&inode->i_sem);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] fix double sync_page_range() in generic_file_aio_write()
2005-01-04 14:39 [PATCH] fix double sync_page_range() in generic_file_aio_write() Oleg Nesterov
@ 2005-01-07 7:10 ` Suparna Bhattacharya
0 siblings, 0 replies; 2+ messages in thread
From: Suparna Bhattacharya @ 2005-01-07 7:10 UTC (permalink / raw)
To: Oleg Nesterov; +Cc: linux-kernel, Andrew Morton, Linus Torvalds
Sorry I missed this one - Thanks for spotting it !
Regards
Suparna
On Tue, Jan 04, 2005 at 05:39:15PM +0300, Oleg Nesterov wrote:
> Hello.
>
> generic_file_aio_write():
> generic_file_aio_write_nolock():
> if (SYNC) sync_page_range_nolock();
> if (SYNC) sync_page_range();
>
> I think that generic_file_aio_write() should use
> __generic_file_aio_write_nolock() instead.
>
> Oleg.
>
> Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
>
> --- 2.6.10/mm/filemap.c~ 2004-11-15 17:12:21.000000000 +0300
> +++ 2.6.10/mm/filemap.c 2005-01-04 20:20:42.068803912 +0300
> @@ -2149,7 +2149,7 @@ ssize_t generic_file_aio_write(struct ki
> BUG_ON(iocb->ki_pos != pos);
>
> down(&inode->i_sem);
> - ret = generic_file_aio_write_nolock(iocb, &local_iov, 1,
> + ret = __generic_file_aio_write_nolock(iocb, &local_iov, 1,
> &iocb->ki_pos);
> up(&inode->i_sem);
--
Suparna Bhattacharya (suparna@in.ibm.com)
Linux Technology Center
IBM Software Lab, India
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-01-07 7:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-01-04 14:39 [PATCH] fix double sync_page_range() in generic_file_aio_write() Oleg Nesterov
2005-01-07 7:10 ` Suparna Bhattacharya
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).