From: Francois Romieu <romieu@fr.zoreil.com>
To: Adam Anthony <AAnthony@sbs.com>
Cc: Matthias-Christian Ott <matthias.christian@tiscali.de>,
Alexey Dobriyan <adobriyan@mail.ru>,
netdev@oss.sgi.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] /driver/net/wan/sbs520
Date: Mon, 10 Jan 2005 21:29:47 +0100 [thread overview]
Message-ID: <20050110202947.GA31426@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <4F23E557A0317D45864097982DE907941A3383@pilotmail.sbscorp.sbs.com>
Adam Anthony <AAnthony@sbs.com> :
> Thank you for the heads up A&M. I have destroyed the evil [^M]'s, and
> updated the package.
> http://prdownloads.sourceforge.net/sbs520lnxdrv/sbs520patch.bz2?download
o OsMapPhysToVirt
-> should be ioremap/pci_iomap()
o OsUnMapVirt
-> iounmap, etc.
o OsAllocateNonPagedMemory/OsMemcpy/OsStall/OsSleep/OsZeroMem
-> useless wrappers.
o OsAllocateDeviceMemory
Yuck, virt_to_bus !
Please read:
- linux-2.6.x/Documentation/DMA-mapping.txt
- linux-2.6.x/Documentation/DMA-API.txt
drivers/net/*.c provides a lot of good examples for recent PCI
devices.
o OsReadPciConfiguration
Please see pci_resource_{start/len} and friends.
At this point, lnxosl.c will be removable and nobody will regret it.
--
Ueimor
next prev parent reply other threads:[~2005-01-10 20:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-10 19:49 [PATCH] /driver/net/wan/sbs520 Adam Anthony
2005-01-10 20:11 ` Stephen Hemminger
2005-01-10 20:29 ` Francois Romieu [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-01-10 20:49 Adam Anthony
2005-01-10 17:47 Alexey Dobriyan
2005-01-10 17:26 ` Matthias-Christian Ott
2005-01-10 14:46 Adam Anthony
2005-01-10 18:00 ` Francois Romieu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050110202947.GA31426@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=AAnthony@sbs.com \
--cc=adobriyan@mail.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=matthias.christian@tiscali.de \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).