* [patch 1/1] ide-tape: replace schedule_timeout() with msleep()
@ 2005-01-11 23:16 domen
0 siblings, 0 replies; only message in thread
From: domen @ 2005-01-11 23:16 UTC (permalink / raw)
To: gadio; +Cc: linux-kernel, domen, nacc, janitor
I would appreciate any comments from the janitor@sternweltens list. This is one (of
many) cases where I made a decision about replacing
set_current_state(TASK_INTERRUPTIBLE);
schedule_timeout(some_time);
with
msleep(jiffies_to_msecs(some_time));
msleep() is not exactly the same as the previous code, but I only did
this replacement where I thought long delays were *desired*. If this is
not the case here, then just disregard this patch.
Thanks,
Nish
Description: Uses msleep() instead of schedule_timeout() to guarantee
the task delays at least the desired time amount.
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
Signed-off-by: Maximilian Attems <janitor@sternwelten.at>
Signed-off-by: Domen Puncer <domen@coderock.org>
---
kj-domen/drivers/ide/ide-tape.c | 3 +--
1 files changed, 1 insertion(+), 2 deletions(-)
diff -puN drivers/ide/ide-tape.c~msleep-drivers_ide_ide-tape drivers/ide/ide-tape.c
--- kj/drivers/ide/ide-tape.c~msleep-drivers_ide_ide-tape 2005-01-10 17:59:47.000000000 +0100
+++ kj-domen/drivers/ide/ide-tape.c 2005-01-10 17:59:47.000000000 +0100
@@ -2854,8 +2854,7 @@ static int idetape_wait_ready(ide_drive_
} else if (!(tape->sense_key == 2 && tape->asc == 4 &&
(tape->ascq == 1 || tape->ascq == 8)))
return -EIO;
- current->state = TASK_INTERRUPTIBLE;
- schedule_timeout(HZ / 10);
+ msleep(100);
}
return -EIO;
}
_
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2005-01-11 23:16 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-01-11 23:16 [patch 1/1] ide-tape: replace schedule_timeout() with msleep() domen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).