* debugfs directory structure
@ 2005-01-12 20:50 Roland Dreier
2005-01-12 21:01 ` Greg KH
2005-01-12 21:09 ` Dave Jones
0 siblings, 2 replies; 6+ messages in thread
From: Roland Dreier @ 2005-01-12 20:50 UTC (permalink / raw)
To: greg; +Cc: linux-kernel, openib-general
Hi Greg,
Now that debugfs is merged into Linus's tree, I'm looking at using it
to replace the IPoIB debugging pseudo-filesystem (ipoib_debugfs). Is
there any guidance on what the structure of debugfs should look like?
Right now I'm planning on putting all the debug info files under an
ipoib/ top level directory. Does that sound reasonable?
Thanks,
Roland
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: debugfs directory structure
2005-01-12 20:50 debugfs directory structure Roland Dreier
@ 2005-01-12 21:01 ` Greg KH
2005-01-12 21:09 ` Dave Jones
1 sibling, 0 replies; 6+ messages in thread
From: Greg KH @ 2005-01-12 21:01 UTC (permalink / raw)
To: Roland Dreier; +Cc: linux-kernel, openib-general
On Wed, Jan 12, 2005 at 12:50:51PM -0800, Roland Dreier wrote:
> Hi Greg,
>
> Now that debugfs is merged into Linus's tree, I'm looking at using it
> to replace the IPoIB debugging pseudo-filesystem (ipoib_debugfs).
Great!
> Is
> there any guidance on what the structure of debugfs should look like?
> Right now I'm planning on putting all the debug info files under an
> ipoib/ top level directory. Does that sound reasonable?
Anarchy rules in debugfs. Do what you want. If you stomp over someone
else's stuff, I expect complaints and maybe someone will have to
arbitrate, but odds are that will ever happen is pretty slim.
So yes, ipoib/ in the top level sounds just fine.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: debugfs directory structure
2005-01-12 20:50 debugfs directory structure Roland Dreier
2005-01-12 21:01 ` Greg KH
@ 2005-01-12 21:09 ` Dave Jones
2005-01-12 21:41 ` Greg KH
1 sibling, 1 reply; 6+ messages in thread
From: Dave Jones @ 2005-01-12 21:09 UTC (permalink / raw)
To: Roland Dreier; +Cc: greg, linux-kernel, openib-general
On Wed, Jan 12, 2005 at 12:50:51PM -0800, Roland Dreier wrote:
> Hi Greg,
>
> Now that debugfs is merged into Linus's tree, I'm looking at using it
> to replace the IPoIB debugging pseudo-filesystem (ipoib_debugfs). Is
> there any guidance on what the structure of debugfs should look like?
> Right now I'm planning on putting all the debug info files under an
> ipoib/ top level directory. Does that sound reasonable?
How about mirroring the toplevel kernel source structure ?
Ie, you'd make drivers/infiniband/ulp/ipoib ?
It could get ugly quickly without some structure at least to
the toplevel dir.
Dave
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: debugfs directory structure
2005-01-12 21:09 ` Dave Jones
@ 2005-01-12 21:41 ` Greg KH
2005-01-12 22:01 ` Dave Jones
0 siblings, 1 reply; 6+ messages in thread
From: Greg KH @ 2005-01-12 21:41 UTC (permalink / raw)
To: Dave Jones, Roland Dreier, linux-kernel, openib-general
On Wed, Jan 12, 2005 at 04:09:45PM -0500, Dave Jones wrote:
> On Wed, Jan 12, 2005 at 12:50:51PM -0800, Roland Dreier wrote:
> > Hi Greg,
> >
> > Now that debugfs is merged into Linus's tree, I'm looking at using it
> > to replace the IPoIB debugging pseudo-filesystem (ipoib_debugfs). Is
> > there any guidance on what the structure of debugfs should look like?
> > Right now I'm planning on putting all the debug info files under an
> > ipoib/ top level directory. Does that sound reasonable?
>
> How about mirroring the toplevel kernel source structure ?
>
> Ie, you'd make drivers/infiniband/ulp/ipoib ?
But who would be in charge of createing the "drivers/" subdirectory?
debugfs can't handle "/" in a directory name, like procfs does.
> It could get ugly quickly without some structure at least to
> the toplevel dir.
I say ipoib/ is fine, remember, this is for debugging stuff, it will
quickly get ugly anyway :)
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: debugfs directory structure
2005-01-12 21:41 ` Greg KH
@ 2005-01-12 22:01 ` Dave Jones
2005-01-12 22:16 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Dave Jones @ 2005-01-12 22:01 UTC (permalink / raw)
To: Greg KH; +Cc: Roland Dreier, linux-kernel, openib-general
On Wed, Jan 12, 2005 at 01:41:08PM -0800, Greg KH wrote:
> On Wed, Jan 12, 2005 at 04:09:45PM -0500, Dave Jones wrote:
> > On Wed, Jan 12, 2005 at 12:50:51PM -0800, Roland Dreier wrote:
> > > Hi Greg,
> > >
> > > Now that debugfs is merged into Linus's tree, I'm looking at using it
> > > to replace the IPoIB debugging pseudo-filesystem (ipoib_debugfs). Is
> > > there any guidance on what the structure of debugfs should look like?
> > > Right now I'm planning on putting all the debug info files under an
> > > ipoib/ top level directory. Does that sound reasonable?
> >
> > How about mirroring the toplevel kernel source structure ?
> >
> > Ie, you'd make drivers/infiniband/ulp/ipoib ?
>
> But who would be in charge of createing the "drivers/" subdirectory?
> debugfs can't handle "/" in a directory name, like procfs does.
maybe it should ?
> > It could get ugly quickly without some structure at least to
> > the toplevel dir.
> I say ipoib/ is fine, remember, this is for debugging stuff, it will
> quickly get ugly anyway :)
with no heirarchy, what happens when two drivers want to make
the same directory / filenames ?
Dave
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: debugfs directory structure
2005-01-12 22:01 ` Dave Jones
@ 2005-01-12 22:16 ` Greg KH
0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2005-01-12 22:16 UTC (permalink / raw)
To: Dave Jones, Roland Dreier, linux-kernel, openib-general
On Wed, Jan 12, 2005 at 05:01:43PM -0500, Dave Jones wrote:
> On Wed, Jan 12, 2005 at 01:41:08PM -0800, Greg KH wrote:
> > On Wed, Jan 12, 2005 at 04:09:45PM -0500, Dave Jones wrote:
> > > On Wed, Jan 12, 2005 at 12:50:51PM -0800, Roland Dreier wrote:
> > > > Hi Greg,
> > > >
> > > > Now that debugfs is merged into Linus's tree, I'm looking at using it
> > > > to replace the IPoIB debugging pseudo-filesystem (ipoib_debugfs). Is
> > > > there any guidance on what the structure of debugfs should look like?
> > > > Right now I'm planning on putting all the debug info files under an
> > > > ipoib/ top level directory. Does that sound reasonable?
> > >
> > > How about mirroring the toplevel kernel source structure ?
> > >
> > > Ie, you'd make drivers/infiniband/ulp/ipoib ?
> >
> > But who would be in charge of createing the "drivers/" subdirectory?
> > debugfs can't handle "/" in a directory name, like procfs does.
>
> maybe it should ?
Right now debugfs is dentry based, not string based. If someone wants
to send me patches to change it, I'll reconsider it :)
> > > It could get ugly quickly without some structure at least to
> > > the toplevel dir.
> > I say ipoib/ is fine, remember, this is for debugging stuff, it will
> > quickly get ugly anyway :)
>
> with no heirarchy, what happens when two drivers want to make
> the same directory / filenames ?
The second call will fail. Code should always check return values,
right?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2005-01-13 1:52 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-01-12 20:50 debugfs directory structure Roland Dreier
2005-01-12 21:01 ` Greg KH
2005-01-12 21:09 ` Dave Jones
2005-01-12 21:41 ` Greg KH
2005-01-12 22:01 ` Dave Jones
2005-01-12 22:16 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).