* [2.6 patch] i386/x86_64: acpi/sleep.c: kill unused acpi_save_state_disk
@ 2005-01-16 7:39 Adrian Bunk
2005-01-16 18:53 ` Pavel Machek
0 siblings, 1 reply; 4+ messages in thread
From: Adrian Bunk @ 2005-01-16 7:39 UTC (permalink / raw)
To: len.brown, acpi-devel, pavel; +Cc: linux-kernel, ak, discuss
acpi_save_state_disk does nothing and is completely unused.
Unless some usage is planned in the near future, I'm therefore proposing
the patch below to kill it.
diffstat output:
arch/i386/kernel/acpi/sleep.c | 9 ---------
arch/x86_64/kernel/acpi/sleep.c | 9 ---------
include/asm-i386/acpi.h | 1 -
include/asm-i386/suspend.h | 1 -
include/asm-x86_64/acpi.h | 1 -
include/asm-x86_64/suspend.h | 1 -
6 files changed, 22 deletions(-)
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.11-rc1-mm1-full/include/asm-i386/acpi.h.old 2005-01-16 04:25:17.000000000 +0100
+++ linux-2.6.11-rc1-mm1-full/include/asm-i386/acpi.h 2005-01-16 04:25:23.000000000 +0100
@@ -174,7 +174,6 @@
/* routines for saving/restoring kernel state */
extern int acpi_save_state_mem(void);
-extern int acpi_save_state_disk(void);
extern void acpi_restore_state_mem(void);
extern unsigned long acpi_wakeup_address;
--- linux-2.6.11-rc1-mm1-full/include/asm-i386/suspend.h.old 2005-01-16 04:25:31.000000000 +0100
+++ linux-2.6.11-rc1-mm1-full/include/asm-i386/suspend.h 2005-01-16 04:25:35.000000000 +0100
@@ -61,5 +61,4 @@
/* routines for saving/restoring kernel state */
extern int acpi_save_state_mem(void);
-extern int acpi_save_state_disk(void);
#endif
--- linux-2.6.11-rc1-mm1-full/include/asm-x86_64/acpi.h.old 2005-01-16 04:25:44.000000000 +0100
+++ linux-2.6.11-rc1-mm1-full/include/asm-x86_64/acpi.h 2005-01-16 04:25:48.000000000 +0100
@@ -153,7 +153,6 @@
/* routines for saving/restoring kernel state */
extern int acpi_save_state_mem(void);
-extern int acpi_save_state_disk(void);
extern void acpi_restore_state_mem(void);
extern unsigned long acpi_wakeup_address;
--- linux-2.6.11-rc1-mm1-full/include/asm-x86_64/suspend.h.old 2005-01-16 04:25:56.000000000 +0100
+++ linux-2.6.11-rc1-mm1-full/include/asm-x86_64/suspend.h 2005-01-16 04:26:00.000000000 +0100
@@ -55,5 +55,4 @@
/* routines for saving/restoring kernel state */
extern int acpi_save_state_mem(void);
-extern int acpi_save_state_disk(void);
#endif
--- linux-2.6.11-rc1-mm1-full/arch/i386/kernel/acpi/sleep.c.old 2005-01-16 04:26:23.000000000 +0100
+++ linux-2.6.11-rc1-mm1-full/arch/i386/kernel/acpi/sleep.c 2005-01-16 04:26:30.000000000 +0100
@@ -47,15 +47,6 @@
return 0;
}
-/**
- * acpi_save_state_disk - save kernel state to disk
- *
- */
-int acpi_save_state_disk (void)
-{
- return 1;
-}
-
/*
* acpi_restore_state - undo effects of acpi_save_state_mem
*/
--- linux-2.6.11-rc1-mm1-full/arch/x86_64/kernel/acpi/sleep.c.old 2005-01-16 04:26:43.000000000 +0100
+++ linux-2.6.11-rc1-mm1-full/arch/x86_64/kernel/acpi/sleep.c 2005-01-16 04:26:50.000000000 +0100
@@ -87,15 +87,6 @@
return 0;
}
-/**
- * acpi_save_state_disk - save kernel state to disk
- *
- */
-int acpi_save_state_disk (void)
-{
- return 1;
-}
-
/*
* acpi_restore_state
*/
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [2.6 patch] i386/x86_64: acpi/sleep.c: kill unused acpi_save_state_disk
2005-01-16 7:39 [2.6 patch] i386/x86_64: acpi/sleep.c: kill unused acpi_save_state_disk Adrian Bunk
@ 2005-01-16 18:53 ` Pavel Machek
0 siblings, 0 replies; 4+ messages in thread
From: Pavel Machek @ 2005-01-16 18:53 UTC (permalink / raw)
To: Adrian Bunk; +Cc: len.brown, acpi-devel, linux-kernel, ak, discuss
Hi!
> acpi_save_state_disk does nothing and is completely unused.
>
> Unless some usage is planned in the near future, I'm therefore proposing
> the patch below to kill it.
Good idea.
Pavel
--
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [2.6 patch] i386/x86_64: acpi/sleep.c: kill unused acpi_save_state_disk
2005-02-06 18:44 Adrian Bunk
@ 2005-02-06 19:46 ` Andi Kleen
0 siblings, 0 replies; 4+ messages in thread
From: Andi Kleen @ 2005-02-06 19:46 UTC (permalink / raw)
To: Adrian Bunk
Cc: Andrew Morton, len.brown, acpi-devel, pavel, linux-kernel, ak, discuss
On Sun, Feb 06, 2005 at 07:44:47PM +0100, Adrian Bunk wrote:
> acpi_save_state_disk does nothing and is completely unused.
>
> This patch was already ACK'ed by Pavel Machek.
Since it affects both i386 and x86-64 it should be pushed by the ACPI
people. However it's no bugfix and so definitely nothing for 2.6.11,
so it'll take quite some time anyways.
-Andi
^ permalink raw reply [flat|nested] 4+ messages in thread
* [2.6 patch] i386/x86_64: acpi/sleep.c: kill unused acpi_save_state_disk
@ 2005-02-06 18:44 Adrian Bunk
2005-02-06 19:46 ` Andi Kleen
0 siblings, 1 reply; 4+ messages in thread
From: Adrian Bunk @ 2005-02-06 18:44 UTC (permalink / raw)
To: Andrew Morton; +Cc: len.brown, acpi-devel, pavel, linux-kernel, ak, discuss
acpi_save_state_disk does nothing and is completely unused.
This patch was already ACK'ed by Pavel Machek.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
This patch was already sent on:
- 16 Jan 2005
arch/i386/kernel/acpi/sleep.c | 9 ---------
arch/x86_64/kernel/acpi/sleep.c | 9 ---------
include/asm-i386/acpi.h | 1 -
include/asm-i386/suspend.h | 1 -
include/asm-x86_64/acpi.h | 1 -
include/asm-x86_64/suspend.h | 1 -
6 files changed, 22 deletions(-)
--- linux-2.6.11-rc1-mm1-full/include/asm-i386/acpi.h.old 2005-01-16 04:25:17.000000000 +0100
+++ linux-2.6.11-rc1-mm1-full/include/asm-i386/acpi.h 2005-01-16 04:25:23.000000000 +0100
@@ -174,7 +174,6 @@
/* routines for saving/restoring kernel state */
extern int acpi_save_state_mem(void);
-extern int acpi_save_state_disk(void);
extern void acpi_restore_state_mem(void);
extern unsigned long acpi_wakeup_address;
--- linux-2.6.11-rc1-mm1-full/include/asm-i386/suspend.h.old 2005-01-16 04:25:31.000000000 +0100
+++ linux-2.6.11-rc1-mm1-full/include/asm-i386/suspend.h 2005-01-16 04:25:35.000000000 +0100
@@ -61,5 +61,4 @@
/* routines for saving/restoring kernel state */
extern int acpi_save_state_mem(void);
-extern int acpi_save_state_disk(void);
#endif
--- linux-2.6.11-rc1-mm1-full/include/asm-x86_64/acpi.h.old 2005-01-16 04:25:44.000000000 +0100
+++ linux-2.6.11-rc1-mm1-full/include/asm-x86_64/acpi.h 2005-01-16 04:25:48.000000000 +0100
@@ -153,7 +153,6 @@
/* routines for saving/restoring kernel state */
extern int acpi_save_state_mem(void);
-extern int acpi_save_state_disk(void);
extern void acpi_restore_state_mem(void);
extern unsigned long acpi_wakeup_address;
--- linux-2.6.11-rc1-mm1-full/include/asm-x86_64/suspend.h.old 2005-01-16 04:25:56.000000000 +0100
+++ linux-2.6.11-rc1-mm1-full/include/asm-x86_64/suspend.h 2005-01-16 04:26:00.000000000 +0100
@@ -55,5 +55,4 @@
/* routines for saving/restoring kernel state */
extern int acpi_save_state_mem(void);
-extern int acpi_save_state_disk(void);
#endif
--- linux-2.6.11-rc1-mm1-full/arch/i386/kernel/acpi/sleep.c.old 2005-01-16 04:26:23.000000000 +0100
+++ linux-2.6.11-rc1-mm1-full/arch/i386/kernel/acpi/sleep.c 2005-01-16 04:26:30.000000000 +0100
@@ -47,15 +47,6 @@
return 0;
}
-/**
- * acpi_save_state_disk - save kernel state to disk
- *
- */
-int acpi_save_state_disk (void)
-{
- return 1;
-}
-
/*
* acpi_restore_state - undo effects of acpi_save_state_mem
*/
--- linux-2.6.11-rc1-mm1-full/arch/x86_64/kernel/acpi/sleep.c.old 2005-01-16 04:26:43.000000000 +0100
+++ linux-2.6.11-rc1-mm1-full/arch/x86_64/kernel/acpi/sleep.c 2005-01-16 04:26:50.000000000 +0100
@@ -87,15 +87,6 @@
return 0;
}
-/**
- * acpi_save_state_disk - save kernel state to disk
- *
- */
-int acpi_save_state_disk (void)
-{
- return 1;
-}
-
/*
* acpi_restore_state
*/
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2005-02-06 19:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-01-16 7:39 [2.6 patch] i386/x86_64: acpi/sleep.c: kill unused acpi_save_state_disk Adrian Bunk
2005-01-16 18:53 ` Pavel Machek
2005-02-06 18:44 Adrian Bunk
2005-02-06 19:46 ` Andi Kleen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).