* [2.6 patch] kernel/capability.c: make a spinlock static
@ 2005-01-17 8:13 Adrian Bunk
0 siblings, 0 replies; 3+ messages in thread
From: Adrian Bunk @ 2005-01-17 8:13 UTC (permalink / raw)
To: Andrew Morton; +Cc: Chris Wright, linux-kernel
This patch makes a needlessly global spinlock static.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: Chris Wright <chrisw@osdl.org>
---
diffstat output:
include/linux/capability.h | 2 --
kernel/capability.c | 4 ++--
2 files changed, 2 insertions(+), 4 deletions(-)
This patch was already sent on:
- 12 Dec 2004
--- linux-2.6.10-rc2-mm4-full/include/linux/capability.h.old 2004-12-12 02:43:59.000000000 +0100
+++ linux-2.6.10-rc2-mm4-full/include/linux/capability.h 2004-12-12 02:44:05.000000000 +0100
@@ -44,8 +44,6 @@
#include <linux/spinlock.h>
-extern spinlock_t task_capability_lock;
-
/* #define STRICT_CAP_T_TYPECHECKS */
#ifdef STRICT_CAP_T_TYPECHECKS
--- linux-2.6.10-rc2-mm4-full/kernel/capability.c.old 2004-12-12 02:43:23.000000000 +0100
+++ linux-2.6.10-rc2-mm4-full/kernel/capability.c 2004-12-12 02:43:45.000000000 +0100
@@ -20,10 +20,10 @@
EXPORT_SYMBOL(cap_bset);
/*
- * This global lock protects task->cap_* for all tasks including current.
+ * This lock protects task->cap_* for all tasks including current.
* Locking rule: acquire this prior to tasklist_lock.
*/
-DEFINE_SPINLOCK(task_capability_lock);
+static DEFINE_SPINLOCK(task_capability_lock);
/*
* For sys_getproccap() and sys_setproccap(), any of the three
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [2.6 patch] kernel/capability.c: make a spinlock static
2004-12-12 19:16 Adrian Bunk
@ 2004-12-13 19:40 ` Chris Wright
0 siblings, 0 replies; 3+ messages in thread
From: Chris Wright @ 2004-12-13 19:40 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Andrew Main, linux-kernel
* Adrian Bunk (bunk@stusta.de) wrote:
> The patch below makes a needlessly global spinlock static.
>
>
> diffstat output:
> include/linux/capability.h | 2 --
> kernel/capability.c | 4 ++--
> 2 files changed, 2 insertions(+), 4 deletions(-)
>
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: Chris Wright <chrisw@osdl.org>
thanks,
-chris
--
Linux Security Modules http://lsm.immunix.org http://lsm.bkbits.net
^ permalink raw reply [flat|nested] 3+ messages in thread
* [2.6 patch] kernel/capability.c: make a spinlock static
@ 2004-12-12 19:16 Adrian Bunk
2004-12-13 19:40 ` Chris Wright
0 siblings, 1 reply; 3+ messages in thread
From: Adrian Bunk @ 2004-12-12 19:16 UTC (permalink / raw)
To: Andrew Main; +Cc: linux-kernel
The patch below makes a needlessly global spinlock static.
diffstat output:
include/linux/capability.h | 2 --
kernel/capability.c | 4 ++--
2 files changed, 2 insertions(+), 4 deletions(-)
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.10-rc2-mm4-full/include/linux/capability.h.old 2004-12-12 02:43:59.000000000 +0100
+++ linux-2.6.10-rc2-mm4-full/include/linux/capability.h 2004-12-12 02:44:05.000000000 +0100
@@ -44,8 +44,6 @@
#include <linux/spinlock.h>
-extern spinlock_t task_capability_lock;
-
/* #define STRICT_CAP_T_TYPECHECKS */
#ifdef STRICT_CAP_T_TYPECHECKS
--- linux-2.6.10-rc2-mm4-full/kernel/capability.c.old 2004-12-12 02:43:23.000000000 +0100
+++ linux-2.6.10-rc2-mm4-full/kernel/capability.c 2004-12-12 02:43:45.000000000 +0100
@@ -20,10 +20,10 @@
EXPORT_SYMBOL(cap_bset);
/*
- * This global lock protects task->cap_* for all tasks including current.
+ * This lock protects task->cap_* for all tasks including current.
* Locking rule: acquire this prior to tasklist_lock.
*/
-DEFINE_SPINLOCK(task_capability_lock);
+static DEFINE_SPINLOCK(task_capability_lock);
/*
* For sys_getproccap() and sys_setproccap(), any of the three
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-01-17 8:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-01-17 8:13 [2.6 patch] kernel/capability.c: make a spinlock static Adrian Bunk
-- strict thread matches above, loose matches on Subject: below --
2004-12-12 19:16 Adrian Bunk
2004-12-13 19:40 ` Chris Wright
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).