Re: [PATCH] OpenBSD Networking-related randomization port

From: Ingo Molnar <mingo@elte.hu>
To: "Lorenzo Hernández García-Hierro" <lorenzo@gnu.org>
Cc: Adrian Bunk <bunk@stusta.de>,
	Valdis.Kletnieks@vt.edu, Arjan van de Ven <arjan@infradead.org>,
	Stephen Hemminger <shemminger@osdl.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Chris Wright <chrisw@osdl.org>,
	netdev@oss.sgi.com, Hank Leininger <hlein@progressive-comp.com>,
	"David S. Miller" <davem@redhat.com>,
	linux@horizon.com
Subject: Re: [PATCH] OpenBSD Networking-related randomization port
Date: Mon, 31 Jan 2005 21:11:41 +0100	[thread overview]
Message-ID: <20050131201141.GA4879@elte.hu> (raw)
In-Reply-To: <1107192218.3754.86.camel@localhost.localdomain>

* Lorenzo Hernández García-Hierro <lorenzo@gnu.org> wrote:

> > At least the three clause BSD license is GPL compatible.
> 
> Yes, AFAIK :)
> 
> I will try to follow Arjan's recommendations on using his functions
> instead of obsd ones, even if I think it should be alone in the
> current file. Also I will split up the patch.

could you please also react to this feedback:

  http://marc.theaimsgroup.com/?l=linux-kernel&m=110698371131630&w=2

to quote a couple of key points from that very detailed security
analysis:

" I'm not sure how the OpenBSD code is better in any way.  (Notice that
  it uses the same "half_md4_transform" as Linux; you just added another
  copy.) Is there a design note on how the design was chosen? "

that mail also includes a much smaller patch to random.c.

( Obviously the more fundamental questions have to be solved prior
solving code-level problems, patch splitup and patch ordering - often
one ends up having a much smaller patch to work with, by thinking more
about the fundamentals. )

	Ingo