From: Greg KH <greg@kroah.com>
To: Alexey Dobriyan <adobriyan@mail.ru>
Cc: "Mark A. Greer" <mgreer@mvista.com>,
phil@netroedge.com, sensors@stimpy.netroedge.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][I2C] Marvell mv64xxx i2c driver
Date: Tue, 1 Feb 2005 17:27:24 -0800 [thread overview]
Message-ID: <20050202012723.GA16465@kroah.com> (raw)
In-Reply-To: <200502020315.14281.adobriyan@mail.ru>
On Wed, Feb 02, 2005 at 03:15:14AM +0200, Alexey Dobriyan wrote:
> P. S.: struct mv64xxx_i2c_data revisited...
>
> > + uint state;
> > + ulong reg_base_p;
>
> Silly request, but... Maybe this should be changed to plain old "unsigned int"
> and "unsigned long". Please. I just don't understand why people use "uint",
> "u_int", "uInt", "UINT", "uINT", "uint_t" which are always typedef'ed to
> "unsigned int".
Not a silly request at all. Please use the u32, u64 and so on values
instead. That way we know what you mean, and it's portable.
thanks,
greg k-h
next parent reply other threads:[~2005-02-02 1:28 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200502020315.14281.adobriyan@mail.ru>
2005-02-02 1:27 ` Greg KH [this message]
2005-02-02 17:26 ` [PATCH][I2C] Marvell mv64xxx i2c driver Mark A. Greer
[not found] ` <200502031556.59319.adobriyan@mail.ru>
2005-02-03 19:12 ` Mark A. Greer
2005-02-04 0:38 ` Alexey Dobriyan
2005-02-04 0:04 ` Mark A. Greer
2005-02-04 9:45 ` Jean Delvare
2005-02-06 14:36 ` Jean Delvare
2005-02-08 23:27 Mark A. Greer
2005-02-09 0:01 ` Bartlomiej Zolnierkiewicz
2005-02-09 0:32 ` Mark A. Greer
2005-02-09 1:24 ` Bartlomiej Zolnierkiewicz
2005-02-09 21:33 ` Mark A. Greer
2005-02-17 22:25 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2005-01-26 1:26 Mark A. Greer
2005-01-26 19:56 ` Jean Delvare
2005-01-26 20:33 ` Mark A. Greer
2005-01-26 21:56 ` Mark A. Greer
2005-01-26 22:42 ` Greg KH
2005-01-26 23:59 ` Mark A. Greer
2005-01-31 18:25 ` Greg KH
2005-01-31 18:41 ` Mark A. Greer
2005-02-01 0:46 ` Greg KH
2005-02-01 17:54 ` Mark A. Greer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050202012723.GA16465@kroah.com \
--to=greg@kroah.com \
--cc=adobriyan@mail.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=mgreer@mvista.com \
--cc=phil@netroedge.com \
--cc=sensors@stimpy.netroedge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).