From: Alexey Dobriyan <adobriyan@mail.ru>
To: "Mark A. Greer" <mgreer@mvista.com>
Cc: Greg KH <greg@kroah.com>,
phil@netroedge.com, sensors@stimpy.netroedge.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][I2C] Marvell mv64xxx i2c driver
Date: Fri, 4 Feb 2005 02:38:56 +0200 [thread overview]
Message-ID: <200502040238.57048.adobriyan@mail.ru> (raw)
In-Reply-To: <4202779C.6010304@mvista.com>
On Thursday 03 February 2005 21:12, Mark A. Greer wrote:
> > >+ mv64xxx_i2c_fsm(drv_data, status);
> >
> >It can set drv_data->rc to -ENODEV or -EIO. In both cases ->action goes to
> >MV64XXX_I2C_ACTION_SEND_STOP and mv64xxx_i2c_do_action() will writel()
> >something. Is it correct to _not_ check ->rc here?
>
> I think so. It still needs to go into do_action even when rc != 0 (in
> which case it'll do a STOP condition).
Ok. Thanks for the explanation. Agree, ->rc should be left as is.
> This patch is a replacement patch that should address your concerns
> except maybe the mv64xxx_i2c_data.rc one.
> --- a/include/linux/i2c-id.h
> +++ b/include/linux/i2c-id.h
> + /* 0x170000 - USB */
> + /* 0x180000 - Virtual buses */
> +#define I2C_ALGO_MV64XXX 0x190000 /* Marvell mv64xxx i2c ctlr */
While I searched for typos and you're fixing them, au1550 owned 0x170000.
2.6.11-rc3 says:
#define I2C_ALGO_AU1550 0x170000 /* Au1550 PSC algorithm */
So, I'd remove first two comments.
Oh, and the last note: current sparse and gcc 4 don't produce any warnings.
Alexey
next prev parent reply other threads:[~2005-02-03 23:42 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200502020315.14281.adobriyan@mail.ru>
2005-02-02 1:27 ` [PATCH][I2C] Marvell mv64xxx i2c driver Greg KH
2005-02-02 17:26 ` Mark A. Greer
[not found] ` <200502031556.59319.adobriyan@mail.ru>
2005-02-03 19:12 ` Mark A. Greer
2005-02-04 0:38 ` Alexey Dobriyan [this message]
2005-02-04 0:04 ` Mark A. Greer
2005-02-04 9:45 ` Jean Delvare
2005-02-06 14:36 ` Jean Delvare
2005-02-08 23:27 Mark A. Greer
2005-02-09 0:01 ` Bartlomiej Zolnierkiewicz
2005-02-09 0:32 ` Mark A. Greer
2005-02-09 1:24 ` Bartlomiej Zolnierkiewicz
2005-02-09 21:33 ` Mark A. Greer
2005-02-17 22:25 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2005-01-26 1:26 Mark A. Greer
2005-01-26 19:56 ` Jean Delvare
2005-01-26 20:33 ` Mark A. Greer
2005-01-26 21:56 ` Mark A. Greer
2005-01-26 22:42 ` Greg KH
2005-01-26 23:59 ` Mark A. Greer
2005-01-31 18:25 ` Greg KH
2005-01-31 18:41 ` Mark A. Greer
2005-02-01 0:46 ` Greg KH
2005-02-01 17:54 ` Mark A. Greer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200502040238.57048.adobriyan@mail.ru \
--to=adobriyan@mail.ru \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgreer@mvista.com \
--cc=phil@netroedge.com \
--cc=sensors@stimpy.netroedge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).