* [2.6 patch] drivers/net/seeq8005.c: cleanups
@ 2005-02-19 0:05 Adrian Bunk
2005-02-21 1:36 ` Jeff Garzik
0 siblings, 1 reply; 5+ messages in thread
From: Adrian Bunk @ 2005-02-19 0:05 UTC (permalink / raw)
To: jgarzik; +Cc: linux-net, linux-kernel
This patch contains the following cleanups:
- make the needlessly global function seeq8005_init static
- kill an ancient version variable
- remove some outdated Emacs settings
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
drivers/net/seeq8005.c | 25 +++----------------------
1 files changed, 3 insertions(+), 22 deletions(-)
--- linux-2.6.11-rc3-mm2-full/drivers/net/seeq8005.c.old 2005-02-16 18:18:56.000000000 +0100
+++ linux-2.6.11-rc3-mm2-full/drivers/net/seeq8005.c 2005-02-16 18:19:53.000000000 +0100
@@ -12,12 +12,6 @@
This file is a network device driver for the SEEQ 8005 chipset and
the Linux operating system.
-*/
-
-static const char version[] =
- "seeq8005.c:v1.00 8/07/95 Hamish Coleman (hamish@zot.apana.org.au)\n";
-
-/*
Sources:
SEEQ 8005 databook
@@ -91,10 +85,10 @@
/* Example routines you must write ;->. */
#define tx_done(dev) (inw(SEEQ_STATUS) & SEEQSTAT_TX_ON)
static void hardware_send_packet(struct net_device *dev, char *buf, int length);
-extern void seeq8005_init(struct net_device *dev, int startp);
+static void seeq8005_init(struct net_device *dev, int startp);
static inline void wait_for_buffer(struct net_device *dev);
-\f
+
/* Check for a network adaptor of this type, and return '0' iff one exists.
If dev->base_addr == 0, probe all likely locations.
If dev->base_addr == 1, always return failure.
@@ -150,7 +144,6 @@
static int __init seeq8005_probe1(struct net_device *dev, int ioaddr)
{
- static unsigned version_printed;
int i,j;
unsigned char SA_prom[32];
int old_cfg1;
@@ -291,9 +284,6 @@
}
#endif
- if (net_debug && version_printed++ == 0)
- printk(version);
-
printk("%s: %s found at %#3x, ", dev->name, "seeq8005", ioaddr);
/* Fill in the 'dev' fields. */
@@ -637,7 +627,7 @@
#endif
}
-void seeq8005_init(struct net_device *dev, int startp)
+static void seeq8005_init(struct net_device *dev, int startp)
{
struct net_local *lp = netdev_priv(dev);
int ioaddr = dev->base_addr;
@@ -758,12 +748,3 @@
}
#endif /* MODULE */
-\f
-/*
- * Local variables:
- * compile-command: "gcc -D__KERNEL__ -I/usr/src/linux/net/inet -Wall -Wstrict-prototypes -O6 -m486 -c skeleton.c"
- * version-control: t
- * kept-new-versions: 5
- * tab-width: 4
- * End:
- */
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [2.6 patch] drivers/net/seeq8005.c: cleanups
2005-02-19 0:05 [2.6 patch] drivers/net/seeq8005.c: cleanups Adrian Bunk
@ 2005-02-21 1:36 ` Jeff Garzik
2005-02-21 14:48 ` Adrian Bunk
0 siblings, 1 reply; 5+ messages in thread
From: Jeff Garzik @ 2005-02-21 1:36 UTC (permalink / raw)
To: Adrian Bunk; +Cc: linux-net, linux-kernel
this patch needlessly eats formfeeds
^ permalink raw reply [flat|nested] 5+ messages in thread
* [2.6 patch] drivers/net/seeq8005.c: cleanups
2005-02-21 1:36 ` Jeff Garzik
@ 2005-02-21 14:48 ` Adrian Bunk
0 siblings, 0 replies; 5+ messages in thread
From: Adrian Bunk @ 2005-02-21 14:48 UTC (permalink / raw)
To: Jeff Garzik; +Cc: linux-net, linux-kernel
On Sun, Feb 20, 2005 at 08:36:52PM -0500, Jeff Garzik wrote:
> this patch needlessly eats formfeeds
Sorry, updated patch:
<-- snip -->
This patch contains the following cleanups:
- make the needlessly global function seeq8005_init static
- kill an ancient version variable
- remove some outdated Emacs settings
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
drivers/net/seeq8005.c | 23 ++---------------------
1 files changed, 2 insertions(+), 21 deletions(-)
--- linux-2.6.11-rc3-mm2-full/drivers/net/seeq8005.c.old 2005-02-16 18:18:56.000000000 +0100
+++ linux-2.6.11-rc3-mm2-full/drivers/net/seeq8005.c 2005-02-21 15:19:11.000000000 +0100
@@ -12,12 +12,6 @@
This file is a network device driver for the SEEQ 8005 chipset and
the Linux operating system.
-*/
-
-static const char version[] =
- "seeq8005.c:v1.00 8/07/95 Hamish Coleman (hamish@zot.apana.org.au)\n";
-
-/*
Sources:
SEEQ 8005 databook
@@ -91,7 +85,7 @@
/* Example routines you must write ;->. */
#define tx_done(dev) (inw(SEEQ_STATUS) & SEEQSTAT_TX_ON)
static void hardware_send_packet(struct net_device *dev, char *buf, int length);
-extern void seeq8005_init(struct net_device *dev, int startp);
+static void seeq8005_init(struct net_device *dev, int startp);
static inline void wait_for_buffer(struct net_device *dev);
\f
@@ -150,7 +144,6 @@
static int __init seeq8005_probe1(struct net_device *dev, int ioaddr)
{
- static unsigned version_printed;
int i,j;
unsigned char SA_prom[32];
int old_cfg1;
@@ -291,9 +284,6 @@
}
#endif
- if (net_debug && version_printed++ == 0)
- printk(version);
-
printk("%s: %s found at %#3x, ", dev->name, "seeq8005", ioaddr);
/* Fill in the 'dev' fields. */
@@ -637,7 +627,7 @@
#endif
}
-void seeq8005_init(struct net_device *dev, int startp)
+static void seeq8005_init(struct net_device *dev, int startp)
{
struct net_local *lp = netdev_priv(dev);
int ioaddr = dev->base_addr;
@@ -758,12 +748,3 @@
}
#endif /* MODULE */
-\f
-/*
- * Local variables:
- * compile-command: "gcc -D__KERNEL__ -I/usr/src/linux/net/inet -Wall -Wstrict-prototypes -O6 -m486 -c skeleton.c"
- * version-control: t
- * kept-new-versions: 5
- * tab-width: 4
- * End:
- */
^ permalink raw reply [flat|nested] 5+ messages in thread
* [2.6 patch] drivers/net/seeq8005.c: cleanups
@ 2005-05-02 1:46 Adrian Bunk
0 siblings, 0 replies; 5+ messages in thread
From: Adrian Bunk @ 2005-05-02 1:46 UTC (permalink / raw)
To: Andrew Morton; +Cc: Jeff Garzik, netdev, linux-kernel
This patch contains the following cleanups:
- make the needlessly global function seeq8005_init static
- kill an ancient version variable
- remove some outdated Emacs settings
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
This patch was already sent on:
- 19 Apr 2005
- 21 Feb 2005
drivers/net/seeq8005.c | 23 ++---------------------
1 files changed, 2 insertions(+), 21 deletions(-)
--- linux-2.6.11-rc3-mm2-full/drivers/net/seeq8005.c.old 2005-02-16 18:18:56.000000000 +0100
+++ linux-2.6.11-rc3-mm2-full/drivers/net/seeq8005.c 2005-02-21 15:19:11.000000000 +0100
@@ -12,12 +12,6 @@
This file is a network device driver for the SEEQ 8005 chipset and
the Linux operating system.
-*/
-
-static const char version[] =
- "seeq8005.c:v1.00 8/07/95 Hamish Coleman (hamish@zot.apana.org.au)\n";
-
-/*
Sources:
SEEQ 8005 databook
@@ -91,7 +85,7 @@
/* Example routines you must write ;->. */
#define tx_done(dev) (inw(SEEQ_STATUS) & SEEQSTAT_TX_ON)
static void hardware_send_packet(struct net_device *dev, char *buf, int length);
-extern void seeq8005_init(struct net_device *dev, int startp);
+static void seeq8005_init(struct net_device *dev, int startp);
static inline void wait_for_buffer(struct net_device *dev);
\f
@@ -150,7 +144,6 @@
static int __init seeq8005_probe1(struct net_device *dev, int ioaddr)
{
- static unsigned version_printed;
int i,j;
unsigned char SA_prom[32];
int old_cfg1;
@@ -291,9 +284,6 @@
}
#endif
- if (net_debug && version_printed++ == 0)
- printk(version);
-
printk("%s: %s found at %#3x, ", dev->name, "seeq8005", ioaddr);
/* Fill in the 'dev' fields. */
@@ -637,7 +627,7 @@
#endif
}
-void seeq8005_init(struct net_device *dev, int startp)
+static void seeq8005_init(struct net_device *dev, int startp)
{
struct net_local *lp = netdev_priv(dev);
int ioaddr = dev->base_addr;
@@ -758,12 +748,3 @@
}
#endif /* MODULE */
-\f
-/*
- * Local variables:
- * compile-command: "gcc -D__KERNEL__ -I/usr/src/linux/net/inet -Wall -Wstrict-prototypes -O6 -m486 -c skeleton.c"
- * version-control: t
- * kept-new-versions: 5
- * tab-width: 4
- * End:
- */
^ permalink raw reply [flat|nested] 5+ messages in thread
* [2.6 patch] drivers/net/seeq8005.c: cleanups
@ 2005-04-19 0:36 Adrian Bunk
0 siblings, 0 replies; 5+ messages in thread
From: Adrian Bunk @ 2005-04-19 0:36 UTC (permalink / raw)
To: Jeff Garzik; +Cc: netdev, linux-kernel
This patch contains the following cleanups:
- make the needlessly global function seeq8005_init static
- kill an ancient version variable
- remove some outdated Emacs settings
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
This patch was already sent on:
- 21 Feb 2005
drivers/net/seeq8005.c | 23 ++---------------------
1 files changed, 2 insertions(+), 21 deletions(-)
--- linux-2.6.11-rc3-mm2-full/drivers/net/seeq8005.c.old 2005-02-16 18:18:56.000000000 +0100
+++ linux-2.6.11-rc3-mm2-full/drivers/net/seeq8005.c 2005-02-21 15:19:11.000000000 +0100
@@ -12,12 +12,6 @@
This file is a network device driver for the SEEQ 8005 chipset and
the Linux operating system.
-*/
-
-static const char version[] =
- "seeq8005.c:v1.00 8/07/95 Hamish Coleman (hamish@zot.apana.org.au)\n";
-
-/*
Sources:
SEEQ 8005 databook
@@ -91,7 +85,7 @@
/* Example routines you must write ;->. */
#define tx_done(dev) (inw(SEEQ_STATUS) & SEEQSTAT_TX_ON)
static void hardware_send_packet(struct net_device *dev, char *buf, int length);
-extern void seeq8005_init(struct net_device *dev, int startp);
+static void seeq8005_init(struct net_device *dev, int startp);
static inline void wait_for_buffer(struct net_device *dev);
\f
@@ -150,7 +144,6 @@
static int __init seeq8005_probe1(struct net_device *dev, int ioaddr)
{
- static unsigned version_printed;
int i,j;
unsigned char SA_prom[32];
int old_cfg1;
@@ -291,9 +284,6 @@
}
#endif
- if (net_debug && version_printed++ == 0)
- printk(version);
-
printk("%s: %s found at %#3x, ", dev->name, "seeq8005", ioaddr);
/* Fill in the 'dev' fields. */
@@ -637,7 +627,7 @@
#endif
}
-void seeq8005_init(struct net_device *dev, int startp)
+static void seeq8005_init(struct net_device *dev, int startp)
{
struct net_local *lp = netdev_priv(dev);
int ioaddr = dev->base_addr;
@@ -758,12 +748,3 @@
}
#endif /* MODULE */
-\f
-/*
- * Local variables:
- * compile-command: "gcc -D__KERNEL__ -I/usr/src/linux/net/inet -Wall -Wstrict-prototypes -O6 -m486 -c skeleton.c"
- * version-control: t
- * kept-new-versions: 5
- * tab-width: 4
- * End:
- */
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2005-05-02 2:30 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-02-19 0:05 [2.6 patch] drivers/net/seeq8005.c: cleanups Adrian Bunk
2005-02-21 1:36 ` Jeff Garzik
2005-02-21 14:48 ` Adrian Bunk
2005-04-19 0:36 Adrian Bunk
2005-05-02 1:46 Adrian Bunk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).