* 2.4.29 sk98lin patch for Asus K8W SE Deluxe
@ 2005-03-02 22:00 Philippe Troin
2005-03-03 7:52 ` Willy Tarreau
0 siblings, 1 reply; 3+ messages in thread
From: Philippe Troin @ 2005-03-02 22:00 UTC (permalink / raw)
To: linux-kernel, Marcelo Tosatti; +Cc: linux
The EEPROM (or whatever that is) on Asus K8V SE Deluxe motherboards
contains buggy firmware. This buggy firmware has one flipped bit, and
causes the sk98lin driver refuses to work correctly. Please look at
this thread:
http://www.ussg.iu.edu/hypermail/linux/kernel/0404.0/1439.html
It contains a patch for 2.6 that fixs the problem. Enclosed is a copy
of this patch for 2.4.29. Please consider applying.
Phil.
Signed-Off-By: Philippe Troin <phil@fifi.rog>
diff -ruN linux-2.4.29.orig/drivers/net/sk98lin/skvpd.c linux-2.4.29/drivers/net/sk98lin/skvpd.c
--- linux-2.4.29.orig/drivers/net/sk98lin/skvpd.c Wed Apr 14 06:05:30 2004
+++ linux-2.4.29/drivers/net/sk98lin/skvpd.c Mon Feb 21 02:03:00 2005
@@ -466,6 +466,15 @@
pAC->vpd.vpd_size = vpd_size;
+ /* Asus K8V Se Deluxe bugfix. Correct VPD content */
+ /* MBo April 2004 */
+ if( ((unsigned char)pAC->vpd.vpd_buf[0x3f] == 0x38) &&
+ ((unsigned char)pAC->vpd.vpd_buf[0x40] == 0x3c) &&
+ ((unsigned char)pAC->vpd.vpd_buf[0x41] == 0x45) ) {
+ printk("sk98lin : humm... Asus mainboard with buggy VPD ? correcting data.\n");
+ (unsigned char)pAC->vpd.vpd_buf[0x40] = 0x38;
+ }
+
/* find the end tag of the RO area */
if (!(r = vpd_find_para(pAC, VPD_RV, &rp))) {
SK_DBG_MSG(pAC, SK_DBGMOD_VPD, SK_DBGCAT_ERR | SK_DBGCAT_FATAL,
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: 2.4.29 sk98lin patch for Asus K8W SE Deluxe
2005-03-02 22:00 2.4.29 sk98lin patch for Asus K8W SE Deluxe Philippe Troin
@ 2005-03-03 7:52 ` Willy Tarreau
2005-03-04 1:06 ` Philippe Troin
0 siblings, 1 reply; 3+ messages in thread
From: Willy Tarreau @ 2005-03-03 7:52 UTC (permalink / raw)
To: Philippe Troin; +Cc: linux-kernel, Marcelo Tosatti, linux
On Wed, Mar 02, 2005 at 02:00:30PM -0800, Philippe Troin wrote:
> + /* Asus K8V Se Deluxe bugfix. Correct VPD content */
> + /* MBo April 2004 */
> + if( ((unsigned char)pAC->vpd.vpd_buf[0x3f] == 0x38) &&
> + ((unsigned char)pAC->vpd.vpd_buf[0x40] == 0x3c) &&
> + ((unsigned char)pAC->vpd.vpd_buf[0x41] == 0x45) ) {
> + printk("sk98lin : humm... Asus mainboard with buggy VPD ? correcting data.\n");
^^^^^
Please, could you put some KERN_XXX here to avoid a buggy message level ?
Willy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: 2.4.29 sk98lin patch for Asus K8W SE Deluxe
2005-03-03 7:52 ` Willy Tarreau
@ 2005-03-04 1:06 ` Philippe Troin
0 siblings, 0 replies; 3+ messages in thread
From: Philippe Troin @ 2005-03-04 1:06 UTC (permalink / raw)
To: Willy Tarreau; +Cc: linux-kernel, Marcelo Tosatti, linux
Willy Tarreau <willy@w.ods.org> writes:
> On Wed, Mar 02, 2005 at 02:00:30PM -0800, Philippe Troin wrote:
>
> > + /* Asus K8V Se Deluxe bugfix. Correct VPD content */
> > + /* MBo April 2004 */
> > + if( ((unsigned char)pAC->vpd.vpd_buf[0x3f] == 0x38) &&
> > + ((unsigned char)pAC->vpd.vpd_buf[0x40] == 0x3c) &&
> > + ((unsigned char)pAC->vpd.vpd_buf[0x41] == 0x45) ) {
> > + printk("sk98lin : humm... Asus mainboard with buggy VPD ? correcting data.\n");
> ^^^^^
> Please, could you put some KERN_XXX here to avoid a buggy message level ?
Yes, of course.
Phil.
Signed-Off-By: Philippe Troin <phil@fifi.rog>
diff -ruN linux-2.4.29.orig/drivers/net/sk98lin/skvpd.c linux-2.4.29/drivers/net/sk98lin/skvpd.c
--- linux-2.4.29.orig/drivers/net/sk98lin/skvpd.c Wed Apr 14 06:05:30 2004
+++ linux-2.4.29/drivers/net/sk98lin/skvpd.c Mon Feb 21 02:03:00 2005
@@ -466,6 +466,15 @@
pAC->vpd.vpd_size = vpd_size;
+ /* Asus K8V Se Deluxe bugfix. Correct VPD content */
+ /* MBo April 2004 */
+ if( ((unsigned char)pAC->vpd.vpd_buf[0x3f] == 0x38) &&
+ ((unsigned char)pAC->vpd.vpd_buf[0x40] == 0x3c) &&
+ ((unsigned char)pAC->vpd.vpd_buf[0x41] == 0x45) ) {
+ printk(KERN_INFO "sk98lin : humm... Asus mainboard with buggy VPD ? correcting data.\n");
+ (unsigned char)pAC->vpd.vpd_buf[0x40] = 0x38;
+ }
+
/* find the end tag of the RO area */
if (!(r = vpd_find_para(pAC, VPD_RV, &rp))) {
SK_DBG_MSG(pAC, SK_DBGMOD_VPD, SK_DBGCAT_ERR | SK_DBGCAT_FATAL,
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-03-04 1:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-03-02 22:00 2.4.29 sk98lin patch for Asus K8W SE Deluxe Philippe Troin
2005-03-03 7:52 ` Willy Tarreau
2005-03-04 1:06 ` Philippe Troin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).