* [patch 161/198] IB: Fix user MAD registrations with class 0
@ 2005-04-12 10:33 akpm
0 siblings, 0 replies; only message in thread
From: akpm @ 2005-04-12 10:33 UTC (permalink / raw)
To: torvalds; +Cc: linux-kernel, akpm, roland
From: Roland Dreier <roland@topspin.com>
Fix handling of MAD agent registrations with mgmt_class == 0. In this case
ib_umad should pass a NULL registration request to the MAD core rather than a
request with mgmt_class set to 0.
Signed-off-by: Roland Dreier <roland@topspin.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
---
25-akpm/drivers/infiniband/core/user_mad.c | 14 ++++++++------
1 files changed, 8 insertions(+), 6 deletions(-)
diff -puN drivers/infiniband/core/user_mad.c~ib-fix-user-mad-registrations-with-class-0 drivers/infiniband/core/user_mad.c
--- 25/drivers/infiniband/core/user_mad.c~ib-fix-user-mad-registrations-with-class-0 2005-04-12 03:21:41.957758352 -0700
+++ 25-akpm/drivers/infiniband/core/user_mad.c 2005-04-12 03:21:41.960757896 -0700
@@ -389,15 +389,17 @@ static int ib_umad_reg_agent(struct ib_u
goto out;
found:
- req.mgmt_class = ureq.mgmt_class;
- req.mgmt_class_version = ureq.mgmt_class_version;
- memcpy(req.method_mask, ureq.method_mask, sizeof req.method_mask);
- memcpy(req.oui, ureq.oui, sizeof req.oui);
+ if (ureq.mgmt_class) {
+ req.mgmt_class = ureq.mgmt_class;
+ req.mgmt_class_version = ureq.mgmt_class_version;
+ memcpy(req.method_mask, ureq.method_mask, sizeof req.method_mask);
+ memcpy(req.oui, ureq.oui, sizeof req.oui);
+ }
agent = ib_register_mad_agent(file->port->ib_dev, file->port->port_num,
ureq.qpn ? IB_QPT_GSI : IB_QPT_SMI,
- &req, 0, send_handler, recv_handler,
- file);
+ ureq.mgmt_class ? &req : NULL,
+ 0, send_handler, recv_handler, file);
if (IS_ERR(agent)) {
ret = PTR_ERR(agent);
goto out;
_
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2005-04-12 10:52 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-04-12 10:33 [patch 161/198] IB: Fix user MAD registrations with class 0 akpm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).