linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: Dave Jones <davej@redhat.com>, Hugh Dickins <hugh@veritas.com>,
	Chris Wright <chrisw@osdl.org>, Andi Kleen <ak@suse.de>,
	"Sergey S. Kostyliov" <rathamahata@ehouse.ru>,
	Clem Taylor <clem.taylor@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: Debugging patch was Re: x86-64 bad pmds in 2.6.11.6 II
Date: Fri, 22 Apr 2005 19:37:03 +0200	[thread overview]
Message-ID: <20050422173703.GB7715@wotan.suse.de> (raw)
In-Reply-To: <20050415180703.GA26289@redhat.com>


Can people who can reproduce the x86-64 2.6.11 pmd bad  problem please apply
the following patch and see (a) if it can be still reprocuded with it 
and send the output generated. Also a strace of the program that showed
it (pid and name of it should be dumped) would be useful if not too big.

After staring some time at the code I cant find the problem, but 
I somehow suspect it has to do with early page table frees. That is
why they were disabled. This should not cause any memory leaks,
the page tables will be always freed at process exit, so it is
safe to apply even for production machines.

Thanks,

-Andi


diff -u linux-2.6.11/mm/memory.c-o linux-2.6.11/mm/memory.c
--- linux-2.6.11/mm/memory.c-o	2005-03-02 08:38:08.000000000 +0100
+++ linux-2.6.11/mm/memory.c	2005-04-22 19:32:30.305402456 +0200
@@ -94,6 +94,7 @@
 	if (pmd_none(*pmd))
 		return;
 	if (unlikely(pmd_bad(*pmd))) {
+		printk("%s:%d: ", current->comm, current->pid);
 		pmd_ERROR(*pmd);
 		pmd_clear(pmd);
 		return;
diff -u linux-2.6.11/mm/mmap.c-o linux-2.6.11/mm/mmap.c
--- linux-2.6.11/mm/mmap.c-o	2005-03-02 08:38:12.000000000 +0100
+++ linux-2.6.11/mm/mmap.c	2005-04-22 19:33:10.354580428 +0200
@@ -1645,11 +1645,13 @@
 		return;
 	if (first < FIRST_USER_PGD_NR * PGDIR_SIZE)
 		first = FIRST_USER_PGD_NR * PGDIR_SIZE;
+#if 0
 	/* No point trying to free anything if we're in the same pte page */
 	if ((first & PMD_MASK) < (last & PMD_MASK)) {
 		clear_page_range(tlb, first, last);
 		flush_tlb_pgtables(mm, first, last);
 	}
+#endif
 }
 
 /* Normal function to fix up a mapping


  reply	other threads:[~2005-04-22 17:37 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-30 21:44 x86-64 bad pmds in 2.6.11.6 Dave Jones
2005-03-31 10:41 ` Andi Kleen
2005-03-31 21:52   ` Dave Jones
2005-04-01 11:52     ` Sergey S. Kostyliov
2005-04-07  2:49   ` Dave Jones
2005-04-07  6:29     ` Andi Kleen
2005-04-14 13:54       ` Hugh Dickins
2005-04-14 17:01         ` Andi Kleen
2005-04-14 17:34           ` Hugh Dickins
2005-04-14 18:10             ` Andi Kleen
2005-04-14 18:11               ` x86-64 bad pmds in 2.6.11.6 II Andi Kleen
2005-04-14 18:27                 ` Chris Wright
2005-04-15 17:24                   ` Andi Kleen
2005-04-15 17:28                     ` Chris Wright
2005-04-15 17:58                       ` Hugh Dickins
2005-04-15 18:07                         ` Dave Jones
2005-04-22 17:37                           ` Andi Kleen [this message]
2005-04-27 14:23                           ` New debugging patch was " Andi Kleen
2005-04-27 17:37                             ` Dave Jones
2005-04-29 11:07                               ` Hans Kristian Rosbach
2005-04-19 13:35                         ` Andi Kleen
2005-04-19 15:52                           ` Hugh Dickins
2005-04-29 11:12                             ` Christopher Warner
2005-04-29 16:13                               ` Chris Wright
2005-04-29 17:32                               ` Dave Jones
2005-05-02 17:00                                 ` Andi Kleen
2005-05-02 15:28                                   ` Christopher Warner
2005-05-02 20:33                                     ` Chris Wright
2005-05-02 21:08                                       ` Dave Jones
2005-05-03 14:28                                         ` Andi Kleen
2005-05-03 15:15                                           ` Dave Jones
2005-05-10  9:36                                     ` Christopher Warner
2005-05-10 16:26                                       ` Chris Wright
2005-05-10 12:03                                         ` Christopher Warner
2005-05-10 16:38                                       ` Dave Jones
2005-05-10 16:46                                         ` Andi Kleen
2005-05-10 16:59                                           ` Dave Jones
2005-05-10 20:32                                             ` Andi Kleen
2005-05-10 20:43                                               ` Chris Wright
2005-05-12 21:23                                             ` Andi Kleen
2005-05-13 21:51                                               ` Peter J. Stieber
2005-05-14 17:29                                                 ` Peter J. Stieber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050422173703.GB7715@wotan.suse.de \
    --to=ak@suse.de \
    --cc=chrisw@osdl.org \
    --cc=clem.taylor@gmail.com \
    --cc=davej@redhat.com \
    --cc=hugh@veritas.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rathamahata@ehouse.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).