From: "YOSHIFUJI Hideaki / 吉藤英明" <yoshfuji@linux-ipv6.org>
To: michaelc@cs.wisc.edu
Cc: linux-scsi@vger.kernel.org, netdev@oss.sgi.com,
linux-kernel@vger.kernel.org, yoshfuji@linux-ipv6.org
Subject: Re: [PATCH 2/3] add open iscsi netlink interface to iscsi transport class
Date: Thu, 05 May 2005 18:55:03 +0900 (JST) [thread overview]
Message-ID: <20050505.185503.78606493.yoshfuji@linux-ipv6.org> (raw)
In-Reply-To: <42798AC1.2010308@cs.wisc.edu>
In article <42798AC1.2010308@cs.wisc.edu> (at Wed, 04 May 2005 19:53:53 -0700), Mike Christie <michaelc@cs.wisc.edu> says:
> +struct iscsi_uevent {
:
> +} __attribute__ ((aligned (sizeof(unsigned long))));
I think it'd be better to use sizeof(uint64_t) or something.
Please check other spots, too. e.g.:
> + struct iscsi_stats_custom custom[0]
> + __attribute__ ((aligned (sizeof(unsigned long))));
--yoshfuji
next prev parent reply other threads:[~2005-05-05 9:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-05 2:53 [PATCH 2/3] add open iscsi netlink interface to iscsi transport class Mike Christie
2005-05-05 9:55 ` YOSHIFUJI Hideaki / 吉藤英明 [this message]
2005-05-05 11:39 ` Herbert Xu
2005-05-05 11:45 ` Arjan van de Ven
2005-05-05 11:55 ` YOSHIFUJI Hideaki / 吉藤英明
2005-05-05 12:22 ` Matthew Wilcox
2005-05-15 19:30 Mike Christie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050505.185503.78606493.yoshfuji@linux-ipv6.org \
--to=yoshfuji@linux-ipv6.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).