From: Herbert Xu <herbert@gondor.apana.org.au>
To: yoshfuji@linux-ipv6.org (YOSHIFUJI Hideaki / ????)
Cc: michaelc@cs.wisc.edu, linux-scsi@vger.kernel.org,
netdev@oss.sgi.com, linux-kernel@vger.kernel.org,
yoshfuji@linux-ipv6.org
Subject: Re: [PATCH 2/3] add open iscsi netlink interface to iscsi transport class
Date: Thu, 05 May 2005 21:39:47 +1000 [thread overview]
Message-ID: <E1DTehn-0005gJ-00@gondolin.me.apana.org.au> (raw)
In-Reply-To: <20050505.185503.78606493.yoshfuji@linux-ipv6.org>
YOSHIFUJI Hideaki / ???? <yoshfuji@linux-ipv6.org> wrote:
> In article <42798AC1.2010308@cs.wisc.edu> (at Wed, 04 May 2005 19:53:53 -0700), Mike Christie <michaelc@cs.wisc.edu> says:
>
>> +struct iscsi_uevent {
> :
>> +} __attribute__ ((aligned (sizeof(unsigned long))));
>
> I think it'd be better to use sizeof(uint64_t) or something.
Is there a benefit in aligning on 64-bit boundaries for 32-bit platforms?
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2005-05-05 11:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-05 2:53 [PATCH 2/3] add open iscsi netlink interface to iscsi transport class Mike Christie
2005-05-05 9:55 ` YOSHIFUJI Hideaki / 吉藤英明
2005-05-05 11:39 ` Herbert Xu [this message]
2005-05-05 11:45 ` Arjan van de Ven
2005-05-05 11:55 ` YOSHIFUJI Hideaki / 吉藤英明
2005-05-05 12:22 ` Matthew Wilcox
2005-05-15 19:30 Mike Christie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1DTehn-0005gJ-00@gondolin.me.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
--cc=netdev@oss.sgi.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).