From: Greg KH <greg@kroah.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linuxppc64-dev@ozlabs.org, linux-kernel@vger.kernel.org,
Paul Mackerras <paulus@samba.org>,
Anton Blanchard <anton@samba.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>
Subject: Re: [PATCH 7/8] ppc64: SPU file system
Date: Mon, 16 May 2005 15:27:36 -0700 [thread overview]
Message-ID: <20050516222736.GA13350@kroah.com> (raw)
In-Reply-To: <200505170001.10405.arnd@arndb.de>
On Tue, May 17, 2005 at 12:01:05AM +0200, Arnd Bergmann wrote:
> On Maandag 16 Mai 2005 22:58, Greg KH wrote:
> > On Sat, May 14, 2005 at 03:05:06PM +0200, Arnd Bergmann wrote:
>
> > > 2. sys_spufs_run(int fd, __u32 pc, __u32 *new_pc, __u32 *status):
> > > pro:
> > > - strong types
> > > - can have both input and output arguments
> > > contra:
> > > - does not fit file system semantics well
> > > - bad for prototyping
> >
> > I suggest you do this. Based on what you say you want the code to do, I
> > agree, write() doesn't really work out well
>
> The syscall approach has another small disadvantage in that I need to
> do a callback registration mechanism for it if I want to have spufs as
> a loadable module. I could of course require spufs to be builtin, but
> that complicates prototype testing (as mentioned) and enlarges combined
> pSeries/powermac/BPA distro kernels.
Huh? We can handle syscalls in modules these days pretty simply. Look
at how nfs and others do it.
> I think I'll leave the ioctl for now and add a note saying that I need
> to replace it with a syscall or the write/read or lseek/read based
> approach when I arrive at a more feature complete point.
Nah, make it a syscall :)
> > (but it might, and if you
> > want an example of how to do it, look at the ibmasm driver, it
> > implements write() in a way much like what you are wanting to do.)
>
> That would be the same write/read combination as Ben's second
> proposal and the nfsctl file system, right?
Yes.
> > > My solution was to force the dentries in each directory to be
> > > present. When the directory is created, the files are already
> > > there and unlinking a single file is impossible. To destroy the
> > > spu context, the user has to rmdir it, which will either remove
> > > all files in there as well or fail in the case that any file is
> > > still open.
> >
> > Ick.
> >
> > > Of course that is not really Posix behavior, but it avoids some
> > > other pitfalls.
> >
> > Go with a syscall :)
>
> Sorry, I'm not following that reasoning. How does a syscall help
> with the problem of atomic context destruction?
Sorry, I thought they were referring to the same issue.
greg k-h
next prev parent reply other threads:[~2005-05-16 22:31 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-13 19:31 [PATCH 0/8] ppc64: Introduce Cell/BPA platform, v2 Arnd Bergmann
2005-05-13 19:21 ` [PATCH 1/8] ppc64: split out generic rtas code from pSeries_pci.c Arnd Bergmann
2005-05-13 19:23 ` [PATCH 2/8] ppc64: add a minimal nvram driver Arnd Bergmann
2005-05-13 19:24 ` [PATCH 3/8] ppc64: add a watchdog driver for rtas Arnd Bergmann
2005-05-17 20:40 ` Nathan Lynch
2005-05-18 7:14 ` Arnd Bergmann
2005-05-18 14:45 ` Nathan Lynch
2005-05-18 14:39 ` Arnd Bergmann
2005-05-13 19:25 ` [PATCH 4/8] ppc64: add BPA platform type Arnd Bergmann
2005-05-17 7:01 ` Paul Mackerras
2005-05-17 11:05 ` Arnd Bergmann
2005-05-13 19:26 ` [PATCH 5/8] ppc64: Add driver for BPA interrupt controllers Arnd Bergmann
2005-05-13 19:27 ` [PATCH 6/8] ppc64: Add driver for BPA iommu Arnd Bergmann
2005-05-13 19:29 ` [PATCH 7/8] ppc64: SPU file system Arnd Bergmann
2005-05-13 23:31 ` Benjamin Herrenschmidt
2005-05-15 9:07 ` Pavel Machek
2005-05-15 12:02 ` Benjamin Herrenschmidt
2005-05-15 12:33 ` Arnd Bergmann
2005-05-14 7:45 ` Greg KH
2005-05-14 13:05 ` Arnd Bergmann
2005-05-15 6:29 ` Benjamin Herrenschmidt
2005-05-15 10:08 ` Arnd Bergmann
2005-05-15 11:50 ` Arnd Bergmann
2005-05-16 20:58 ` Greg KH
2005-05-16 22:01 ` Arnd Bergmann
2005-05-16 22:27 ` Greg KH [this message]
2005-05-16 22:22 ` Arnd Bergmann
2005-05-16 22:49 ` Greg KH
2005-05-15 11:24 ` Andi Kleen
2005-05-16 20:14 ` Roland Dreier
2005-05-16 20:53 ` Greg KH
2005-05-18 12:40 ` [PATCH] libfs: add simple attribute files Arnd Bergmann
2005-05-18 20:24 ` Greg KH
2005-05-19 8:29 ` Arnd Bergmann
2005-05-19 9:18 ` 2.4 Kernel threads linux
2005-06-10 4:33 ` [PATCH] libfs: add simple attribute files Greg KH
2005-05-13 19:32 ` [PATCH 8/8] ppc64: add spufs user library Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050516222736.GA13350@kroah.com \
--to=greg@kroah.com \
--cc=anton@samba.org \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc64-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).