From: Arnd Bergmann <arnd@arndb.de>
To: Paul Mackerras <paulus@samba.org>
Cc: linuxppc64-dev@ozlabs.org, linux-kernel@vger.kernel.org,
Anton Blanchard <anton@samba.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>
Subject: Re: [PATCH 4/8] ppc64: add BPA platform type
Date: Tue, 17 May 2005 13:05:12 +0200 [thread overview]
Message-ID: <200505171305.13471.arnd@arndb.de> (raw)
In-Reply-To: <17033.38609.60873.138572@cargo.ozlabs.ibm.com>
On Dinsdag 17 Mai 2005 09:01, Paul Mackerras wrote:
> Arnd Bergmann writes:
>
> > This adds the basic support for running on BPA machines.
> > So far, this is only the IBM workstation, and it will
> > not run on others without a little more generalization.
>
> > +/* FIXME: consolidate this into rtas.c or similar */
> > +static void __init pSeries_calibrate_decr(void)
>
> Shouldn't this be called bpa_calibrate_decr or something similar?
The function is identical to the one for pSeries, and I'd
prefer to have only one copy of it with a more generic name.
Actually, it looks like maple and perhaps pmac have a very
similar *_calibrate_decr function, so I could perhaps
just put this into time.c as generic_calibrate_decr().
[ Ben, can you tell if pSeries_calibrate_decr should work on
all G5 macs or if it can be changed to support them as well? ]
On a similar issue, I just remembered that I wanted to
create a rtas_time.c to hold the rtc access functions
for pSeries and BPA. Do you think that's a good idea?
> > -#define PV_630 0x0040
> > -#define PV_630p 0x0041
> > +#define PV_630 0x0040
> > +#define PV_630p 0x0041
>
> Hmmm, I don't think your patch needs to clean up the whitespace here.
ok.
Arnd <><
next prev parent reply other threads:[~2005-05-17 11:25 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-13 19:31 [PATCH 0/8] ppc64: Introduce Cell/BPA platform, v2 Arnd Bergmann
2005-05-13 19:21 ` [PATCH 1/8] ppc64: split out generic rtas code from pSeries_pci.c Arnd Bergmann
2005-05-13 19:23 ` [PATCH 2/8] ppc64: add a minimal nvram driver Arnd Bergmann
2005-05-13 19:24 ` [PATCH 3/8] ppc64: add a watchdog driver for rtas Arnd Bergmann
2005-05-17 20:40 ` Nathan Lynch
2005-05-18 7:14 ` Arnd Bergmann
2005-05-18 14:45 ` Nathan Lynch
2005-05-18 14:39 ` Arnd Bergmann
2005-05-13 19:25 ` [PATCH 4/8] ppc64: add BPA platform type Arnd Bergmann
2005-05-17 7:01 ` Paul Mackerras
2005-05-17 11:05 ` Arnd Bergmann [this message]
2005-05-13 19:26 ` [PATCH 5/8] ppc64: Add driver for BPA interrupt controllers Arnd Bergmann
2005-05-13 19:27 ` [PATCH 6/8] ppc64: Add driver for BPA iommu Arnd Bergmann
2005-05-13 19:29 ` [PATCH 7/8] ppc64: SPU file system Arnd Bergmann
2005-05-13 23:31 ` Benjamin Herrenschmidt
2005-05-15 9:07 ` Pavel Machek
2005-05-15 12:02 ` Benjamin Herrenschmidt
2005-05-15 12:33 ` Arnd Bergmann
2005-05-14 7:45 ` Greg KH
2005-05-14 13:05 ` Arnd Bergmann
2005-05-15 6:29 ` Benjamin Herrenschmidt
2005-05-15 10:08 ` Arnd Bergmann
2005-05-15 11:50 ` Arnd Bergmann
2005-05-16 20:58 ` Greg KH
2005-05-16 22:01 ` Arnd Bergmann
2005-05-16 22:27 ` Greg KH
2005-05-16 22:22 ` Arnd Bergmann
2005-05-16 22:49 ` Greg KH
2005-05-15 11:24 ` Andi Kleen
2005-05-16 20:14 ` Roland Dreier
2005-05-16 20:53 ` Greg KH
2005-05-18 12:40 ` [PATCH] libfs: add simple attribute files Arnd Bergmann
2005-05-18 20:24 ` Greg KH
2005-05-19 8:29 ` Arnd Bergmann
2005-05-19 9:18 ` 2.4 Kernel threads linux
2005-06-10 4:33 ` [PATCH] libfs: add simple attribute files Greg KH
2005-05-13 19:32 ` [PATCH 8/8] ppc64: add spufs user library Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200505171305.13471.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=anton@samba.org \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc64-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).