From: Andi Kleen <ak@suse.de>
To: Greg KH <gregkh@suse.de>
Cc: Rajesh Shah <rajesh.shah@intel.com>,
len.brown@intel.com, ak@suse.de,
acpi-devel@lists.sourceforge.net,
linux-pci@atrey.karlin.mff.cuni.cz, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 03/04] PCI: use the MCFG table to properly access pci devices (x86-64)
Date: Fri, 17 Jun 2005 01:00:20 +0200 [thread overview]
Message-ID: <20050616230020.GM7048@bragg.suse.de> (raw)
In-Reply-To: <20050616224223.GA13619@suse.de>
On Thu, Jun 16, 2005 at 03:42:23PM -0700, Greg KH wrote:
> On Thu, Jun 16, 2005 at 03:34:06PM -0700, Rajesh Shah wrote:
> > On Tue, Jun 14, 2005 at 10:32:14PM -0700, Greg KH wrote:
> > >
> > > + for (i = 0; i < pci_mmcfg_config_num; ++i) {
> > > + pci_mmcfg_virt[i].cfg = &pci_mmcfg_config[i];
> > > + pci_mmcfg_virt[i].virt = ioremap_nocache(pci_mmcfg_config[i].base_address, MMCONFIG_APER_SIZE);
> >
> > This will map 256MB for each mmcfg aperture, probably better
> > to restrict it based on bus number range for this aperture.
>
> It should be 1MB per bus number, right?
It shouldn't make much difference anyways - we have plenty of vmalloc
space on x86-64
The only advantage of using the exact number would be maybe to detect overruns.
-Andi
next prev parent reply other threads:[~2005-06-16 23:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-15 5:29 [PATCH 00/04] PCI: add proper MCFG support to let AMD boxes support MMCONFIG Greg KH
2005-06-15 5:30 ` [PATCH 01/04] PCI: add proper MCFG table parsing to ACPI core Greg KH
2005-06-15 5:31 ` [PATCH 02/04] PCI: use the MCFG table to properly access pci devices (i386) Greg KH
2005-06-15 5:32 ` [PATCH 03/04] PCI: use the MCFG table to properly access pci devices (x86-64) Greg KH
2005-06-15 5:33 ` [PATCH 04/04] PCI: let AMD boxes use MMCONFIG Greg KH
2005-06-16 22:34 ` [PATCH 03/04] PCI: use the MCFG table to properly access pci devices (x86-64) Rajesh Shah
2005-06-16 22:42 ` Greg KH
2005-06-16 23:00 ` Andi Kleen [this message]
2005-06-16 23:49 ` Brian Gerst
2005-06-17 1:15 ` Rajesh Shah
2005-06-15 9:48 ` [PATCH 02/04] PCI: use the MCFG table to properly access pci devices (i386) Andi Kleen
2005-06-15 17:31 ` Jeff Garzik
2005-06-15 17:54 ` Greg KH
2005-06-15 18:23 ` Andi Kleen
2005-06-15 18:35 ` Greg KH
2005-06-15 19:03 ` Andi Kleen
2005-06-15 20:21 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050616230020.GM7048@bragg.suse.de \
--to=ak@suse.de \
--cc=acpi-devel@lists.sourceforge.net \
--cc=gregkh@suse.de \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=rajesh.shah@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).