linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] silence cs89x0
@ 2005-06-17  5:26 Denis Vlasenko
  0 siblings, 0 replies; only message in thread
From: Denis Vlasenko @ 2005-06-17  5:26 UTC (permalink / raw)
  To: Jeff Garzik; +Cc: linux-kernel

[-- Attachment #1: Type: text/plain, Size: 176 bytes --]

Hi Jeff,

cs89x0 talks a lot at boot. Seems like debug leftover.
This patch downgrades printks to KERN_DEBUG.
While we're at it, make these messages a bit less obscure.
--
vda

[-- Attachment #2: cs89x0.c.diff --]
[-- Type: text/x-diff, Size: 2097 bytes --]

cs89x0:cs89x0_probe(0x0)
PP_addr=0xffff
eth1: incorrect signature 0xffff
PP_addr=0xffff
eth1: incorrect signature 0xffff
PP_addr=0xffff
eth1: incorrect signature 0xffff
PP_addr=0xffff
eth1: incorrect signature 0xffff
PP_addr=0xffff
eth1: incorrect signature 0xffff
PP_addr=0xffff
eth1: incorrect signature 0xffff
PP_addr=0xffff
eth1: incorrect signature 0xffff
PP_addr=0xffff
eth1: incorrect signature 0xffff
PP_addr=0xffff
eth1: incorrect signature 0xffff
PP_addr=0xffff
eth1: incorrect signature 0xffff
PP_addr=0xffff
eth1: incorrect signature 0xffff
PP_addr=0xffff
eth1: incorrect signature 0xffff
cs89x0: no cs8900 or cs8920 detected.  Be sure to disable PnP with SETUP


--- linux-2.6.12-rc5.src/drivers/net/cs89x0.h.orig	Tue Oct 19 00:54:39 2004
+++ linux-2.6.12-rc5.src/drivers/net/cs89x0.h	Fri Jun 17 01:04:53 2005
@@ -93,6 +93,7 @@
 #endif
 
 #define CHIP_EISA_ID_SIG 0x630E   /*  Product ID Code for Crystal Chip (CS8900 spec 4.3) */
+#define CHIP_EISA_ID_SIG_STR "0x630E"
 
 #ifdef IBMEIPKT
 #define EISA_ID_SIG 0x4D24	/*  IBM */
--- linux-2.6.12-rc5.src/drivers/net/cs89x0.c.orig	Tue May 31 16:18:35 2005
+++ linux-2.6.12-rc5.src/drivers/net/cs89x0.c	Fri Jun 17 01:06:04 2005
@@ -416,6 +416,7 @@ cs89x0_probe1(struct net_device *dev, in
 	struct net_local *lp = netdev_priv(dev);
 	static unsigned version_printed;
 	int i;
+	int tmp;
 	unsigned rev_type = 0;
 	int eeprom_buff[CHKSUM_LEN];
 	int retval;
@@ -467,14 +468,17 @@ cs89x0_probe1(struct net_device *dev, in
 				goto out2;
 			}
 	}
-printk("PP_addr=0x%x\n", inw(ioaddr + ADD_PORT));
+	printk(KERN_DEBUG "PP_addr at %x: 0x%x\n",
+			ioaddr + ADD_PORT, inw(ioaddr + ADD_PORT));
 
 	ioaddr &= ~3;
 	outw(PP_ChipID, ioaddr + ADD_PORT);
 
-	if (inw(ioaddr + DATA_PORT) != CHIP_EISA_ID_SIG) {
-		printk(KERN_ERR "%s: incorrect signature 0x%x\n",
-			dev->name, inw(ioaddr + DATA_PORT));
+	tmp = inw(ioaddr + DATA_PORT);
+	if (tmp != CHIP_EISA_ID_SIG) {
+		printk(KERN_DEBUG "%s: incorrect signature at %x: 0x%x!="
+			CHIP_EISA_ID_SIG_STR "\n",
+			dev->name, ioaddr + DATA_PORT, tmp);
   		retval = -ENODEV;
   		goto out2;
 	}

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2005-06-17  5:27 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-06-17  5:26 [PATCH] silence cs89x0 Denis Vlasenko

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).