* [PATCH] fealnx.c calls dev_kfree_skb from atomic context. fix it
@ 2005-06-17 7:22 Denis Vlasenko
0 siblings, 0 replies; only message in thread
From: Denis Vlasenko @ 2005-06-17 7:22 UTC (permalink / raw)
To: Jeff Garzik; +Cc: linux-kernel
[-- Attachment #1: Type: text/plain, Size: 66 bytes --]
Hi Jeff,
Just a resend. Applies with offset to 2.6.12-rc2
--
vda
[-- Attachment #2: fealnx_skbfree.patch --]
[-- Type: text/x-diff, Size: 696 bytes --]
I believe I actually saw 'Badness' message because I used
wrong function.
No need to check and use exactly matching function,
This is not a fast path.
diff -urN linux-2.6.6-bk7.src/drivers/net/fealnx.c linux-2.6.6-bk7-fealnx.src/drivers/net/fealnx.c
--- linux-2.6.6-bk7.src/drivers/net/fealnx.c Thu May 20 21:38:05 2004
+++ linux-2.6.6-bk7-fealnx.src/drivers/net/fealnx.c Thu May 20 21:43:31 2004
@@ -1435,8 +1435,7 @@
if (cur->skbuff) {
pci_unmap_single(np->pci_dev, cur->buffer,
cur->skbuff->len, PCI_DMA_TODEVICE);
- dev_kfree_skb(cur->skbuff);
- /* or dev_kfree_skb_irq(cur->skbuff); ? */
+ dev_kfree_skb_any(cur->skbuff);
cur->skbuff = NULL;
}
cur->status = 0;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2005-06-17 7:22 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-06-17 7:22 [PATCH] fealnx.c calls dev_kfree_skb from atomic context. fix it Denis Vlasenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).