[patch 1/1] list_for_each_entry: fs-dquot.c

[patch 1/1] list_for_each_entry: fs-dquot.c

[domen]

[-- Attachment #1: list-for-each-entry-safe-fs_dquot.patch --]
[-- Type: text/plain, Size: 985 bytes --]

From: Domen Puncer <domen@coderock.org>



Make code more readable with list_for_each_entry_safe.

Signed-off-by: Domen Puncer <domen@coderock.org>
Signed-off-by: Maximilian Attems <janitor@sternwelten.at>
Signed-off-by: Domen Puncer <domen@coderock.org>
---
 dquot.c |    7 ++-----
 1 files changed, 2 insertions(+), 5 deletions(-)

Index: quilt/fs/dquot.c
===================================================================
--- quilt.orig/fs/dquot.c
+++ quilt/fs/dquot.c
@@ -409,13 +409,10 @@ out_dqlock:
  * for this sb+type at all. */
 static void invalidate_dquots(struct super_block *sb, int type)
 {
-	struct dquot *dquot;
-	struct list_head *head;
+	struct dquot *dquot, *tmp;
 
 	spin_lock(&dq_list_lock);
-	for (head = inuse_list.next; head != &inuse_list;) {
-		dquot = list_entry(head, struct dquot, dq_inuse);
-		head = head->next;
+	list_for_each_entry_safe(dquot, tmp, &inuse_list, dq_inuse) {
 		if (dquot->dq_sb != sb)
 			continue;
 		if (dquot->dq_type != type)

--

Re: [patch 1/1] list_for_each_entry: fs-dquot.c

[Jan Kara]

  Hello,

> From: Domen Puncer <domen@coderock.org>
> 
> 
> 
> Make code more readable with list_for_each_entry_safe.
  Thanks for the patch. I've forwarded it to Andrew Morton with my ACK.

									Honza

[patch 1/1] list_for_each_entry: fs-dquot.c

[domen]

Make code more readable with list_for_each_entry_safe.
(Didn't compile before, doesn't compile now)

Signed-off-by: Domen Puncer <domen@coderock.org>
Signed-off-by: Maximilian Attems <janitor@sternwelten.at>
Signed-off-by: Domen Puncer <domen@coderock.org>
---


 kj-domen/fs/dquot.c |    7 ++-----
 1 files changed, 2 insertions(+), 5 deletions(-)

diff -puN fs/dquot.c~list-for-each-entry-safe-fs_dquot fs/dquot.c
--- kj/fs/dquot.c~list-for-each-entry-safe-fs_dquot	2005-01-10 17:59:46.000000000 +0100
+++ kj-domen/fs/dquot.c	2005-01-10 17:59:46.000000000 +0100
@@ -406,13 +406,10 @@ out_dqlock:
  * for this sb+type at all. */
 static void invalidate_dquots(struct super_block *sb, int type)
 {
-	struct dquot *dquot;
-	struct list_head *head;
+	struct dquot *dquot, *tmp;
 
 	spin_lock(&dq_list_lock);
-	for (head = inuse_list.next; head != &inuse_list;) {
-		dquot = list_entry(head, struct dquot, dq_inuse);
-		head = head->next;
+	list_for_each_entry_safe(dquot, tmp, &inuse_list, dq_inuse) {
 		if (dquot->dq_sb != sb)
 			continue;
 		if (dquot->dq_type != type)
_

Re: [patch 1/1] list_for_each_entry: fs-dquot.c

[Jan Kara]

  Hello,

> Make code more readable with list_for_each_entry_safe.
> (Didn't compile before, doesn't compile now)
  What do you mean by "didn't compile before"? Which kernel have you
tried?

> Signed-off-by: Maximilian Attems <janitor@sternwelten.at>
> Signed-off-by: Domen Puncer <domen@coderock.org>
> ---
> 
> 
>  kj-domen/fs/dquot.c |    7 ++-----
>  1 files changed, 2 insertions(+), 5 deletions(-)
> 
> diff -puN fs/dquot.c~list-for-each-entry-safe-fs_dquot fs/dquot.c
> --- kj/fs/dquot.c~list-for-each-entry-safe-fs_dquot	2005-01-10 17:59:46.000000000 +0100
> +++ kj-domen/fs/dquot.c	2005-01-10 17:59:46.000000000 +0100
> @@ -406,13 +406,10 @@ out_dqlock:
>   * for this sb+type at all. */
>  static void invalidate_dquots(struct super_block *sb, int type)
>  {
> -	struct dquot *dquot;
> -	struct list_head *head;
> +	struct dquot *dquot, *tmp;
>  
>  	spin_lock(&dq_list_lock);
> -	for (head = inuse_list.next; head != &inuse_list;) {
> -		dquot = list_entry(head, struct dquot, dq_inuse);
> -		head = head->next;
> +	list_for_each_entry_safe(dquot, tmp, &inuse_list, dq_inuse) {
>  		if (dquot->dq_sb != sb)
>  			continue;
>  		if (dquot->dq_type != type)


								Honza
-- 
Jan Kara <jack@suse.cz>
SuSE CR Labs

Re: [patch 1/1] list_for_each_entry: fs-dquot.c

[Domen Puncer]

On 11/01/05 15:34 +0100, Jan Kara wrote:
>   Hello,
> 
> > Make code more readable with list_for_each_entry_safe.
> > (Didn't compile before, doesn't compile now)
>   What do you mean by "didn't compile before"? Which kernel have you
> tried?

It seems like it was compile tested with quotas disabled.
It compiles fine when i enable quotas, duh.
Sorry.


	Domen