* [2.6 patch] mm/slab: unexport kmem_cache_alloc_node
@ 2005-07-02 11:37 Adrian Bunk
0 siblings, 0 replies; 11+ messages in thread
From: Adrian Bunk @ 2005-07-02 11:37 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel
I didn't find any modular usage of kmem_cache_alloc_node.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
This patch was already sent on:
- 21 Jun 2005
- 30 May 2005
- 15 May 2005
--- linux-2.6.11-mm1-full/mm/slab.c.old 2005-03-06 15:40:38.000000000 +0100
+++ linux-2.6.11-mm1-full/mm/slab.c 2005-03-06 15:41:06.000000000 +0100
@@ -2431,7 +2440,6 @@
__builtin_return_address(0));
return objp;
}
-EXPORT_SYMBOL(kmem_cache_alloc_node);
#endif
^ permalink raw reply [flat|nested] 11+ messages in thread
* [2.6 patch] mm/slab: unexport kmem_cache_alloc_node
@ 2006-02-20 22:36 Adrian Bunk
2006-02-21 1:02 ` Andrew Morton
0 siblings, 1 reply; 11+ messages in thread
From: Adrian Bunk @ 2006-02-20 22:36 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel
I didn't find any modular usage of kmem_cache_alloc_node.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
This patch was already sent on:
- 27 Jul 2005
- 2 Jul 2005
- 21 Jun 2005
- 30 May 2005
- 15 May 2005
--- linux-2.6.11-mm1-full/mm/slab.c.old 2005-03-06 15:40:38.000000000 +0100
+++ linux-2.6.11-mm1-full/mm/slab.c 2005-03-06 15:41:06.000000000 +0100
@@ -2431,7 +2440,6 @@
__builtin_return_address(0));
return objp;
}
-EXPORT_SYMBOL(kmem_cache_alloc_node);
#endif
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [2.6 patch] mm/slab: unexport kmem_cache_alloc_node
2006-02-20 22:36 Adrian Bunk
@ 2006-02-21 1:02 ` Andrew Morton
0 siblings, 0 replies; 11+ messages in thread
From: Andrew Morton @ 2006-02-21 1:02 UTC (permalink / raw)
To: Adrian Bunk; +Cc: linux-kernel
Adrian Bunk <bunk@stusta.de> wrote:
>
> I didn't find any modular usage of kmem_cache_alloc_node.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> ---
>
> This patch was already sent on:
> - 27 Jul 2005
> - 2 Jul 2005
> - 21 Jun 2005
> - 30 May 2005
> - 15 May 2005
>
> --- linux-2.6.11-mm1-full/mm/slab.c.old 2005-03-06 15:40:38.000000000 +0100
> +++ linux-2.6.11-mm1-full/mm/slab.c 2005-03-06 15:41:06.000000000 +0100
> @@ -2431,7 +2440,6 @@
> __builtin_return_address(0));
> return objp;
> }
> -EXPORT_SYMBOL(kmem_cache_alloc_node);
>
> #endif
>
kmem_cache_alloc_node() is part of the slab API and it is reasonable that
it be exported in this manner along with the rest of that API. If someone
wanted to use kmem_cache_alloc_node() and found it wasn't exported like the
rest of the slab functions, that would look weird.
So I don't think we need bother going through the drawn-out pain of
retracting an export which has been in-tree for a year or so.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [2.6 patch] mm/slab: unexport kmem_cache_alloc_node
@ 2005-07-27 19:51 Adrian Bunk
2005-07-27 20:03 ` Andrew Morton
0 siblings, 1 reply; 11+ messages in thread
From: Adrian Bunk @ 2005-07-27 19:51 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel
I didn't find any modular usage of kmem_cache_alloc_node.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
This patch was already sent on:
- 2 Jul 2005
- 21 Jun 2005
- 30 May 2005
- 15 May 2005
--- linux-2.6.11-mm1-full/mm/slab.c.old 2005-03-06 15:40:38.000000000 +0100
+++ linux-2.6.11-mm1-full/mm/slab.c 2005-03-06 15:41:06.000000000 +0100
@@ -2431,7 +2440,6 @@
__builtin_return_address(0));
return objp;
}
-EXPORT_SYMBOL(kmem_cache_alloc_node);
#endif
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [2.6 patch] mm/slab: unexport kmem_cache_alloc_node
2005-07-27 19:51 Adrian Bunk
@ 2005-07-27 20:03 ` Andrew Morton
2005-07-27 20:19 ` Christoph Lameter
0 siblings, 1 reply; 11+ messages in thread
From: Andrew Morton @ 2005-07-27 20:03 UTC (permalink / raw)
To: Adrian Bunk; +Cc: linux-kernel, Christoph Lameter
Adrian Bunk <bunk@stusta.de> wrote:
>
> I didn't find any modular usage of kmem_cache_alloc_node.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> ---
>
> This patch was already sent on:
> - 2 Jul 2005
> - 21 Jun 2005
> - 30 May 2005
> - 15 May 2005
Yeah, I've been ducking that one.
> --- linux-2.6.11-mm1-full/mm/slab.c.old 2005-03-06 15:40:38.000000000 +0100
> +++ linux-2.6.11-mm1-full/mm/slab.c 2005-03-06 15:41:06.000000000 +0100
> @@ -2431,7 +2440,6 @@
> __builtin_return_address(0));
> return objp;
> }
> -EXPORT_SYMBOL(kmem_cache_alloc_node);
>
> #endif
Even though we don't currently have in-module users, we probably will do so
soon and it's a part of the slab API and the slab API is exported to
modules. I don't see much point in partially-exporting the API and
applying a patch which we'll soon revert.
Christoph?
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [2.6 patch] mm/slab: unexport kmem_cache_alloc_node
2005-07-27 20:03 ` Andrew Morton
@ 2005-07-27 20:19 ` Christoph Lameter
2005-07-27 20:50 ` Adrian Bunk
0 siblings, 1 reply; 11+ messages in thread
From: Christoph Lameter @ 2005-07-27 20:19 UTC (permalink / raw)
To: Andrew Morton; +Cc: Adrian Bunk, linux-kernel
On Wed, 27 Jul 2005, Andrew Morton wrote:
> > return objp;
> > }
> > -EXPORT_SYMBOL(kmem_cache_alloc_node);
> >
> > #endif
>
> Even though we don't currently have in-module users, we probably will do so
> soon and it's a part of the slab API and the slab API is exported to
> modules. I don't see much point in partially-exporting the API and
> applying a patch which we'll soon revert.
>
> Christoph?
>
I fully agree. Drivers will have to use that call in the future in order
to properly place their control structures. The e1000 in your tree already
does so and may be compiled as a module. Thus applying this patch will
break mm.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [2.6 patch] mm/slab: unexport kmem_cache_alloc_node
2005-07-27 20:19 ` Christoph Lameter
@ 2005-07-27 20:50 ` Adrian Bunk
2005-07-27 20:55 ` Christoph Lameter
0 siblings, 1 reply; 11+ messages in thread
From: Adrian Bunk @ 2005-07-27 20:50 UTC (permalink / raw)
To: Christoph Lameter; +Cc: Andrew Morton, linux-kernel
On Wed, Jul 27, 2005 at 01:19:00PM -0700, Christoph Lameter wrote:
> On Wed, 27 Jul 2005, Andrew Morton wrote:
>
> > > return objp;
> > > }
> > > -EXPORT_SYMBOL(kmem_cache_alloc_node);
> > >
> > > #endif
> >
> > Even though we don't currently have in-module users, we probably will do so
> > soon and it's a part of the slab API and the slab API is exported to
> > modules. I don't see much point in partially-exporting the API and
> > applying a patch which we'll soon revert.
> >
> > Christoph?
> >
>
> I fully agree. Drivers will have to use that call in the future in order
> to properly place their control structures. The e1000 in your tree already
> does so and may be compiled as a module. Thus applying this patch will
> break mm.
I don't see e1000 in 2.6.13-rc3-mm2 using it.
And yes, I tried compilation of as much as possible (including e1000) in
2.6.13-rc3-mm2 with my patch applied before resending it.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [2.6 patch] mm/slab: unexport kmem_cache_alloc_node
2005-07-27 20:50 ` Adrian Bunk
@ 2005-07-27 20:55 ` Christoph Lameter
0 siblings, 0 replies; 11+ messages in thread
From: Christoph Lameter @ 2005-07-27 20:55 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Andrew Morton, linux-kernel
On Wed, 27 Jul 2005, Adrian Bunk wrote:
> > I fully agree. Drivers will have to use that call in the future in order
> > to properly place their control structures. The e1000 in your tree already
> > does so and may be compiled as a module. Thus applying this patch will
> > break mm.
>
> I don't see e1000 in 2.6.13-rc3-mm2 using it.
Hmmm. Ok. e1000 only uses kmalloc_node which is based on
kmem_cache_alloc_node. However, kmalloc_node will likely become a
macro like kmalloc.
Applying the patch would mean that modules would only be
able to use kmalloc_node and not able to allocate node specific memory
from one of the slab caches.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [2.6 patch] mm/slab: unexport kmem_cache_alloc_node
@ 2005-06-20 23:43 Adrian Bunk
0 siblings, 0 replies; 11+ messages in thread
From: Adrian Bunk @ 2005-06-20 23:43 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel
I didn't find any modular usage of kmem_cache_alloc_node.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
This patch was already sent on:
- 30 May 2005
- 15 May 2005
--- linux-2.6.11-mm1-full/mm/slab.c.old 2005-03-06 15:40:38.000000000 +0100
+++ linux-2.6.11-mm1-full/mm/slab.c 2005-03-06 15:41:06.000000000 +0100
@@ -2431,7 +2440,6 @@
__builtin_return_address(0));
return objp;
}
-EXPORT_SYMBOL(kmem_cache_alloc_node);
#endif
^ permalink raw reply [flat|nested] 11+ messages in thread
* [2.6 patch] mm/slab: unexport kmem_cache_alloc_node
@ 2005-05-30 0:28 Adrian Bunk
0 siblings, 0 replies; 11+ messages in thread
From: Adrian Bunk @ 2005-05-30 0:28 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel
I didn't find any modular usage of kmem_cache_alloc_node.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
This patch was already sent on:
- 15 May 2005
--- linux-2.6.11-mm1-full/mm/slab.c.old 2005-03-06 15:40:38.000000000 +0100
+++ linux-2.6.11-mm1-full/mm/slab.c 2005-03-06 15:41:06.000000000 +0100
@@ -2431,7 +2440,6 @@
__builtin_return_address(0));
return objp;
}
-EXPORT_SYMBOL(kmem_cache_alloc_node);
#endif
^ permalink raw reply [flat|nested] 11+ messages in thread
* [2.6 patch] mm/slab: unexport kmem_cache_alloc_node
@ 2005-05-15 13:28 Adrian Bunk
0 siblings, 0 replies; 11+ messages in thread
From: Adrian Bunk @ 2005-05-15 13:28 UTC (permalink / raw)
To: linux-kernel
I didn't find any modular usage of kmem_cache_alloc_node.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.11-mm1-full/mm/slab.c.old 2005-03-06 15:40:38.000000000 +0100
+++ linux-2.6.11-mm1-full/mm/slab.c 2005-03-06 15:41:06.000000000 +0100
@@ -2431,7 +2440,6 @@
__builtin_return_address(0));
return objp;
}
-EXPORT_SYMBOL(kmem_cache_alloc_node);
#endif
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2006-02-21 1:06 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-07-02 11:37 [2.6 patch] mm/slab: unexport kmem_cache_alloc_node Adrian Bunk
-- strict thread matches above, loose matches on Subject: below --
2006-02-20 22:36 Adrian Bunk
2006-02-21 1:02 ` Andrew Morton
2005-07-27 19:51 Adrian Bunk
2005-07-27 20:03 ` Andrew Morton
2005-07-27 20:19 ` Christoph Lameter
2005-07-27 20:50 ` Adrian Bunk
2005-07-27 20:55 ` Christoph Lameter
2005-06-20 23:43 Adrian Bunk
2005-05-30 0:28 Adrian Bunk
2005-05-15 13:28 Adrian Bunk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).