linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
To: Clemens Ladisch <clemens@ladisch.de>
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org,
	Bob Picco <bob.picco@hp.com>
Subject: Re: [PATCH 5/7] HPET-RTC: disable interrupt when no longer needed
Date: Wed, 28 Sep 2005 06:03:06 -0700	[thread overview]
Message-ID: <20050928060306.A26313@unix-os.sc.intel.com> (raw)
In-Reply-To: <20050928071226.23025.56681.balrog@turing>; from clemens@ladisch.de on Wed, Sep 28, 2005 at 09:12:26AM +0200

On Wed, Sep 28, 2005 at 09:12:26AM +0200, Clemens Ladisch wrote:
> When the emulated RTC interrupt is no longer needed, we better disable
> it; otherwise, we get a spurious interrupt whenever the timer has
> rolled over and reaches the same comparator value.
> 
> Having a superfluous interrupt every five minutes doesn't hurt much,
> but it's bad style anyway.  ;-)
> 

Do you really see the interrupt every five minutes once RTC is disabled.
Or is this to prevent a possible interrupt?
I had assumed while in one-shot interrupt mode, HPET would automatically unarm
after generating the interrupt, so that we won't get interrupts any more.

Thanks,
Venki


  reply	other threads:[~2005-09-28 13:03 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-28  7:11 [PATCH 0/7] HPET fixes and enhancements Clemens Ladisch
2005-09-28  7:12 ` [PATCH 1/7] HPET: remove unused variable Clemens Ladisch
2005-09-28  7:12 ` [PATCH 2/7] HPET: remove superfluous register reads Clemens Ladisch
2005-09-28  7:12 ` [PATCH 3/7] HPET: allow non-power-of-two frequencies Clemens Ladisch
2005-09-28  7:12 ` [PATCH 4/7] HPET: allow shared interrupts Clemens Ladisch
2005-09-28  7:12 ` [PATCH 5/7] HPET-RTC: disable interrupt when no longer needed Clemens Ladisch
2005-09-28 13:03   ` Venkatesh Pallipadi [this message]
2005-09-29  6:30     ` Clemens Ladisch
2005-09-28  7:12 ` [PATCH 6/7] HPET-RTC: fix timer config register accesses Clemens Ladisch
2005-09-28 13:06   ` Venkatesh Pallipadi
2005-09-28  7:12 ` [PATCH 7/7] HPET-RTC: cache the comparator register Clemens Ladisch
2005-09-28 15:44 ` [PATCH 0/7] HPET fixes and enhancements Bob Picco
2005-10-05 20:37 [PATCH 5/7] HPET-RTC: disable interrupt when no longer needed Pallipadi, Venkatesh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050928060306.A26313@unix-os.sc.intel.com \
    --to=venkatesh.pallipadi@intel.com \
    --cc=akpm@osdl.org \
    --cc=bob.picco@hp.com \
    --cc=clemens@ladisch.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).