From: Clemens Ladisch <clemens@ladisch.de>
To: linux-kernel@vger.kernel.org
Cc: akpm@osdl.org, Bob Picco <bob.picco@hp.com>,
Clemens Ladisch <clemens@ladisch.de>
Subject: [PATCH 2/7] HPET: remove superfluous register reads
Date: Wed, 28 Sep 2005 09:12:10 +0200 (MEST) [thread overview]
Message-ID: <20050928071210.23025.1810.balrog@turing> (raw)
In-Reply-To: <20050928071155.23025.43523.balrog@turing>
This patch removes several reads of a timer's config register that
serve no purpose whatsoever.
Signed-off-by: Clemens Ladisch <clemens@ladisch.de>
Index: linux-2.6.13/drivers/char/hpet.c
===================================================================
--- linux-2.6.13.orig/drivers/char/hpet.c 2005-09-27 21:42:12.000000000 +0200
+++ linux-2.6.13/drivers/char/hpet.c 2005-09-27 21:44:11.000000000 +0200
@@ -367,7 +367,6 @@ static int hpet_ioctl_ieon(struct hpet_d
if (!devp->hd_ireqfreq)
return -EIO;
- v = readq(&timer->hpet_config);
spin_lock_irq(&hpet_lock);
if (devp->hd_flags & HPET_IE) {
@@ -378,7 +377,6 @@ static int hpet_ioctl_ieon(struct hpet_d
devp->hd_flags |= HPET_IE;
spin_unlock_irq(&hpet_lock);
- t = readq(&timer->hpet_config);
irq = devp->hd_hdwirq;
if (irq) {
@@ -855,11 +853,9 @@ int hpet_alloc(struct hpet_data *hdp)
}
for (i = 0, devp = hpetp->hp_dev; i < hpetp->hp_ntimer; i++, devp++) {
- unsigned long v;
struct hpet_timer __iomem *timer;
timer = &hpet->hpet_timers[devp - hpetp->hp_dev];
- v = readq(&timer->hpet_config);
devp->hd_hpets = hpetp;
devp->hd_hpet = hpet;
next prev parent reply other threads:[~2005-09-28 7:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-28 7:11 [PATCH 0/7] HPET fixes and enhancements Clemens Ladisch
2005-09-28 7:12 ` [PATCH 1/7] HPET: remove unused variable Clemens Ladisch
2005-09-28 7:12 ` Clemens Ladisch [this message]
2005-09-28 7:12 ` [PATCH 3/7] HPET: allow non-power-of-two frequencies Clemens Ladisch
2005-09-28 7:12 ` [PATCH 4/7] HPET: allow shared interrupts Clemens Ladisch
2005-09-28 7:12 ` [PATCH 5/7] HPET-RTC: disable interrupt when no longer needed Clemens Ladisch
2005-09-28 13:03 ` Venkatesh Pallipadi
2005-09-29 6:30 ` Clemens Ladisch
2005-09-28 7:12 ` [PATCH 6/7] HPET-RTC: fix timer config register accesses Clemens Ladisch
2005-09-28 13:06 ` Venkatesh Pallipadi
2005-09-28 7:12 ` [PATCH 7/7] HPET-RTC: cache the comparator register Clemens Ladisch
2005-09-28 15:44 ` [PATCH 0/7] HPET fixes and enhancements Bob Picco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050928071210.23025.1810.balrog@turing \
--to=clemens@ladisch.de \
--cc=akpm@osdl.org \
--cc=bob.picco@hp.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).