linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
To: Ion Badulescu <lists@limebrokerage.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	linux-kernel@vger.kernel.org, linux-net@vger.kernel.org,
	netdev@vger.kernel.org, gautran@mrv.com
Subject: Re: Possible BUG in IPv4 TCP window handling, all recent 2.4.x/2.6.x kernels
Date: Thu, 29 Sep 2005 19:17:29 +0400	[thread overview]
Message-ID: <20050929151729.GA2158@ms2.inr.ac.ru> (raw)
In-Reply-To: <Pine.LNX.4.61.0509281223560.30951@ionlinux.tower-research.com>

Hello!

> >Anyway, ignoring this puzzle, the following patch for 2.4 should help.
> >
> >
> >--- net/ipv4/tcp_input.c.orig	2003-02-20 20:38:39.000000000 +0300
> >+++ net/ipv4/tcp_input.c	2005-09-02 22:28:00.845952888 +0400
> >@@ -343,8 +343,6 @@
> >			app_win -= tp->ack.rcv_mss;
> >		app_win = max(app_win, 2U*tp->advmss);
> >
> >-		if (!ofo_win)
> >-			tp->window_clamp = min(tp->window_clamp, app_win);
> >		tp->rcv_ssthresh = min(tp->window_clamp, 2U*tp->advmss);
> >	}
> >}
> 
> I'm very happy to report that the above patch, applied to 2.6.12.6, seems 
> to have cured the TCP window problem we were experiencing.

Good. I think the patch is to be applied to all mainstream kernels.

The only obstacle is the second report by Guillaume Autran <gautran@mrv.com>,
which has some allied characteristics, but after analysis it is something
impossible, read, cryptic and severe bug. :-( I did not get a responce
to the last query, so the investigation stalled.

Alexey

  reply	other threads:[~2005-09-29 15:17 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-01 22:30 Possible BUG in IPv4 TCP window handling, all recent 2.4.x/2.6.x kernels Ion Badulescu
2005-09-01 22:43 ` David S. Miller
2005-09-01 22:49   ` Jesper Juhl
2005-09-01 22:53     ` David S. Miller
2005-09-01 22:53   ` Ion Badulescu
2005-09-01 23:37     ` Jesper Juhl
2005-09-02  2:51     ` John Heffner
2005-09-02  6:28       ` David S. Miller
2005-09-02 14:05         ` lists
2005-09-02 14:10           ` John Heffner
2005-09-02 14:33             ` lists
2005-09-02 14:48               ` John Heffner
2005-09-02 15:43                 ` Ion Badulescu
2005-09-02 13:02       ` Guillaume Autran
2005-09-02 13:48         ` Ion Badulescu
2005-09-02 13:52         ` Alexey Kuznetsov
2005-09-02 14:11           ` John Heffner
2005-09-02 13:48       ` Alexey Kuznetsov
2005-09-02 14:16         ` John Heffner
2005-09-02 15:11           ` Alexey Kuznetsov
2005-09-02 18:36     ` Alexey Kuznetsov
2005-09-02 20:57       ` Ion Badulescu
2005-09-02 21:18         ` Alexey Kuznetsov
2005-09-02 23:09           ` Ion Badulescu
2005-09-28 16:31       ` Ion Badulescu
2005-09-29 15:17         ` Alexey Kuznetsov [this message]
2005-09-29 15:34           ` Guillaume Autran
2005-09-29 16:04           ` John Heffner
2005-09-29 18:16             ` David S. Miller
2005-09-30  0:29           ` David S. Miller
2005-09-02  4:51 ` Noritoshi Demizu
2005-09-02  5:20   ` Stephen Hemminger
2005-09-02  5:45     ` Noritoshi Demizu
2005-09-02  6:11       ` Noritoshi Demizu
2005-09-02 12:11         ` Ion Badulescu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050929151729.GA2158@ms2.inr.ac.ru \
    --to=kuznet@ms2.inr.ac.ru \
    --cc=davem@davemloft.net \
    --cc=gautran@mrv.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-net@vger.kernel.org \
    --cc=lists@limebrokerage.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).